commit f433e92721e9ee939ef4f77f2f204d8a1d729194
author Chih-Hung Hsieh <chh@google.com> Wed Oct 18 14:23:34 2017 -0700
committer Chih-Hung Hsieh <chh@google.com> Wed Oct 18 14:23:34 2017 -0700
tree a5e4d9c33e1f1a821bb8f2bcf1dd01a9b1af46a5
parent 978467b255934a76834d87552eb046cac922ebb4

Use -Werror in external/libtextclassifier

* Suppress existing warnings, to catch new warnings.

Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: I39967a69121b0a92d9ab7c18d70b0350f87db030

Android.mk

diff --git a/Android.mk b/Android.mk
index f52a691..69d8a19 100644
--- a/Android.mk
+++ b/Android.mk
@@ -23,12 +23,19 @@
 LOCAL_PATH := $(call my-dir)
 
 # Custom C/C++ compilation flags:
-MY_LIBTEXTCLASSIFIER_CFLAGS := \
-    -Wno-unused-parameter \
-    -Wno-sign-compare \
-    -Wno-missing-field-initializers \
+MY_LIBTEXTCLASSIFIER_WARNING_CFLAGS := \
+    -Wall \
+    -Werror \
     -Wno-ignored-qualifiers \
+    -Wno-missing-field-initializers \
+    -Wno-sign-compare \
+    -Wno-tautological-constant-out-of-range-compare \
     -Wno-undefined-var-template \
+    -Wno-unused-function \
+    -Wno-unused-parameter \
+
+MY_LIBTEXTCLASSIFIER_CFLAGS := \
+    $(MY_LIBTEXTCLASSIFIER_WARNING_CFLAGS) \
     -fvisibility=hidden
 
 # Only enable debug logging in userdebug/eng builds.
@@ -49,6 +56,8 @@
 LOCAL_SRC_FILES := $(call all-proto-files-under, .)
 LOCAL_SHARED_LIBRARIES := libprotobuf-cpp-lite
 
+LOCAL_CFLAGS := $(MY_LIBTEXTCLASSIFIER_WARNING_CFLAGS)
+
 include $(BUILD_STATIC_LIBRARY)
 
 # -----------------
@@ -261,4 +270,5 @@
 LOCAL_REQUIRED_MODULES += textclassifier.smartselection.es.model
 LOCAL_REQUIRED_MODULES += textclassifier.smartselection.de.model
 LOCAL_REQUIRED_MODULES += textclassifier.smartselection.fr.model
+LOCAL_CFLAGS := $(MY_LIBTEXTCLASSIFIER_WARNING_CFLAGS)
 include $(BUILD_STATIC_LIBRARY)