| commit | a4461d3f3cbf73ad0254f8441027a1b0cd444c15 | [log] [tgz] |
|---|---|---|
| author | George Burgess IV <gbiv@google.com> | Wed Apr 01 13:20:38 2020 -0700 |
| committer | Commit Bot <commit-bot@chromium.org> | Sat Apr 04 11:42:54 2020 +0000 |
| tree | 8233b7460ae095a04c678eb46ef3657ed11ca813 | |
| parent | fdbcea8835f71fece172df9602b3fd826a67fa37 [diff] |
libbrillo: remove an unreachable return We're trying to turn -Wunreachable-code-return on by default, and this unreachable `return` statement was flagged. Removing it makes this code clearer and easier to modify, since if a case is added to this `switch` later, the user should get a -Werror'ed warning if they forget to add a `return`. BUG=chromium:1066998 TEST=CQ Change-Id: If0be83daa6504854c377c825cf345c2c4d39837b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2132836 Reviewed-by: Eric Caruso <ejcaruso@chromium.org> Tested-by: George Burgess <gbiv@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Mirrored-From: https://chromium.googlesource.com/chromiumos/platform2 Cr-Mirrored-Commit: 6d0b86eeb049f098a1735fff8a06b62f9689a3c8
libbrillo is a shared library meant to hold common utility code that we deem useful for platform projects. It supplements the functionality provided by libbase/libchrome since that project, by design, only holds functionality that Chromium (the browser) needs. As a result, this tends to be more OS-centric code.
This project is also used by Update Engine which is maintained in AOSP. However, AOSP doesn't use this codebase directly, it maintains its own libbrillo fork.
To help keep the projects in sync, we have a gsubtree set up on our GoB: https://chromium.googlesource.com/chromiumos/platform2/libbrillo/
This allows AOSP to cherry pick or merge changes directly back into their fork.