commit f80afe5b98e6752ed89aef10b97863ad5db2401f
author Harish Mahendrakar <harish.mahendrakar@ittiam.com> Mon Dec 30 17:23:38 2019 -0800
committer Ray Essick <essick@google.com> Tue Feb 11 16:29:24 2020 -0800
tree 739685e4ed6ac15935b58fe2cea12b7dc6fbcd26
parent 8c2ee3ea8bf5b8d520bdcb5a1952e87ddaa881c4

decoder: Fix lt_ref increment in ih264d_fix_error_in_dpb

When removing common nodes from short term list if it present in long
term reference list, number of long term buffers was wrongly
incremented. Only decrement of short term buffer count is needed in
such a case.

Bug: 140561484
Bug: 140566606
Bug: 140699853
Bug: 144980954
Bug: 145859214

Test: poc in bug
Change-Id: Iebf7ee7ed65e7b2097a899577982806b03fc6e5d

decoder/ih264d_parse_slice.c

diff --git a/decoder/ih264d_parse_slice.c b/decoder/ih264d_parse_slice.c
index 8d50f9a..4401e8e 100644
--- a/decoder/ih264d_parse_slice.c
+++ b/decoder/ih264d_parse_slice.c
@@ -1029,7 +1029,6 @@
                         ps_st_next_dpb->ps_prev_short = ps_st_curr_dpb->ps_prev_short;
                     }
                     ps_dec->ps_dpb_mgr->u1_num_st_ref_bufs--;
-                    ps_dec->ps_dpb_mgr->u1_num_lt_ref_bufs++;
                     no_of_nodes_deleted++;
                     break;
                 }