don't use __clang_analyzer__ to avoid some static analysis.

generates diagnostics, as set up by upstream code source.
Remove the #ifndef, so that we'll compile things, even though we may
now generate some static analysis diagnostics.

Bug: 128456533
Test: build & boot
Change-Id: Ic5c21aef330aae413283c5f6321c2967548d4010
diff --git a/libaom/av1/common/resize.c b/libaom/av1/common/resize.c
index 8b24ed0..d668eae 100644
--- a/libaom/av1/common/resize.c
+++ b/libaom/av1/common/resize.c
@@ -431,7 +431,6 @@
   return (int32_t)((uint32_t)x0 & RS_SCALE_SUBPEL_MASK);
 }
 
-#ifndef __clang_analyzer__
 static void down2_symeven(const uint8_t *const input, int length,
                           uint8_t *output) {
   // Actual filter len = 2 * filter_len_half.
@@ -486,7 +485,6 @@
     }
   }
 }
-#endif
 
 static void down2_symodd(const uint8_t *const input, int length,
                          uint8_t *output) {
@@ -852,7 +850,6 @@
                           &interp_filters[0][0], SUBPEL_TAPS);
 }
 
-#ifndef __clang_analyzer__
 static void highbd_down2_symeven(const uint16_t *const input, int length,
                                  uint16_t *output, int bd) {
   // Actual filter len = 2 * filter_len_half.
@@ -960,7 +957,6 @@
     }
   }
 }
-#endif
 
 static void highbd_resize_multistep(const uint16_t *const input, int length,
                                     uint16_t *output, int olength,