Fix compiler warnings reported in Eclipse (#514)
diff --git a/org.jacoco.core.test/src/org/jacoco/core/internal/analysis/ClassAnalyzerTest.java b/org.jacoco.core.test/src/org/jacoco/core/internal/analysis/ClassAnalyzerTest.java
index c71e52f..c990d53 100644
--- a/org.jacoco.core.test/src/org/jacoco/core/internal/analysis/ClassAnalyzerTest.java
+++ b/org.jacoco.core.test/src/org/jacoco/core/internal/analysis/ClassAnalyzerTest.java
@@ -12,8 +12,6 @@
package org.jacoco.core.internal.analysis;
import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNull;
-import static org.junit.Assert.assertTrue;
import org.jacoco.core.internal.flow.MethodProbesVisitor;
import org.jacoco.core.internal.instr.InstrSupport;
diff --git a/org.jacoco.core.test/src/org/jacoco/core/internal/analysis/filter/LombokGeneratedFilterTest.java b/org.jacoco.core.test/src/org/jacoco/core/internal/analysis/filter/LombokGeneratedFilterTest.java
index 58f93fb..8fae5cc 100644
--- a/org.jacoco.core.test/src/org/jacoco/core/internal/analysis/filter/LombokGeneratedFilterTest.java
+++ b/org.jacoco.core.test/src/org/jacoco/core/internal/analysis/filter/LombokGeneratedFilterTest.java
@@ -14,13 +14,10 @@
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNull;
-import java.util.Arrays;
-
import org.jacoco.core.internal.instr.InstrSupport;
import org.junit.Test;
import org.objectweb.asm.Opcodes;
import org.objectweb.asm.tree.AbstractInsnNode;
-import org.objectweb.asm.tree.AnnotationNode;
import org.objectweb.asm.tree.MethodNode;
public class LombokGeneratedFilterTest implements IFilterOutput {
diff --git a/org.jacoco.core.test/src/org/jacoco/core/internal/instr/ProbeArrayStrategyFactoryTest.java b/org.jacoco.core.test/src/org/jacoco/core/internal/instr/ProbeArrayStrategyFactoryTest.java
index efebda0..3341520 100644
--- a/org.jacoco.core.test/src/org/jacoco/core/internal/instr/ProbeArrayStrategyFactoryTest.java
+++ b/org.jacoco.core.test/src/org/jacoco/core/internal/instr/ProbeArrayStrategyFactoryTest.java
@@ -337,7 +337,8 @@
assertFalse(itf);
return;
}
- assertEquals(itf, isInterface);
+ assertEquals(Boolean.valueOf(itf),
+ Boolean.valueOf(isInterface));
assertEquals(Opcodes.INVOKESTATIC, opcode);
assertEquals("Foo", owner);
diff --git a/org.jacoco.core.test/src/org/jacoco/core/test/filter/targets/Synthetic.java b/org.jacoco.core.test/src/org/jacoco/core/test/filter/targets/Synthetic.java
index 4a9adfd..783495d 100644
--- a/org.jacoco.core.test/src/org/jacoco/core/test/filter/targets/Synthetic.java
+++ b/org.jacoco.core.test/src/org/jacoco/core/test/filter/targets/Synthetic.java
@@ -21,7 +21,8 @@
private Synthetic() {
}
- private static class Inner extends Synthetic { // $line-inner.classdef$
+ static class Inner extends Synthetic { // $line-inner.classdef$
+
Inner() {
}
diff --git a/org.jacoco.core.test/src/org/jacoco/core/test/validation/FramesTest.java b/org.jacoco.core.test/src/org/jacoco/core/test/validation/FramesTest.java
index 106b7a6..9bea83a 100644
--- a/org.jacoco.core.test/src/org/jacoco/core/test/validation/FramesTest.java
+++ b/org.jacoco.core.test/src/org/jacoco/core/test/validation/FramesTest.java
@@ -17,7 +17,6 @@
import java.io.PrintWriter;
import java.io.StringWriter;
-import org.jacoco.core.JaCoCo;
import org.jacoco.core.instr.Instrumenter;
import org.jacoco.core.internal.Java9Support;
import org.jacoco.core.internal.instr.InstrSupport;
@@ -109,8 +108,9 @@
private String dump(byte[] bytes) {
final StringWriter buffer = new StringWriter();
final PrintWriter writer = new PrintWriter(buffer);
- new ClassReader(bytes).accept(new MaxStackEliminator(
- new TraceClassVisitor(writer)), ClassReader.EXPAND_FRAMES);
+ new ClassReader(bytes).accept(
+ new MaxStackEliminator(new TraceClassVisitor(writer)),
+ ClassReader.EXPAND_FRAMES);
return buffer.toString();
}
