tests/kms_atomic.c

/*
 * Copyright © 2015 Intel Corporation
 * Copyright © 2014-2015 Collabora, Ltd.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
 * IN THE SOFTWARE.
 *
 * Authors:
 *    Micah Fedke <micah.fedke@collabora.co.uk>
 *    Daniel Stone <daniels@collabora.com>
 *    Pekka Paalanen <pekka.paalanen@collabora.co.uk>
 */

/**
 * TEST: kms atomic
 * Category: Display
 * Description: Test atomic modesetting API
 * Driver requirement: i915, xe
 * Functionality: kms_core, plane
 * Mega feature: General Display Features
 * Test category: functionality test
 */

#include <unistd.h>
#include <stdlib.h>
#include <stdio.h>
#include <stdint.h>
#include <string.h>
#include <errno.h>
#include <xf86drmMode.h>
#include <cairo.h>
#include "drm.h"
#include "ioctl_wrappers.h"
#include "drmtest.h"
#include "igt.h"
#include "igt_aux.h"
#include "sw_sync.h"

/**
 * SUBTEST: atomic-invalid-params
 * Description: Test abuse the atomic ioctl directly in order to test various
 *              invalid conditions which the libdrm wrapper won't allow us to
 *              create.
 * Functionality: kms_core
 *
 * SUBTEST: atomic-plane-damage
 * Description: Simple test cases to use FB_DAMAGE_CLIPS plane property
 *
 * SUBTEST: test-only
 * Description: Test to ensure that DRM_MODE_ATOMIC_TEST_ONLY really only touches
 *              the free-standing state objects and nothing else.
 * Functionality: kms_core
 *
 * SUBTEST: plane-primary-overlay-mutable-zpos
 * Description: Verify that the overlay plane can cover the primary one (and
 *              vice versa) by changing their zpos property.
 *
 * SUBTEST: plane-immutable-zpos
 * Description: Verify the reported zpos property of planes by making sure only
 *              higher zpos planes cover the lower zpos ones.
 *
 * SUBTEST: plane-%s-legacy
 * Description: Test for KMS atomic modesetting on %arg[1] and ensure coherency
 *              between legacy and atomic interfaces.
 *
 * arg[1]:
 *
 * @cursor:         Cursor plane
 * @overlay:        Overlay plane
 * @primary:        Primary plane
 */

/**
 * SUBTEST: %s-invalid-%s
 * Description: Test error handling when invalid %arg[1] %arg[2] are passed
 *
 * arg[1]:
 *
 * @crtc:             CRTC
 * @plane:            Plane
 *
 * arg[2]:
 *
 * @params:           parameters
 * @params-fence:     fence parameters
 */

#ifndef DRM_CAP_CURSOR_WIDTH
#define DRM_CAP_CURSOR_WIDTH 0x8
#endif

#ifndef DRM_CAP_CURSOR_HEIGHT
#define DRM_CAP_CURSOR_HEIGHT 0x9
#endif

IGT_TEST_DESCRIPTION("Test atomic modesetting API");

static bool all_pipes = false;

/* Common test data. */
typedef struct {
	igt_display_t display;
	igt_plane_t *primary;
	igt_pipe_t *pipe;
	int drm_fd;
	igt_fb_t fb;
} data_t;

enum kms_atomic_check_relax {
	ATOMIC_RELAX_NONE = 0,
	CRTC_RELAX_MODE = (1 << 0),
	PLANE_RELAX_FB = (1 << 1)
};

static inline int damage_rect_width(struct drm_mode_rect *r)
{
	return r->x2 - r->x1;
}

static inline int damage_rect_height(struct drm_mode_rect *r)
{
	return r->y2 - r->y1;
}

static bool plane_filter(enum igt_atomic_plane_properties prop)
{
	if ((1 << prop) & IGT_PLANE_COORD_CHANGED_MASK)
		return false;

	if (prop == IGT_PLANE_CRTC_ID || prop == IGT_PLANE_FB_ID)
		return false;

	if (prop == IGT_PLANE_IN_FENCE_FD)
		return false;

	/* Don't care about other properties */
	return true;
}

static void plane_get_current_state(igt_plane_t *plane, uint64_t *values)
{
	int i;

	for (i = 0; i < IGT_NUM_PLANE_PROPS; i++) {
		if (plane_filter(i)) {
			values[i] = 0;
			continue;
		}

		values[i] = igt_plane_get_prop(plane, i);
	}
}

static void plane_check_current_state(igt_plane_t *plane, const uint64_t *values,
				      enum kms_atomic_check_relax relax)
{
	drmModePlanePtr legacy;
	uint64_t current_values[IGT_NUM_PLANE_PROPS];
	int i;

	legacy = drmModeGetPlane(plane->pipe->display->drm_fd, plane->drm_plane->plane_id);
	igt_assert(legacy);

	igt_assert_eq_u32(legacy->crtc_id, values[IGT_PLANE_CRTC_ID]);

	if (!(relax & PLANE_RELAX_FB))
		igt_assert_eq_u32(legacy->fb_id, values[IGT_PLANE_FB_ID]);

	plane_get_current_state(plane, current_values);

	/*
	 * Legacy cursor ioctls create their own, unknowable, internal
	 * framebuffer which we can't reason about.
	 */
	if (relax & PLANE_RELAX_FB)
		current_values[IGT_PLANE_FB_ID] = values[IGT_PLANE_FB_ID];

	for (i = 0; i < IGT_NUM_PLANE_PROPS; i++)
		if (!plane_filter(i))
			igt_assert_eq_u64(current_values[i], values[i]);

	drmModeFreePlane(legacy);
}

static void plane_commit(igt_plane_t *plane, enum igt_commit_style s,
			 enum kms_atomic_check_relax relax)
{
	igt_display_commit2(plane->pipe->display, s);
	plane_check_current_state(plane, plane->values, relax);
}

static void plane_commit_atomic_err(igt_plane_t *plane,
				    enum kms_atomic_check_relax relax,
				    int err)
{
	uint64_t current_values[IGT_NUM_PLANE_PROPS];

	plane_get_current_state(plane, current_values);

	igt_assert_eq(-err, igt_display_try_commit2(plane->pipe->display, COMMIT_ATOMIC));

	plane_check_current_state(plane, current_values, relax);
}

static bool crtc_filter(enum igt_atomic_crtc_properties prop)
{
	if (prop == IGT_CRTC_MODE_ID || prop == IGT_CRTC_ACTIVE)
		return false;

	return true;
}

static void crtc_get_current_state(igt_pipe_t *pipe, uint64_t *values)
{
	int i;

	for (i = 0; i < IGT_NUM_CRTC_PROPS; i++) {
		if (crtc_filter(i)) {
			values[i] = 0;
			continue;
		}

		values[i] = igt_pipe_obj_get_prop(pipe, i);
	}
}

static void crtc_check_current_state(igt_pipe_t *pipe,
				     const uint64_t *pipe_values,
				     const uint64_t *primary_values,
				     enum kms_atomic_check_relax relax)
{
	uint64_t current_pipe_values[IGT_NUM_CRTC_PROPS];
	drmModeCrtcPtr legacy;
	drmModePropertyBlobRes *mode_prop = NULL;
	struct drm_mode_modeinfo *mode = NULL;

	if (pipe_values[IGT_CRTC_MODE_ID]) {
		mode_prop = drmModeGetPropertyBlob(pipe->display->drm_fd,
						   pipe_values[IGT_CRTC_MODE_ID]);
		igt_assert(mode_prop);

		igt_assert_eq(mode_prop->length,
		              sizeof(struct drm_mode_modeinfo));
		mode = mode_prop->data;
	}

	legacy = drmModeGetCrtc(pipe->display->drm_fd, pipe->crtc_id);
	igt_assert(legacy);

	igt_assert_eq_u32(legacy->crtc_id, pipe->crtc_id);
	igt_assert_eq_u32(legacy->x, primary_values[IGT_PLANE_SRC_X] >> 16);
	igt_assert_eq_u32(legacy->y, primary_values[IGT_PLANE_SRC_Y] >> 16);

	igt_assert_eq_u32(legacy->buffer_id, primary_values[IGT_PLANE_FB_ID]);

	if (legacy->mode_valid) {
		igt_assert(mode_prop);

		do_or_die(memcmp(&legacy->mode, mode, sizeof(*mode)));

		igt_assert_eq(legacy->width, legacy->mode.hdisplay);
		igt_assert_eq(legacy->height, legacy->mode.vdisplay);

		igt_assert_neq(pipe_values[IGT_CRTC_MODE_ID], 0);
	} else {
		igt_assert(!mode_prop);
	}

	crtc_get_current_state(pipe, current_pipe_values);

	/*
	 * Optionally relax the check for MODE_ID: using the legacy SetCrtc
	 * API can potentially change MODE_ID even if the mode itself remains
	 * unchanged.
	 */
	if (relax & CRTC_RELAX_MODE && mode && current_pipe_values[IGT_CRTC_MODE_ID] &&
	    current_pipe_values[IGT_CRTC_MODE_ID] != pipe_values[IGT_CRTC_MODE_ID]) {
		drmModePropertyBlobRes *cur_prop =
			drmModeGetPropertyBlob(pipe->display->drm_fd,
					       current_pipe_values[IGT_CRTC_MODE_ID]);

		igt_assert(cur_prop);
		igt_assert_eq(cur_prop->length, sizeof(struct drm_mode_modeinfo));

		if (!memcmp(cur_prop->data, mode, sizeof(*mode)))
			current_pipe_values[IGT_CRTC_MODE_ID] = pipe_values[IGT_CRTC_MODE_ID];

		drmModeFreePropertyBlob(cur_prop);
	}

	do_or_die(memcmp(pipe_values, current_pipe_values, sizeof(current_pipe_values)));

	drmModeFreeCrtc(legacy);
	drmModeFreePropertyBlob(mode_prop);
}

static void crtc_commit(igt_pipe_t *pipe, igt_plane_t *plane,
			enum igt_commit_style s,
			enum kms_atomic_check_relax relax)
{
	igt_display_commit2(pipe->display, s);

	crtc_check_current_state(pipe, pipe->values, plane->values, relax);
	plane_check_current_state(plane, plane->values, relax);
}

static void crtc_commit_atomic_flags_err(igt_pipe_t *pipe, igt_plane_t *plane,
					 unsigned flags,
					 enum kms_atomic_check_relax relax,
					 int err)
{
	uint64_t current_pipe_values[IGT_NUM_CRTC_PROPS];
	uint64_t current_plane_values[IGT_NUM_PLANE_PROPS];

	crtc_get_current_state(pipe, current_pipe_values);
	plane_get_current_state(plane, current_plane_values);

	igt_assert_eq(-err, igt_display_try_commit_atomic(pipe->display, flags, NULL));

	crtc_check_current_state(pipe, current_pipe_values, current_plane_values, relax);
	plane_check_current_state(plane, current_plane_values, relax);
}

#define crtc_commit_atomic_err(pipe, plane, relax, err) \
	crtc_commit_atomic_flags_err(pipe, plane, DRM_MODE_ATOMIC_ALLOW_MODESET, relax, err)

static uint32_t plane_get_igt_format(igt_plane_t *plane)
{
	drmModePlanePtr plane_kms;
	int i;

	plane_kms = plane->drm_plane;

	for (i = 0; i < plane_kms->count_formats; i++) {
		if (igt_fb_supported_format(plane_kms->formats[i]))
			return plane_kms->formats[i];
	}

	return 0;
}

static void
plane_primary_overlay_mutable_zpos(data_t *data, igt_output_t *output, igt_plane_t *overlay,
				   uint32_t format_primary, uint32_t format_overlay)
{
	struct igt_fb fb_primary, fb_overlay;
	drmModeModeInfo *mode = igt_output_get_mode(output);
	cairo_t *cr;

	/* for primary */
	uint32_t w = mode->hdisplay;
	uint32_t h = mode->vdisplay;

	/* for overlay */
	uint32_t w_overlay = mode->hdisplay / 2;
	uint32_t h_overlay = mode->vdisplay / 2;

	igt_create_color_pattern_fb(data->drm_fd,
				    w, h, format_primary, DRM_FORMAT_MOD_LINEAR,
				    0.2, 0.2, 0.2, &fb_primary);

	igt_create_color_pattern_fb(data->drm_fd,
				    w_overlay, h_overlay,
				    format_overlay, DRM_FORMAT_MOD_LINEAR,
				    0.2, 0.2, 0.2, &fb_overlay);

	/* Draw a hole in the overlay */
	cr = igt_get_cairo_ctx(data->drm_fd, &fb_overlay);
	cairo_set_operator(cr, CAIRO_OPERATOR_SOURCE);
	igt_paint_color_alpha(cr, w_overlay / 4, h_overlay / 4,
			      w_overlay / 2, h_overlay / 2,
			      0.0, 0.0, 0.0, 0.0);
	cairo_set_operator(cr, CAIRO_OPERATOR_OVER);
	igt_put_cairo_ctx(cr);

	igt_plane_set_fb(data->primary, &fb_primary);
	igt_plane_set_fb(overlay, &fb_overlay);

	igt_plane_set_position(overlay, w_overlay / 2, h_overlay / 2);

	igt_plane_set_prop_value(data->primary, IGT_PLANE_ZPOS, 0);
	igt_plane_set_prop_value(overlay, IGT_PLANE_ZPOS, 1);

	igt_info("Committing with overlay on top, it has a hole "\
		 "through which the primary should be seen\n");
	plane_commit(data->primary, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);

	igt_assert_eq_u64(igt_plane_get_prop(data->primary, IGT_PLANE_ZPOS), 0);
	igt_assert_eq_u64(igt_plane_get_prop(overlay, IGT_PLANE_ZPOS), 1);

	igt_plane_set_prop_value(data->primary, IGT_PLANE_ZPOS, 1);
	igt_plane_set_prop_value(overlay, IGT_PLANE_ZPOS, 0);

	igt_info("Committing with primary on top, only the primary "\
		 "should be visible\n");
	plane_commit(data->primary, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);

	igt_assert_eq_u64(igt_plane_get_prop(data->primary, IGT_PLANE_ZPOS), 1);
	igt_assert_eq_u64(igt_plane_get_prop(overlay, IGT_PLANE_ZPOS), 0);

	/* Draw a hole in the primary exactly on top of the overlay plane */
	cr = igt_get_cairo_ctx(data->drm_fd, &fb_primary);
	cairo_set_operator(cr, CAIRO_OPERATOR_SOURCE);
	igt_paint_color_alpha(cr, w_overlay / 2, h_overlay / 2,
			      w_overlay, h_overlay,
			      0.0, 0.0, 0.0, 0.5);
	cairo_set_operator(cr, CAIRO_OPERATOR_OVER);
	igt_put_cairo_ctx(cr);

	igt_info("Committing with a hole in the primary through "\
		 "which the underlay should be seen\n");
	plane_commit(data->primary, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);

	/* reset it back to initial state */
	igt_plane_set_prop_value(data->primary, IGT_PLANE_ZPOS, 0);
	igt_plane_set_prop_value(overlay, IGT_PLANE_ZPOS, 1);
	plane_commit(data->primary, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);

	igt_assert_eq_u64(igt_plane_get_prop(data->primary, IGT_PLANE_ZPOS), 0);
	igt_assert_eq_u64(igt_plane_get_prop(overlay, IGT_PLANE_ZPOS), 1);
}

static void
plane_immutable_zpos(data_t *data, igt_output_t *output, enum pipe pipe, int n_planes)
{
	cairo_t *cr;
	struct igt_fb fb_ref;
	drmModeModeInfo *mode;
	igt_pipe_crc_t *pipe_crc;
	igt_crc_t ref_crc, new_crc;
	int fb_id_lower, fb_id_upper;
	igt_plane_t *plane_ptr[n_planes];
	struct igt_fb fb_lower, fb_upper;
	uint32_t w_lower, h_lower, w_upper, h_upper;

	memset(plane_ptr, 0, n_planes * sizeof(igt_plane_t *));
	igt_require_pipe_crc(data->drm_fd);

	mode = igt_output_get_mode(output);

	/* for lower plane */
	w_lower = mode->hdisplay;
	h_lower = mode->vdisplay;

	/* for upper plane */
	w_upper = 64;
	h_upper = 64;

	igt_create_color_fb(data->drm_fd,
			    w_lower, h_lower,
			    DRM_FORMAT_XRGB8888,
			    DRM_FORMAT_MOD_LINEAR,
			    0.0, 0.0, 0.0, &fb_ref);

	/* create reference image */
	cr = igt_get_cairo_ctx(data->drm_fd, &fb_ref);
	igt_assert(cairo_status(cr) == 0);
	igt_paint_color(cr, 0, 0, w_lower, h_lower, 0.0, 0.0, 1.0);
	igt_paint_color(cr, w_upper / 2, h_upper / 2, w_upper, h_upper, 1.0, 1.0, 0.0);
	igt_put_cairo_ctx(cr);
	igt_plane_set_fb(data->primary, &fb_ref);
	igt_display_commit2(&data->display, COMMIT_ATOMIC);

	/* create the pipe_crc object for this pipe */
	pipe_crc = igt_pipe_crc_new(data->drm_fd, pipe,
				    IGT_PIPE_CRC_SOURCE_AUTO);

	/* get reference crc */
	igt_pipe_crc_start(pipe_crc);
	igt_pipe_crc_get_current(data->drm_fd, pipe_crc, &ref_crc);

	igt_plane_set_fb(data->primary, NULL);

	for (int k = 0; k < n_planes; k++) {
		int zpos;
		igt_plane_t *temp;

		temp = &data->display.pipes[pipe].planes[k];

		if (!igt_plane_has_prop(temp, IGT_PLANE_ZPOS))
			continue;

		zpos = igt_plane_get_prop(temp, IGT_PLANE_ZPOS);

		plane_ptr[zpos] = temp;
	}

	fb_id_lower = igt_create_color_fb(data->drm_fd,
					  w_lower, h_lower,
					  DRM_FORMAT_XRGB8888,
					  DRM_FORMAT_MOD_LINEAR,
					  0.0, 0.0, 1.0, &fb_lower);
	igt_assert(fb_id_lower);

	fb_id_upper = igt_create_color_fb(data->drm_fd,
					  w_upper, h_upper,
					  DRM_FORMAT_XRGB8888,
					  DRM_FORMAT_MOD_LINEAR,
					  1.0, 1.0, 0.0, &fb_upper);
	igt_assert(fb_id_upper);

	/*
	 * Checking only pairs of plane in increasing fashion
	 * to avoid combinatorial explosion.
	 */
	for (int i = 0; i < n_planes - 1; i++) {
		igt_plane_t *plane_lower, *plane_upper;

		if (plane_ptr[i] == NULL)
			continue;

		plane_lower = plane_ptr[i];
		plane_upper = NULL;
		while (i  < (n_planes - 1)) {
			if (plane_ptr[i + 1] != NULL) {
				plane_upper = plane_ptr[i + 1];
				break;
			} else {
				i++;
				continue;
			}
		}
		if (!plane_upper)
			continue;

		if ((plane_upper->type == DRM_PLANE_TYPE_CURSOR) ||
		    (plane_lower->type == DRM_PLANE_TYPE_CURSOR))
				continue;

		igt_plane_set_position(plane_lower, 0, 0);
		igt_plane_set_fb(plane_lower, &fb_lower);

		igt_plane_set_position(plane_upper, w_upper / 2, h_upper / 2);
		igt_plane_set_fb(plane_upper, &fb_upper);

		igt_info("Committing with the plane[%d] underneath "\
			 "plane[%d]\n", i, (i + 1));
		igt_display_commit2(&data->display, COMMIT_ATOMIC);
		igt_pipe_crc_get_current(data->drm_fd, pipe_crc, &new_crc);

		igt_assert_crc_equal(&ref_crc, &new_crc);

		igt_plane_set_fb(plane_lower, NULL);
		igt_plane_set_fb(plane_upper, NULL);
	}

	igt_remove_fb(data->drm_fd, &fb_ref);
	igt_remove_fb(data->drm_fd, &fb_lower);
	igt_remove_fb(data->drm_fd, &fb_upper);
}

static void plane_overlay(data_t *data, igt_output_t *output, igt_plane_t *plane,
			  uint32_t format)
{
	struct igt_fb fb;
	drmModeModeInfo *mode = igt_output_get_mode(output);
	uint32_t w = mode->hdisplay / 2;
	uint32_t h = mode->vdisplay / 2;

	igt_create_pattern_fb(data->drm_fd, w, h,
			      format, DRM_FORMAT_MOD_LINEAR, &fb);

	igt_plane_set_fb(plane, &fb);
	igt_plane_set_position(plane, w/2, h/2);

	/*
	 * Enable the overlay plane using the atomic API, and double-check
	 * state is what we think it should be.
	 */
	plane_commit(plane, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);

	/* Disable the plane and check the state matches the old. */
	igt_plane_set_fb(plane, NULL);
	igt_plane_set_position(plane, 0, 0);
	plane_commit(plane, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);

	/*
	 * Re-enable the plane through the legacy plane API, and verify through
	 * atomic.
	 */
	igt_plane_set_fb(plane, &fb);
	igt_plane_set_position(plane, w/2, h/2);
	plane_commit(plane, COMMIT_LEGACY, ATOMIC_RELAX_NONE);

	/*
	 * Restore the plane to its original settings through the legacy plane
	 * API, and verify through atomic.
	 */
	igt_plane_set_fb(plane, NULL);
	igt_plane_set_position(plane, 0, 0);
	plane_commit(plane, COMMIT_LEGACY, ATOMIC_RELAX_NONE);

	igt_remove_fb(data->drm_fd, &fb);
}

static void plane_primary(data_t *data)
{
	struct igt_fb fb2;

	igt_create_color_pattern_fb(data->drm_fd,
				    data->fb.width, data->fb.height,
				    data->fb.drm_format, I915_TILING_NONE,
				    0.2, 0.2, 0.2, &fb2);

	/*
	 * Flip the primary plane using the atomic API, and double-check
	 * state is what we think it should be.
	 */
	igt_plane_set_fb(data->primary, &fb2);
	crtc_commit(data->pipe, data->primary, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);

	/* Restore the primary plane and check the state matches the old. */
	igt_plane_set_fb(data->primary, &data->fb);
	crtc_commit(data->pipe, data->primary, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);

	/*
	 * Set the plane through the legacy CRTC/primary-plane API, and
	 * verify through atomic.
	 */
	igt_plane_set_fb(data->primary, &data->fb);
	crtc_commit(data->pipe, data->primary, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);

	/*
	 * Restore the plane to its original settings through the legacy CRTC
	 * API, and verify through atomic.
	 */
	igt_plane_set_fb(data->primary, &data->fb);
	crtc_commit(data->pipe, data->primary, COMMIT_LEGACY, CRTC_RELAX_MODE);

	/*
	 * Set the plane through the universal setplane API, and
	 * verify through atomic.
	 */
	igt_plane_set_fb(data->primary, &fb2);
	plane_commit(data->primary, COMMIT_UNIVERSAL, ATOMIC_RELAX_NONE);
}

/*
 * Test to ensure that DRM_MODE_ATOMIC_TEST_ONLY really only touches the
 * free-standing state objects and nothing else.
 */
static void test_only(data_t *data, igt_output_t *output, enum pipe pipe, uint32_t format)
{
	struct igt_fb fb;
	uint64_t old_plane_values[IGT_NUM_PLANE_PROPS], old_crtc_values[IGT_NUM_CRTC_PROPS];
	drmModeModeInfo *mode = igt_output_get_mode(output);

	plane_get_current_state(data->primary, old_plane_values);
	crtc_get_current_state(data->pipe, old_crtc_values);

	igt_assert(!old_crtc_values[IGT_CRTC_MODE_ID]);

	igt_create_pattern_fb(data->drm_fd,
			      mode->hdisplay, mode->vdisplay,
			      format, I915_TILING_NONE, &fb);
	igt_plane_set_fb(data->primary, &fb);
	igt_output_set_pipe(output, pipe);

	igt_display_commit_atomic(&data->display, DRM_MODE_ATOMIC_TEST_ONLY | DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);

	/* check the state, should still be old state */
	crtc_check_current_state(data->pipe, old_crtc_values, old_plane_values, ATOMIC_RELAX_NONE);
	plane_check_current_state(data->primary, old_plane_values, ATOMIC_RELAX_NONE);

	/*
	 * Enable the plane through the legacy CRTC/primary-plane API, and
	 * verify through atomic.
	 */
	crtc_commit(data->pipe, data->primary, COMMIT_LEGACY, CRTC_RELAX_MODE);

	/* Same for disable.. */
	plane_get_current_state(data->primary, old_plane_values);
	crtc_get_current_state(data->pipe, old_crtc_values);

	igt_plane_set_fb(data->primary, NULL);
	igt_output_set_pipe(output, PIPE_NONE);

	igt_display_commit_atomic(&data->display, DRM_MODE_ATOMIC_TEST_ONLY | DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);

	/* for extra stress, go through dpms off/on cycle */
	kmstest_set_connector_dpms(output->display->drm_fd, output->config.connector, DRM_MODE_DPMS_OFF);
	kmstest_set_connector_dpms(output->display->drm_fd, output->config.connector, DRM_MODE_DPMS_ON);

	/* check the state, should still be old state */
	crtc_check_current_state(data->pipe, old_crtc_values, old_plane_values, ATOMIC_RELAX_NONE);
	plane_check_current_state(data->primary, old_plane_values, ATOMIC_RELAX_NONE);

	/* And disable the pipe and remove fb, test complete */
	crtc_commit(data->pipe, data->primary, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);
	igt_remove_fb(data->drm_fd, &fb);
}

static void plane_cursor(data_t *data, igt_output_t *output, igt_plane_t *cursor)
{
	drmModeModeInfo *mode = igt_output_get_mode(output);
	struct igt_fb fb;
	uint64_t width, height;
	int x = mode->hdisplay / 2;
	int y = mode->vdisplay / 2;

	/* Any kernel new enough for atomic, also has the cursor size caps. */
	do_or_die(drmGetCap(data->drm_fd,
	                    DRM_CAP_CURSOR_WIDTH, &width));
	do_or_die(drmGetCap(data->drm_fd,
	                    DRM_CAP_CURSOR_HEIGHT, &height));

	igt_create_color_fb(data->drm_fd,
			    width, height, DRM_FORMAT_ARGB8888,
			    DRM_FORMAT_MOD_LINEAR,
			    0.0, 0.0, 0.0, &fb);

	/*
	 * Flip the cursor plane using the atomic API, and double-check
	 * state is what we think it should be.
	 */
	igt_plane_set_fb(cursor, &fb);
	igt_plane_set_position(cursor, x, y);
	plane_commit(cursor, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);

	/* Restore the cursor plane and check the state matches the old. */
	igt_plane_set_fb(cursor, NULL);
	igt_plane_set_position(cursor, 0, 0);
	plane_commit(cursor, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);

	/*
	 * Re-enable the plane through the legacy cursor API, and verify
	 * through atomic.
	 */
	igt_plane_set_fb(cursor, &fb);
	igt_plane_set_position(cursor, x, y);
	plane_commit(cursor, COMMIT_LEGACY, PLANE_RELAX_FB);

	/* Wiggle. */
	igt_plane_set_position(cursor, x - 16, y - 16);
	plane_commit(cursor, COMMIT_LEGACY, PLANE_RELAX_FB);

	/*
	 * Restore the plane to its original settings through the legacy cursor
	 * API, and verify through atomic.
	 */
	igt_plane_set_fb(cursor, NULL);
	igt_plane_set_position(cursor, 0, 0);
	plane_commit(cursor, COMMIT_LEGACY, ATOMIC_RELAX_NONE);
}

static void plane_invalid_params(data_t *data, igt_output_t *output)
{
	struct igt_fb fb2;

	/* Pass a series of invalid object IDs for the FB ID. */
	igt_plane_set_prop_value(data->primary, IGT_PLANE_FB_ID, data->primary->drm_plane->plane_id);
	plane_commit_atomic_err(data->primary, ATOMIC_RELAX_NONE, EINVAL);

	igt_plane_set_prop_value(data->primary, IGT_PLANE_FB_ID, data->pipe->crtc_id);
	plane_commit_atomic_err(data->primary, ATOMIC_RELAX_NONE, EINVAL);

	igt_plane_set_prop_value(data->primary, IGT_PLANE_FB_ID, output->id);
	plane_commit_atomic_err(data->primary, ATOMIC_RELAX_NONE, EINVAL);

	igt_plane_set_prop_value(data->primary, IGT_PLANE_FB_ID, data->pipe->values[IGT_CRTC_MODE_ID]);
	plane_commit_atomic_err(data->primary, ATOMIC_RELAX_NONE, EINVAL);

	/* Valid, but invalid because CRTC_ID is set. */
	igt_plane_set_prop_value(data->primary, IGT_PLANE_FB_ID, 0);
	plane_commit_atomic_err(data->primary, ATOMIC_RELAX_NONE, EINVAL);

	igt_plane_set_fb(data->primary, &data->fb);
	plane_commit(data->primary, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);

	/* Pass a series of invalid object IDs for the CRTC ID. */
	igt_plane_set_prop_value(data->primary, IGT_PLANE_CRTC_ID, data->primary->drm_plane->plane_id);
	plane_commit_atomic_err(data->primary, ATOMIC_RELAX_NONE, EINVAL);

	igt_plane_set_prop_value(data->primary, IGT_PLANE_CRTC_ID, data->fb.fb_id);
	plane_commit_atomic_err(data->primary, ATOMIC_RELAX_NONE, EINVAL);

	igt_plane_set_prop_value(data->primary, IGT_PLANE_CRTC_ID, output->id);
	plane_commit_atomic_err(data->primary, ATOMIC_RELAX_NONE, EINVAL);

	igt_plane_set_prop_value(data->primary, IGT_PLANE_CRTC_ID, data->pipe->values[IGT_CRTC_MODE_ID]);
	plane_commit_atomic_err(data->primary, ATOMIC_RELAX_NONE, EINVAL);

	/* Valid, but invalid because FB_ID is set. */
	igt_plane_set_prop_value(data->primary, IGT_PLANE_CRTC_ID, 0);
	plane_commit_atomic_err(data->primary, ATOMIC_RELAX_NONE, EINVAL);

	igt_plane_set_fb(data->primary, &data->fb);
	plane_commit(data->primary, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);

	/* Create a framebuffer too small for the plane configuration. */
	igt_create_pattern_fb(data->drm_fd,
			      data->fb.width - 1, data->fb.height - 1,
			      data->fb.drm_format, I915_TILING_NONE, &fb2);

	igt_plane_set_prop_value(data->primary, IGT_PLANE_FB_ID, fb2.fb_id);
	plane_commit_atomic_err(data->primary, ATOMIC_RELAX_NONE, ENOSPC);

	/* Restore the primary plane and check the state matches the old. */
	igt_plane_set_fb(data->primary, &data->fb);
	plane_commit(data->primary, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);
}

static void plane_invalid_params_fence(data_t *data, igt_output_t *output)
{
	int timeline, fence_fd;

	igt_require_sw_sync();

	timeline = sw_sync_timeline_create();

	/* invalid fence fd */
	igt_plane_set_fence_fd(data->primary, data->drm_fd);
	plane_commit_atomic_err(data->primary, ATOMIC_RELAX_NONE, EINVAL);

	/* Valid fence_fd but invalid CRTC */
	fence_fd = sw_sync_timeline_create_fence(timeline, 1);

	igt_plane_set_prop_value(data->primary, IGT_PLANE_CRTC_ID, ~0);
	igt_plane_set_fence_fd(data->primary, fence_fd);
	plane_commit_atomic_err(data->primary, ATOMIC_RELAX_NONE, EINVAL);

	sw_sync_timeline_inc(timeline, 1);
	igt_plane_set_prop_value(data->primary, IGT_PLANE_CRTC_ID, data->pipe->crtc_id);
	plane_commit(data->primary, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);

	close(fence_fd);
	close(timeline);
}

static void crtc_invalid_params(data_t *data, igt_output_t *output)
{
	uint64_t old_mode_id = data->pipe->values[IGT_CRTC_MODE_ID];
	drmModeModeInfo *mode = igt_output_get_mode(output);

	/* Pass a series of invalid object IDs for the mode ID. */
	igt_pipe_obj_set_prop_value(data->pipe, IGT_CRTC_MODE_ID, data->primary->drm_plane->plane_id);
	crtc_commit_atomic_err(data->pipe, data->primary, ATOMIC_RELAX_NONE, EINVAL);

	igt_pipe_obj_set_prop_value(data->pipe, IGT_CRTC_MODE_ID, data->pipe->crtc_id);
	crtc_commit_atomic_err(data->pipe, data->primary, ATOMIC_RELAX_NONE, EINVAL);

	igt_pipe_obj_set_prop_value(data->pipe, IGT_CRTC_MODE_ID, data->fb.fb_id);
	crtc_commit_atomic_err(data->pipe, data->primary, ATOMIC_RELAX_NONE, EINVAL);

	igt_pipe_obj_set_prop_value(data->pipe, IGT_CRTC_MODE_ID, old_mode_id);
	crtc_commit_atomic_flags_err(data->pipe, data->primary, DRM_MODE_ATOMIC_TEST_ONLY, ATOMIC_RELAX_NONE, 0);

	/* Can we restore mode? */
	igt_pipe_obj_set_prop_value(data->pipe, IGT_CRTC_MODE_ID, old_mode_id);
	crtc_commit_atomic_flags_err(data->pipe, data->primary, DRM_MODE_ATOMIC_TEST_ONLY, ATOMIC_RELAX_NONE, 0);

	/*
	 * TEST_ONLY cannot be combined with DRM_MODE_PAGE_FLIP_EVENT,
	 * but DRM_MODE_PAGE_FLIP_EVENT will always generate EINVAL
	 * without valid crtc, so test it here.
	 */
	crtc_commit_atomic_flags_err(data->pipe, data->primary,
				     DRM_MODE_ATOMIC_TEST_ONLY | DRM_MODE_PAGE_FLIP_EVENT,
				     ATOMIC_RELAX_NONE, EINVAL);

	/* Create a blob which is the wrong size to be a valid mode. */
	igt_pipe_obj_replace_prop_blob(data->pipe, IGT_CRTC_MODE_ID, mode, sizeof(*mode) - 1);
	crtc_commit_atomic_err(data->pipe, data->primary, ATOMIC_RELAX_NONE, EINVAL);

	igt_pipe_obj_replace_prop_blob(data->pipe, IGT_CRTC_MODE_ID, mode, sizeof(*mode) + 1);
	crtc_commit_atomic_err(data->pipe, data->primary, ATOMIC_RELAX_NONE, EINVAL);

	/* Restore the CRTC and check the state matches the old. */
	igt_pipe_obj_replace_prop_blob(data->pipe, IGT_CRTC_MODE_ID, mode, sizeof(*mode));
	crtc_commit(data->pipe, data->primary, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);
}

static void crtc_invalid_params_fence(data_t *data, igt_output_t *output)
{
	int timeline, fence_fd;
	void *map;
	const ptrdiff_t page_size = sysconf(_SC_PAGE_SIZE);
	uint64_t old_mode_id = data->pipe->values[IGT_CRTC_MODE_ID];

	igt_require_sw_sync();

	timeline = sw_sync_timeline_create();

	/* invalid out_fence_ptr */
	map = mmap(NULL, page_size, PROT_READ, MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
	igt_assert(map != MAP_FAILED);

	igt_pipe_obj_set_prop_value(data->pipe, IGT_CRTC_OUT_FENCE_PTR, (ptrdiff_t)map);
	crtc_commit_atomic_err(data->pipe, data->primary, ATOMIC_RELAX_NONE, EFAULT);
	munmap(map, page_size);

	/* invalid out_fence_ptr */
	map = mmap(NULL, page_size, PROT_EXEC, MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
	igt_assert(map != MAP_FAILED);

	igt_pipe_obj_set_prop_value(data->pipe, IGT_CRTC_OUT_FENCE_PTR, (ptrdiff_t)map);
	crtc_commit_atomic_err(data->pipe, data->primary, ATOMIC_RELAX_NONE, EFAULT);
	munmap(map, page_size);

	/* invalid out_fence_ptr */
	map = mmap(NULL, page_size, PROT_NONE, MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
	igt_assert(map != MAP_FAILED);

	igt_pipe_obj_set_prop_value(data->pipe, IGT_CRTC_OUT_FENCE_PTR, (ptrdiff_t)map);
	crtc_commit_atomic_err(data->pipe, data->primary, ATOMIC_RELAX_NONE, EFAULT);
	munmap(map, page_size);

	/* valid in fence but not allowed prop on crtc */
	fence_fd = sw_sync_timeline_create_fence(timeline, 1);
	igt_plane_set_fence_fd(data->primary, fence_fd);

	igt_pipe_obj_set_prop_value(data->pipe, IGT_CRTC_ACTIVE, 0);
	igt_pipe_obj_clear_prop_changed(data->pipe, IGT_CRTC_OUT_FENCE_PTR);

	crtc_commit_atomic_flags_err(data->pipe, data->primary, 0, ATOMIC_RELAX_NONE, EINVAL);

	/* valid out fence ptr and flip event but not allowed prop on crtc */
	igt_pipe_request_out_fence(data->pipe);
	crtc_commit_atomic_flags_err(data->pipe, data->primary, DRM_MODE_PAGE_FLIP_EVENT,
				     ATOMIC_RELAX_NONE, EINVAL);

	/* valid flip event but not allowed prop on crtc */
	igt_pipe_request_out_fence(data->pipe);
	crtc_commit_atomic_flags_err(data->pipe, data->primary, DRM_MODE_PAGE_FLIP_EVENT,
				     ATOMIC_RELAX_NONE, EINVAL);

	igt_pipe_obj_set_prop_value(data->pipe, IGT_CRTC_ACTIVE, 1);

	/* Configuration should be valid again */
	crtc_commit_atomic_flags_err(data->pipe, data->primary, DRM_MODE_ATOMIC_TEST_ONLY,
				     ATOMIC_RELAX_NONE, 0);

	/* Set invalid prop */
	igt_pipe_obj_set_prop_value(data->pipe, IGT_CRTC_MODE_ID, data->fb.fb_id);

	/* valid out fence but invalid prop on crtc */
	igt_pipe_request_out_fence(data->pipe);
	crtc_commit_atomic_flags_err(data->pipe, data->primary, 0,
				     ATOMIC_RELAX_NONE, EINVAL);

	/* valid out fence ptr and flip event but invalid prop on crtc */
	crtc_commit_atomic_flags_err(data->pipe, data->primary, DRM_MODE_PAGE_FLIP_EVENT,
				     ATOMIC_RELAX_NONE, EINVAL);

	/* valid page flip event but invalid prop on crtc */
	crtc_commit_atomic_flags_err(data->pipe, data->primary, DRM_MODE_PAGE_FLIP_EVENT,
				     ATOMIC_RELAX_NONE, EINVAL);

	/* successful TEST_ONLY with fences set */
	igt_pipe_obj_set_prop_value(data->pipe, IGT_CRTC_MODE_ID, old_mode_id);
	crtc_commit_atomic_flags_err(data->pipe, data->primary, DRM_MODE_ATOMIC_TEST_ONLY,
				     ATOMIC_RELAX_NONE, 0);
	igt_assert(data->pipe->out_fence_fd == -1);
	close(fence_fd);
	close(timeline);

	/* reset fences */
	igt_plane_set_fence_fd(data->primary, -1);
	igt_pipe_obj_set_prop_value(data->pipe, IGT_CRTC_OUT_FENCE_PTR, 0);
	igt_pipe_obj_clear_prop_changed(data->pipe, IGT_CRTC_OUT_FENCE_PTR);
	crtc_commit(data->pipe, data->primary, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);

	/* out fence ptr but not page flip event */
	igt_pipe_request_out_fence(data->pipe);
	crtc_commit(data->pipe, data->primary, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);

	igt_assert(data->pipe->out_fence_fd != -1);
}

/*
 * Abuse the atomic ioctl directly in order to test various invalid conditions,
 * which the libdrm wrapper won't allow us to create.
 */
static void atomic_invalid_params(data_t *data, igt_output_t *output)
{
	struct drm_mode_atomic ioc;
	uint32_t obj_raw[16]; /* array of objects (sized by count_objs) */
	uint32_t num_props_raw[16]; /* array of num props per obj (ditto) */
	uint32_t props_raw[256]; /* array of props (sum of count_props) */
	uint64_t values_raw[256]; /* array of values for properties (ditto) */
	int i;

	memset(&ioc, 0, sizeof(ioc));

	/* An empty request should do nothing. */
	do_ioctl(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc);

	for (i = 0; i < ARRAY_SIZE(obj_raw); i++)
		obj_raw[i] = 0;
	for (i = 0; i < ARRAY_SIZE(num_props_raw); i++)
		num_props_raw[i] = 0;
	for (i = 0; i < ARRAY_SIZE(props_raw); i++)
		props_raw[i] = 0;
	for (i = 0; i < ARRAY_SIZE(values_raw); i++)
		values_raw[i] = 0;

	ioc.objs_ptr = (uintptr_t) obj_raw;
	ioc.count_props_ptr = (uintptr_t) num_props_raw;
	ioc.props_ptr = (uintptr_t) props_raw;
	ioc.prop_values_ptr = (uintptr_t) values_raw;

	/* Valid pointers, but still should copy nothing. */
	do_ioctl(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc);

	/* Valid noop, but with event set should fail. */
	ioc.flags = DRM_MODE_PAGE_FLIP_EVENT;
	do_ioctl_err(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, EINVAL);

	/* Nonsense flags. */
	ioc.flags = 0xdeadbeef;
	do_ioctl_err(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, EINVAL);

	ioc.flags = 0;
	/* Safety check that flags is reset properly. */
	do_ioctl(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc);

	/* Reserved/MBZ. */
	ioc.reserved = 1;
	do_ioctl_err(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, EINVAL);
	ioc.reserved = 0;
	do_ioctl(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc);

	/* Zero is not a valid object ID. */
	ioc.count_objs = ARRAY_SIZE(obj_raw);
	do_ioctl_err(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, ENOENT);

	/* Invalid object type (not a thing we can set properties on). */
	ioc.count_objs = 1;
	obj_raw[0] = data->pipe->values[IGT_CRTC_MODE_ID];
	do_ioctl_err(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, ENOENT);
	obj_raw[0] = data->fb.fb_id;
	do_ioctl_err(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, ENOENT);

	/* Filled object but with no properties; no-op. */
	for (i = 0; i < ARRAY_SIZE(obj_raw); i++)
		obj_raw[i] = data->pipe->crtc_id;
	do_ioctl(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc);

	/* Pass in all sorts of things other than the property ID. */
	num_props_raw[0] = 1;
	do_ioctl_err(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, ENOENT);
	props_raw[0] = data->pipe->crtc_id;
	do_ioctl_err(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, ENOENT);
	props_raw[0] = data->primary->drm_plane->plane_id;
	do_ioctl_err(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, ENOENT);
	props_raw[0] = output->id;
	do_ioctl_err(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, ENOENT);
	props_raw[0] = data->pipe->values[IGT_CRTC_MODE_ID];
	do_ioctl_err(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, ENOENT);

	/* Valid property, valid value. */
	for (i = 0; i < ARRAY_SIZE(props_raw); i++) {
		props_raw[i] = data->pipe->props[IGT_CRTC_MODE_ID];
		values_raw[i] = data->pipe->values[IGT_CRTC_MODE_ID];
	}
	do_ioctl(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc);

	/* Setting the same thing multiple times is OK. */
	for (i = 0; i < ARRAY_SIZE(obj_raw); i++)
		num_props_raw[i] = ARRAY_SIZE(props_raw) / ARRAY_SIZE(obj_raw);
	do_ioctl(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc);
	ioc.count_objs = ARRAY_SIZE(obj_raw);
	do_ioctl(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc);

	/* Pass a series of outlandish addresses. */
	ioc.objs_ptr = 0;
	do_ioctl_err(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, EFAULT);

	ioc.objs_ptr = (uintptr_t) obj_raw;
	ioc.count_props_ptr = 0;
	do_ioctl_err(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, EFAULT);

	ioc.count_props_ptr = (uintptr_t) num_props_raw;
	ioc.props_ptr = 0;
	do_ioctl_err(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, EFAULT);

	ioc.props_ptr = (uintptr_t) props_raw;
	ioc.prop_values_ptr = 0;
	do_ioctl_err(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, EFAULT);

	ioc.prop_values_ptr = (uintptr_t) values_raw;
	do_ioctl(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc);

	/* Attempt to overflow and/or trip various boundary conditions. */
	ioc.count_objs = UINT32_MAX / sizeof(uint32_t);
	do_ioctl_err(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, ENOENT);

	ioc.count_objs = ARRAY_SIZE(obj_raw);
	ioc.objs_ptr = UINT64_MAX - sizeof(uint32_t);
	do_ioctl_err(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, EFAULT);
	ioc.count_objs = 1;
	ioc.objs_ptr = UINT64_MAX - sizeof(uint32_t);
	do_ioctl_err(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, EFAULT);

	num_props_raw[0] = UINT32_MAX / sizeof(uint32_t);
	do_ioctl_err(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, EFAULT);
	num_props_raw[0] = UINT32_MAX - 1;
	do_ioctl_err(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, EFAULT);

	for (i = 0; i < ARRAY_SIZE(obj_raw); i++)
		num_props_raw[i] = (UINT32_MAX / ARRAY_SIZE(obj_raw)) + 1;
	do_ioctl_err(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, EFAULT);
	for (i = 0; i < ARRAY_SIZE(obj_raw); i++)
		num_props_raw[i] = ARRAY_SIZE(props_raw) / ARRAY_SIZE(obj_raw);
	do_ioctl_err(data->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, EFAULT);
}

static void atomic_plane_damage(data_t *data)
{
	struct drm_mode_rect damage[2];
	struct igt_fb fb_1, fb_2;
	cairo_t *cr_1, *cr_2;

	/* Color fb with white rect at center */
	igt_create_color_fb(data->drm_fd, data->fb.width, data->fb.height,
			    data->fb.drm_format, I915_TILING_NONE, 0.2, 0.2, 0.2,
			    &fb_1);
	cr_1 = igt_get_cairo_ctx(data->drm_fd, &fb_1);
	igt_paint_color(cr_1, data->fb.width/4, data->fb.height/4, data->fb.width/2,
			data->fb.height/2, 1.0, 1.0, 1.0);
	igt_put_cairo_ctx(cr_1);

	/*
	 * Flip the primary plane to new color fb using atomic API and check the
	 * state.
	 */
	igt_plane_set_fb(data->primary, &fb_1);
	crtc_commit(data->pipe, data->primary, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);

	/*
	 * Change the color of top left clip from center and issue plane update
	 * with damage and verify the state.
	 */
	damage[0].x1 = 0;
	damage[0].y1 = 0;
	damage[0].x2 = data->fb.width/2;
	damage[0].y2 = data->fb.height/2;

	cr_1 = igt_get_cairo_ctx(data->drm_fd, &fb_1);
	igt_paint_color(cr_1, damage[0].x1, damage[0].y1,
			damage_rect_width(&damage[0]),
			damage_rect_height(&damage[0]), 1.0, 0, 0);
	igt_put_cairo_ctx(cr_1);

	igt_plane_set_fb(data->primary, &fb_1);
	igt_plane_replace_prop_blob(data->primary, IGT_PLANE_FB_DAMAGE_CLIPS, damage,
				    sizeof(*damage));
	crtc_commit(data->pipe, data->primary, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);

	/*
	 * Change the color of top left and bottom right clip from center and
	 * issue plane update with damage and verify the state.
	 */
	igt_create_color_fb(data->drm_fd, data->fb.width, data->fb.height,
			    data->fb.drm_format, I915_TILING_NONE, 0.2, 0.2, 0.2,
			    &fb_2);

	damage[0].x1 = data->fb.width/2;
	damage[0].y1 = 0;
	damage[0].x2 = data->fb.width;
	damage[0].y2 = data->fb.height/2;

	cr_2 = igt_get_cairo_ctx(data->drm_fd, &fb_2);
	cr_1 = igt_get_cairo_ctx(data->drm_fd, &fb_1);
	cairo_set_source_surface(cr_2, fb_1.cairo_surface, 0, 0);
	cairo_paint(cr_2);
	igt_paint_color(cr_2, damage[0].x1, damage[0].y1,
			damage_rect_width(&damage[0]),
			damage_rect_height(&damage[0]), 0, 1.0, 0);
	igt_put_cairo_ctx(cr_1);
	igt_put_cairo_ctx(cr_2);
	igt_plane_set_fb(data->primary, &fb_2);
	igt_plane_replace_prop_blob(data->primary, IGT_PLANE_FB_DAMAGE_CLIPS, damage,
				    sizeof(*damage));
	crtc_commit(data->pipe, data->primary, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);

	/*
	 * Issue plane update with damage with a clip outside of plane src.
	 * NOTE: This will result in no update on plane as damage is outside, so
	 * will see no change on the screen.
	 */
	/* Resize fb_1 to be bigger than plane */
	igt_remove_fb(data->drm_fd, &fb_1);
	igt_create_color_fb(data->drm_fd, data->fb.width * 2, data->fb.height,
			    data->fb.drm_format, I915_TILING_NONE, 0.2, 0.2, 0.2,
			    &fb_1);

	damage[0].x1 = data->fb.width;
	damage[0].y1 = 0;
	damage[0].x2 = data->fb.width + data->fb.width/2;
	damage[0].y2 = data->fb.height/2;

	cr_1 = igt_get_cairo_ctx(data->drm_fd, &fb_1);
	cr_2 = igt_get_cairo_ctx(data->drm_fd, &fb_2);
	cairo_set_source_surface(cr_1, fb_2.cairo_surface, 0, 0);
	cairo_paint(cr_1);
	igt_paint_color(cr_1, damage[0].x1, damage[0].y1,
			damage_rect_width(&damage[0]),
			damage_rect_height(&damage[0]), 0, 1.0, 0);
	igt_put_cairo_ctx(cr_2);
	igt_put_cairo_ctx(cr_1);
	igt_plane_set_fb(data->primary, &fb_1);
	igt_plane_set_size(data->primary, data->fb.width, data->fb.height);
	igt_fb_set_position(&fb_1, data->primary, 0, 0);
	igt_fb_set_size(&fb_1, data->primary, data->fb.width, data->fb.height);
	igt_plane_replace_prop_blob(data->primary, IGT_PLANE_FB_DAMAGE_CLIPS, damage,
				    sizeof(*damage));
	crtc_commit(data->pipe, data->primary, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);

	/*
	 * Issue a plane update with damage with a clip that overlap with plane
	 * src (Top right from center extending outside src in below case).
	 * NOTE: Here drm core should take care of intersecting the clip to
	 * plane src.
	 */
	damage[0].x1 = data->fb.width/2;
	damage[0].y1 = 0;
	damage[0].x2 = data->fb.width/2 + data->fb.width;
	damage[0].y2 = data->fb.height/2;

	cr_1 = igt_get_cairo_ctx(data->drm_fd, &fb_1);
	igt_paint_color(cr_1, damage[0].x1, damage[0].y1,
			damage_rect_width(&damage[0]),
			damage_rect_height(&damage[0]), 1.0, 1.0, 0);
	igt_put_cairo_ctx(cr_1);
	igt_plane_set_fb(data->primary, &fb_1);
	igt_plane_set_size(data->primary, data->fb.width, data->fb.height);
	igt_fb_set_position(&fb_1, data->primary, 0, 0);
	igt_fb_set_size(&fb_1, data->primary, data->fb.width, data->fb.height);
	igt_plane_replace_prop_blob(data->primary, IGT_PLANE_FB_DAMAGE_CLIPS, damage,
				    sizeof(*damage));
	crtc_commit(data->pipe, data->primary, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);

	/*
	 * Issue a plane update with damage with two clips one inside plane src
	 * and one outside
	 * NOTE: This will result in plane update with clip inside plane src.
	 */
	damage[0].x1 = 0;
	damage[0].y1 = data->fb.height/2;
	damage[0].x2 = data->fb.width/2;
	damage[0].y2 = data->fb.height;

	damage[1].x1 = data->fb.width + data->fb.width/2;
	damage[1].y1 = data->fb.height/2;
	damage[1].x2 = data->fb.width * 2;
	damage[1].y2 = data->fb.height;

	cr_1 = igt_get_cairo_ctx(data->drm_fd, &fb_1);
	igt_paint_color(cr_1, damage[0].x1, damage[0].y1,
			damage_rect_width(&damage[0]),
			damage_rect_height(&damage[0]), 0, 1.0, 1.0);
	igt_paint_color(cr_1, damage[1].x1, damage[1].y1,
			damage_rect_width(&damage[1]),
			damage_rect_height(&damage[1]), 0, 1.0, 0);
	igt_put_cairo_ctx(cr_1);
	igt_plane_set_fb(data->primary, &fb_1);
	igt_plane_set_size(data->primary, data->fb.width, data->fb.height);
	igt_fb_set_position(&fb_1, data->primary, 0, 0);
	igt_fb_set_size(&fb_1, data->primary, data->fb.width, data->fb.height);
	igt_plane_replace_prop_blob(data->primary, IGT_PLANE_FB_DAMAGE_CLIPS, damage,
				    sizeof(*damage) * 2);
	crtc_commit(data->pipe, data->primary, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);

	/*
	 * Issue a plane update with overlapping damage clips. White rect in
	 * center overlap partially with top left red rect.
	 * NOTE: Drm core does not error for overlapping damage clips so if any
	 * driver does not support overlapping should have their own
	 * validations.
	 */
	damage[0].x1 = 0;
	damage[0].y1 = 0;
	damage[0].x2 = data->fb.width/2;
	damage[0].y2 = data->fb.height/2;

	damage[1].x1 = data->fb.width/4;
	damage[1].y1 = data->fb.height/4;
	damage[1].x2 = data->fb.width/4 + data->fb.width/2;
	damage[1].y2 = data->fb.height/4 + data->fb.height/2;

	cr_1 = igt_get_cairo_ctx(data->drm_fd, &fb_1);
	igt_paint_color(cr_1, damage[0].x1, damage[0].y1,
			damage_rect_width(&damage[0]),
			damage_rect_height(&damage[0]), 1.0, 0, 0);
	igt_paint_color(cr_1, damage[1].x1, damage[1].y1,
			damage_rect_width(&damage[1]),
			damage_rect_height(&damage[1]), 1.0, 1.0, 1.0);
	igt_put_cairo_ctx(cr_1);
	igt_plane_set_fb(data->primary, &fb_1);
	igt_plane_set_size(data->primary, data->fb.width, data->fb.height);
	igt_fb_set_position(&fb_1, data->primary, 0, 0);
	igt_fb_set_size(&fb_1, data->primary, data->fb.width, data->fb.height);
	igt_plane_replace_prop_blob(data->primary, IGT_PLANE_FB_DAMAGE_CLIPS, damage,
				    sizeof(*damage) * 2);
	crtc_commit(data->pipe, data->primary, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);

	/* Restore the primary plane */
	igt_plane_set_fb(data->primary, &data->fb);
	plane_commit(data->primary, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);

	/* Remove the fb created for this test */
	igt_remove_fb(data->drm_fd, &fb_1);
	igt_remove_fb(data->drm_fd, &fb_2);
}

static void atomic_setup(data_t *data, enum pipe pipe, igt_output_t *output)
{
	drmModeModeInfo *mode;
	igt_display_reset(&data->display);
	igt_output_set_pipe(output, pipe);

	data->primary = igt_pipe_get_plane_type(&data->display.pipes[pipe], DRM_PLANE_TYPE_PRIMARY);
	data->pipe = &data->display.pipes[pipe];
	mode = igt_output_get_mode(output);

	igt_create_pattern_fb(data->drm_fd,
			      mode->hdisplay, mode->vdisplay,
			      plane_get_igt_format(data->primary),
			      DRM_FORMAT_MOD_LINEAR, &data->fb);

	igt_plane_set_fb(data->primary, &data->fb);

	crtc_commit(data->primary->pipe, data->primary, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);
}

static void atomic_clear(data_t *data, enum pipe pipe, igt_output_t *output)
{
	igt_plane_t *plane;

	for_each_plane_on_pipe(&data->display, pipe, plane) {
		igt_plane_set_fb(plane, NULL);
		igt_plane_set_position(plane, 0, 0);
	}

	igt_output_set_pipe(output, PIPE_NONE);
	crtc_commit(data->primary->pipe, data->primary, COMMIT_ATOMIC, ATOMIC_RELAX_NONE);
	igt_remove_fb(data->drm_fd, &data->fb);
}

/* Returns true if plane supports zpos property and it's mutable. */
static bool has_mutable_zpos(igt_plane_t *plane)
{
	return igt_plane_check_prop_is_mutable(plane, IGT_PLANE_ZPOS);
}

static bool
pipe_output_combo_valid(igt_display_t *display,
			enum pipe pipe, igt_output_t *output)
{
	bool ret = true;

	igt_display_reset(display);

	igt_output_set_pipe(output, pipe);
	if (!intel_pipe_output_combo_valid(display))
		ret = false;
	igt_output_set_pipe(output, PIPE_NONE);

	return ret;
}

static int opt_handler(int opt, int opt_index, void *_data)
{
	switch (opt) {
		case 'e':
			all_pipes = true;
			break;
		default:
			return IGT_OPT_HANDLER_ERROR;
	}

	return IGT_OPT_HANDLER_SUCCESS;
}

static const char *help_str =
	"  -e \tRun on all pipes. (By default subtests will run only on one pipe)\n";

igt_main_args("e", NULL, help_str, opt_handler, NULL)
{
	enum pipe pipe = PIPE_NONE;
	igt_output_t *output = NULL;
	data_t data = { 0 };

	igt_fixture {
		data.drm_fd = drm_open_driver_master(DRIVER_ANY);
		kmstest_set_vt_graphics_mode();
		igt_display_require(&data.display, data.drm_fd);
		igt_require(data.display.is_atomic);
		igt_display_require_output(&data.display);
	}

	igt_describe("Test for KMS atomic modesetting on overlay plane and ensure coherency between "
		     "the legacy and atomic interfaces.");
	igt_subtest_with_dynamic("plane-overlay-legacy") {
		for_each_pipe_with_single_output(&data.display, pipe, output) {
			igt_plane_t *overlay =
				igt_pipe_get_plane_type(&data.display.pipes[pipe], DRM_PLANE_TYPE_OVERLAY);
			uint32_t format = plane_get_igt_format(overlay);

			if (!pipe_output_combo_valid(&data.display, pipe, output))
				continue;
			if (!overlay || !format)
				continue;
			igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
				atomic_setup(&data, pipe, output);
				plane_overlay(&data, output, overlay, format);
				atomic_clear(&data, pipe, output);
			}
			if (!all_pipes)
				break;
		}
	}

	igt_describe("Test for KMS atomic modesetting on primary plane and ensure coherency between "
		     "the legacy and atomic interfaces.");
	igt_subtest_with_dynamic("plane-primary-legacy") {
		for_each_pipe_with_single_output(&data.display, pipe, output) {
			if (!pipe_output_combo_valid(&data.display, pipe, output))
				continue;
			igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
				atomic_setup(&data, pipe, output);
				plane_primary(&data);
				atomic_clear(&data, pipe, output);
			}
			if (!all_pipes)
				break;
		}
	}

	igt_describe("Verify that the overlay plane can cover the primary one (and "\
		     "vice versa) by changing their zpos property.");
	igt_subtest_with_dynamic("plane-primary-overlay-mutable-zpos") {
		for_each_pipe_with_single_output(&data.display, pipe, output) {
			igt_plane_t *overlay =
				igt_pipe_get_plane_type(&data.display.pipes[pipe], DRM_PLANE_TYPE_OVERLAY);

			if (!pipe_output_combo_valid(&data.display, pipe, output))
				continue;

			atomic_setup(&data, pipe, output);
			if (!overlay)
				continue;
			if (!has_mutable_zpos(data.primary) || !has_mutable_zpos(overlay))
				continue;
			if (!igt_plane_has_format_mod(data.primary, DRM_FORMAT_ARGB8888, 0x0) ||
			    !igt_plane_has_format_mod(overlay, DRM_FORMAT_ARGB1555, 0x0))
				continue;
			igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
				plane_primary_overlay_mutable_zpos(&data, output, overlay,
								   DRM_FORMAT_ARGB8888, DRM_FORMAT_ARGB1555);
				atomic_clear(&data, pipe, output);
			}
			if (!all_pipes)
				break;
		}
	}

	igt_describe("Verify the reported zpos property of planes by making sure "\
		     "only higher zpos planes cover the lower zpos ones.");
	igt_subtest_with_dynamic("plane-immutable-zpos") {
		for_each_pipe_with_single_output(&data.display, pipe, output) {
			int n_planes = data.display.pipes[pipe].n_planes;

			if (!pipe_output_combo_valid(&data.display, pipe, output))
				continue;
			if (n_planes < 2)
				continue;
			igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
				atomic_setup(&data, pipe, output);
				plane_immutable_zpos(&data, output, pipe, n_planes);
				atomic_clear(&data, pipe, output);
			}
			if (!all_pipes)
				break;
		}
	}

	igt_describe("Test to ensure that DRM_MODE_ATOMIC_TEST_ONLY really only touches "
		     "the free-standing state objects and nothing else.");
	igt_subtest_with_dynamic("test-only") {
		for_each_pipe_with_single_output(&data.display, pipe, output) {
			uint32_t format;

			if (!pipe_output_combo_valid(&data.display, pipe, output))
				continue;

			atomic_setup(&data, pipe, output);
			format = plane_get_igt_format(data.primary);

			if (!format)
				continue;
			igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
				atomic_clear(&data, pipe, output);
				test_only(&data, output, pipe, format);
			}
			if (!all_pipes)
				break;
		}
	}

	igt_describe("Test for KMS atomic modesetting on cursor plane and ensure coherency between "
		     "legacy and atomic interfaces.");
	igt_subtest_with_dynamic("plane-cursor-legacy") {
		for_each_pipe_with_single_output(&data.display, pipe, output) {
			igt_plane_t *cursor =
				igt_pipe_get_plane_type(&data.display.pipes[pipe], DRM_PLANE_TYPE_CURSOR);

			if (!pipe_output_combo_valid(&data.display, pipe, output))
				continue;
			if (!cursor)
				continue;
			igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
				atomic_setup(&data, pipe, output);
				plane_cursor(&data, output, cursor);
				atomic_clear(&data, pipe, output);
			}
			if (!all_pipes)
				break;
		}
	}

	igt_describe("Test error handling when invalid plane parameters are passed");
	igt_subtest_with_dynamic("plane-invalid-params") {
		for_each_pipe_with_single_output(&data.display, pipe, output) {
			if (!pipe_output_combo_valid(&data.display, pipe, output))
				continue;
			igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
				atomic_setup(&data, pipe, output);
				plane_invalid_params(&data, output);
				atomic_clear(&data, pipe, output);
			}
			if (!all_pipes)
				break;
		}
	}

	igt_describe("Test error handling when invalid plane fence parameters are passed");
	igt_subtest_with_dynamic("plane-invalid-params-fence") {
		for_each_pipe_with_single_output(&data.display, pipe, output) {
			if (!pipe_output_combo_valid(&data.display, pipe, output))
				continue;
			igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
				atomic_setup(&data, pipe, output);
				plane_invalid_params_fence(&data, output);
				atomic_clear(&data, pipe, output);
			}
			if (!all_pipes)
				break;
		}
	}

	igt_describe("Test error handling when invalid crtc parameters are passed");
	igt_subtest_with_dynamic("crtc-invalid-params") {
		for_each_pipe_with_single_output(&data.display, pipe, output) {
			if (!pipe_output_combo_valid(&data.display, pipe, output))
				continue;
			igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
				atomic_setup(&data, pipe, output);
				crtc_invalid_params(&data, output);
				atomic_clear(&data, pipe, output);
			}
			if (!all_pipes)
				break;
		}
	}

	igt_describe("Test error handling when invalid crtc fence parameters are passed");
	igt_subtest_with_dynamic("crtc-invalid-params-fence") {
		for_each_pipe_with_single_output(&data.display, pipe, output) {
			if (!pipe_output_combo_valid(&data.display, pipe, output))
				continue;
			igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
				atomic_setup(&data, pipe, output);
				crtc_invalid_params_fence(&data, output);
				atomic_clear(&data, pipe, output);
			}
			if (!all_pipes)
				break;
		}
	}

	igt_describe("Test abuse the atomic ioctl directly in order to test "
		     "various invalid conditions which the libdrm wrapper won't "
		     "allow us to create.");
	igt_subtest_with_dynamic("atomic-invalid-params") {
		for_each_pipe_with_single_output(&data.display, pipe, output) {
			if (!pipe_output_combo_valid(&data.display, pipe, output))
				continue;
			igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
				atomic_setup(&data, pipe, output);
				atomic_invalid_params(&data, output);
				atomic_clear(&data, pipe, output);
			}
			if (!all_pipes)
				break;
		}
	}

	igt_describe("Simple test cases to use FB_DAMAGE_CLIPS plane property");
	igt_subtest_with_dynamic("atomic-plane-damage") {
		for_each_pipe_with_single_output(&data.display, pipe, output) {
			if (!pipe_output_combo_valid(&data.display, pipe, output))
				continue;

			atomic_setup(&data, pipe, output);

			if (!igt_plane_has_prop(data.primary, IGT_PLANE_FB_DAMAGE_CLIPS))
				continue;
			igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
				atomic_plane_damage(&data);
				atomic_clear(&data, pipe, output);
			}
			if (!all_pipes)
				break;
		}
	}

	igt_fixture {
		igt_display_fini(&data.display);
		drm_close_driver(data.drm_fd);
	}
}