commit 332041c67c569a417f128846924a40ea0a7f1a2a
author Sam Berlin <sameb@google.com> Tue Jul 01 16:51:26 2014 -0400
committer Sam Berlin <sameb@google.com> Tue Jul 01 17:05:49 2014 -0400
tree 44bcb4c389388ef92057c3816204ab50575cf863
parent 8d883444d53d0ce8072490bc2d056ee87f9f547a

Various style cleanups to BoundFieldModule & test.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=68018366

extensions/testlib/src/com/google/inject/testing/fieldbinder/BoundFieldModule.java

diff --git a/extensions/testlib/src/com/google/inject/testing/fieldbinder/BoundFieldModule.java b/extensions/testlib/src/com/google/inject/testing/fieldbinder/BoundFieldModule.java
index acb0537..5d98b0a 100644
--- a/extensions/testlib/src/com/google/inject/testing/fieldbinder/BoundFieldModule.java
+++ b/extensions/testlib/src/com/google/inject/testing/fieldbinder/BoundFieldModule.java
@@ -243,10 +243,11 @@
           field,
           "Fields annotated with both @Bind and @Inject are illegal.");
     }
-    return Optional.of(new BoundFieldInfo(
-        field,
-        bindAnnotation,
-        containingClassType.getFieldType(field)));
+    return Optional.of(
+        new BoundFieldInfo(
+            field,
+            bindAnnotation,
+            containingClassType.getFieldType(field)));
   }
 
   private LinkedBindingBuilder<?> verifyBindingAnnotations(
@@ -356,8 +357,8 @@
           // addErrorAndThrow already called addError, so do nothing
         }
       }
-      currentClassType = currentClassType.getSupertype(
-          currentClassType.getRawType().getSuperclass());
+      currentClassType =
+          currentClassType.getSupertype(currentClassType.getRawType().getSuperclass());
     }
   }
 }

extensions/testlib/test/com/google/inject/testing/fieldbinder/BoundFieldModuleTest.java

diff --git a/extensions/testlib/test/com/google/inject/testing/fieldbinder/BoundFieldModuleTest.java b/extensions/testlib/test/com/google/inject/testing/fieldbinder/BoundFieldModuleTest.java
index 8e89ee4..768bf3e 100644
--- a/extensions/testlib/test/com/google/inject/testing/fieldbinder/BoundFieldModuleTest.java
+++ b/extensions/testlib/test/com/google/inject/testing/fieldbinder/BoundFieldModuleTest.java
@@ -123,6 +123,24 @@
     assertEquals(testValue, injector.getInstance(Number.class));
   }
 
+  public void testBindingSuperTypeAccessSubType() {
+    final Integer testValue = 1024;
+    Object instance = new Object() {
+      @Bind(to = Number.class) private Integer anInt = testValue;
+    };
+
+    BoundFieldModule module = BoundFieldModule.of(instance);
+    Injector injector = Guice.createInjector(module);
+
+    try {
+      injector.getInstance(Integer.class);
+    } catch (ConfigurationException e) {
+      assertContains(
+          e.getMessage(),
+          "Could not find a suitable constructor in java.lang.Integer");
+    }
+  }
+
   public void testBindingIncorrectTypeProviderFails() {
     final Integer testValue = 1024;
     Object instance = new Object() {
@@ -627,7 +645,7 @@
     };
 
     BoundFieldModule module = BoundFieldModule.of(instance);
-    Injector injector = Guice.createInjector(module);
+    Guice.createInjector(module);
 
     assertEquals(testValue, testNumberProvider.anInt);
   }