commit 8468b5c42f09f049c55c5fa07dcdeeff809d3bb6
author yifeizhuang <zivy@google.com> Mon Apr 26 11:58:32 2021 -0700
committer GitHub <noreply@github.com> Mon Apr 26 11:58:32 2021 -0700
tree f0319498c0cf79d4bbed8a019c2826f88355a8b2
parent b436d0dfb79fce651c6e3a65e9469dd654749e56

tsan, xds: fix data races in ServerWrapperForXds (#8114)

xds/src/main/java/io/grpc/xds/internal/sds/ServerWrapperForXds.java

diff --git a/xds/src/main/java/io/grpc/xds/internal/sds/ServerWrapperForXds.java b/xds/src/main/java/io/grpc/xds/internal/sds/ServerWrapperForXds.java
index 3715575..3500bd7 100644
--- a/xds/src/main/java/io/grpc/xds/internal/sds/ServerWrapperForXds.java
+++ b/xds/src/main/java/io/grpc/xds/internal/sds/ServerWrapperForXds.java
@@ -56,7 +56,7 @@
   private XdsServerBuilder.XdsServingStatusListener xdsServingStatusListener;
   @Nullable XdsClientWrapperForServerSds.ServerWatcher serverWatcher;
   private AtomicBoolean started = new AtomicBoolean();
-  private ServingState currentServingState;
+  private volatile ServingState currentServingState;
   private final long delayForRetry;
   private final TimeUnit timeUnitForDelayForRetry;
   private StartRetryTask startRetryTask;
@@ -239,11 +239,13 @@
       rebuildAndRestartServer();
     }
 
-    private synchronized void cleanUpStartRetryTask() {
-      if (timerService != null) {
-        timerService = SharedResourceHolder.release(GrpcUtil.TIMER_SERVICE, timerService);
+    private void cleanUpStartRetryTask() {
+      synchronized (ServerWrapperForXds.this) {
+        if (timerService != null) {
+          timerService = SharedResourceHolder.release(GrpcUtil.TIMER_SERVICE, timerService);
+        }
+        startRetryTask = null;
       }
-      startRetryTask = null;
     }
 
     public void shutdownNow() {
@@ -290,7 +292,7 @@
 
   private void cleanupStartRetryTaskAndShutdownDelegateAndXdsClient(boolean shutdownNow) {
     Server delegateCopy = null;
-    synchronized (this) {
+    synchronized (ServerWrapperForXds.this) {
       if (startRetryTask != null) {
         startRetryTask.shutdownNow();
       }

xds/src/test/java/io/grpc/xds/ServerWrapperForXdsTest.java

diff --git a/xds/src/test/java/io/grpc/xds/ServerWrapperForXdsTest.java b/xds/src/test/java/io/grpc/xds/ServerWrapperForXdsTest.java
index 1c84a1a..31ab3ae 100644
--- a/xds/src/test/java/io/grpc/xds/ServerWrapperForXdsTest.java
+++ b/xds/src/test/java/io/grpc/xds/ServerWrapperForXdsTest.java
@@ -99,7 +99,12 @@
       }
     });
     // wait until xdsClientWrapperForServerSds.serverWatchers populated
-    for (int i = 0; i < 10 && xdsClientWrapperForServerSds.serverWatchers.isEmpty(); i++) {
+    for (int i = 0; i < 10; i++) {
+      synchronized (xdsClientWrapperForServerSds.serverWatchers) {
+        if (!xdsClientWrapperForServerSds.serverWatchers.isEmpty()) {
+          break;
+        }
+      }
       Thread.sleep(100L);
     }
     return settableFuture;