commit 969d0f7a6317d8f4a7cdac63e514236c632f6093
author Kamil Rojewski <krojew@users.noreply.github.com> Mon Jul 06 17:40:56 2020 +0200
committer GitHub <noreply@github.com> Mon Jul 06 08:40:56 2020 -0700
tree dd4e979004238082965f204913d46da292a0a4d8
parent 515a4052a750dfe6df8d143c8f23cd8aaf51f9d7

Using proper symbol name for reexport (#6021)

Co-authored-by: Kamil Rojewski <kamil.rojewski@gmail.com>

src/idl_gen_js_ts.cpp

diff --git a/src/idl_gen_js_ts.cpp b/src/idl_gen_js_ts.cpp
index 7c3f14a..1a64c48 100644
--- a/src/idl_gen_js_ts.cpp
+++ b/src/idl_gen_js_ts.cpp
@@ -134,12 +134,14 @@
       return;
     }
 
+    std::unordered_set<std::string> imported;
+
     std::string &code = *code_ptr;
     for (auto it = reexports.begin(); it != reexports.end(); ++it) {
       const auto &file = *it;
       const auto basename =
           flatbuffers::StripPath(flatbuffers::StripExtension(file.first));
-      if (basename != file_name_) {
+      if (basename != file_name_ && imported.find(file.second.symbol) == imported.end()) {
         if (imported_files.find(file.first) == imported_files.end()) {
           code += GenPrefixedImport(file.first, basename);
           imported_files.emplace(file.first);
@@ -155,6 +157,8 @@
         }
         code += file.second.symbol + ";\n";
         if (!file.second.target_namespace.empty()) { code += "}\n"; }
+
+        imported.emplace(file.second.symbol);
       }
     }
   }
@@ -366,7 +370,7 @@
       code += (it + 1) != enum_def.Vals().end() ? ",\n" : "\n";
 
       if (ev.union_type.struct_def) {
-        ReexportDescription desc = { ev.name,
+        ReexportDescription desc = { ev.union_type.struct_def->name,
                                      GetNameSpace(*ev.union_type.struct_def),
                                      GetNameSpace(enum_def) };
         reexports.insert(
@@ -977,7 +981,7 @@
         GenTypeAnnotation(kParam, "flatbuffers.Builder", "builder") + " * " +
         GenTypeAnnotation(kReturns, "flatbuffers.Offset", "") +
         " */\npack(builder:flatbuffers.Builder): flatbuffers.Offset {\n";
-    
+
     std::string pack_func_offset_decl;
     std::string pack_func_create_call;
 
@@ -992,7 +996,7 @@
     } else {
       pack_func_create_call = "  " + struct_name + ".start(builder);\n";
     }
-    
+
     if (struct_def.fixed) {
       // when packing struct, nested struct's members instead of the struct's
       // offset are used