commit 4f47b63e9c971e6391590caf00a0f2a5ed612e67
author Erik de Castro Lopo <erikd@mega-nerd.com> Sat Apr 08 18:34:49 2017 +1000
committer Erik de Castro Lopo <erikd@mega-nerd.com> Sat Apr 08 19:15:37 2017 +1000
tree 3d9f0ac2e036292ffb0061cf9929ae4d0a35d909
parent 25b2d82fe4982edbcb54913f4f5db0a1ae9c726d

stream_decoder.c: Fix a memory leak

Leak reported by Secunia Research.

src/libFLAC/stream_decoder.c

diff --git a/src/libFLAC/stream_decoder.c b/src/libFLAC/stream_decoder.c
index 14d5fe7..a552751 100644
--- a/src/libFLAC/stream_decoder.c
+++ b/src/libFLAC/stream_decoder.c
@@ -1753,6 +1753,9 @@
 					}
 					memset (obj->comments[i].entry, 0, obj->comments[i].length) ;
 					if (!FLAC__bitreader_read_byte_block_aligned_no_crc(decoder->private_->input, obj->comments[i].entry, obj->comments[i].length)) {
+						/* Current i-th entry is bad, so we delete it. */
+						free (obj->comments[i].entry) ;
+						obj->comments[i].entry = NULL ;
 						obj->num_comments = i;
 						goto skip;
 					}