commit 33ee81b9f9993701a07fd1d66f111b288baa6604
author Xin Li <delphij@google.com> Thu Sep 05 16:53:24 2019 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Thu Sep 05 16:53:24 2019 +0000
tree dc3ce14fd53a0de19a5c4510e267b2418e5d87aa
parent c3d6f628aac63deac5b5d519f4f15a07085cc5da
parent b69a6b416be01833fa30a9433cd654646ab2d5d6

Merge "DO NOT MERGE - Merge Android 10 into master"

libFLAC/Android.bp

diff --git a/libFLAC/Android.bp b/libFLAC/Android.bp
index d1b51f1..1b9c7bd 100644
--- a/libFLAC/Android.bp
+++ b/libFLAC/Android.bp
@@ -51,9 +51,10 @@
     },
 
     sanitize: {
-        cfi: true,
-        diag: {
-            cfi: true,
-        },
+        integer_overflow: true,
+        misc_undefined: ["bounds"],
+        // Enable CFI if this is used as a shared library
+        // cfi: true,
+        blacklist: "libFLAC_blacklist.txt",
     },
 }

libFLAC/fixed.c

diff --git a/libFLAC/fixed.c b/libFLAC/fixed.c
index 1e2d5b2..2e16251 100644
--- a/libFLAC/fixed.c
+++ b/libFLAC/fixed.c
@@ -87,7 +87,7 @@
 	bits = FLAC__bitmath_ilog2(err)+1;
 	if(bits > 16) {
 		err >>= (bits-16);
-		fracbits -= (bits-16);
+		fracbits -= (int)(bits-16);
 	}
 	rbps = (FLAC__uint32)err;
 
@@ -166,7 +166,7 @@
 	bits = FLAC__bitmath_ilog2_wide(err)+1;
 	if(bits > 16) {
 		err >>= (bits-16);
-		fracbits -= (bits-16);
+		fracbits -= (int)(bits-16); // defined, but cast to int to avoid ubsan assert.
 	}
 	rbps = (FLAC__uint32)err;
 

libFLAC/libFLAC_blacklist.txt

diff --git a/libFLAC/libFLAC_blacklist.txt b/libFLAC/libFLAC_blacklist.txt
new file mode 100644
index 0000000..7dff751
--- /dev/null
+++ b/libFLAC/libFLAC_blacklist.txt
@@ -0,0 +1,14 @@
+[integer]
+# Preemptive due to: while(lag--)
+fun:FLAC__lpc_compute_autocorrelation
+# libFLAC/stream_encoder.c:3982: 4294967292 + 128 cannot be represented in type 'unsigned int'
+fun:precompute_partition_info_sums_
+
+src:*/libFLAC/crc.c
+src:*/libFLAC/md5.c
+src:*/libFLAC/bitmath.c
+src:*/libFLAC/bitreader.c
+src:*/libFLAC/bitwriter.c
+
+# Performance related
+fun:FLAC__lpc_restore_signal_wide