commit 1cefc79c6aa9d526eaf4ffc0a16d8182a4904412
author Jens Axboe <axboe@fb.com> Mon Jun 09 13:54:22 2014 -0600
committer Mohamad Ayyash <mkayyash@google.com> Fri Mar 06 17:57:08 2015 -0800
tree 833de7f88ecb955f220b93eebde57af160ec4fb2
parent 386626f66c67c16c4ff0032b8ceacd4b8a7eb8fa

Fix crash on loading unknown IO engine with --ioengine

We don't clean up properly for a command line job when this happens.

Signed-off-by: Jens Axboe <axboe@fb.com>

init.c

diff --git a/init.c b/init.c
index a546861..74a02e0 100644
--- a/init.c
+++ b/init.c
@@ -1884,8 +1884,14 @@
 					continue;
 
 				td = get_new_job(global, &def_thread, 1);
-				if (!td || ioengine_load(td))
-					goto out_free;
+				if (!td || ioengine_load(td)) {
+					if (td) {
+						put_job(td);
+						td = NULL;
+					}
+					do_exit++;
+					break;
+				}
 				fio_options_set_ioengine_opts(l_opts, td);
 			}
 
@@ -1906,8 +1912,14 @@
 
 			if (!ret && !strcmp(opt, "ioengine")) {
 				free_ioengine(td);
-				if (ioengine_load(td))
-					goto out_free;
+				if (ioengine_load(td)) {
+					if (td) {
+						put_job(td);
+						td = NULL;
+					}
+					do_exit++;
+					break;
+				}
 				fio_options_set_ioengine_opts(l_opts, td);
 			}
 			break;