erofs-utils: avoid using a static srcpath
To avoid unnecessary memory overhead.
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Link: https://lore.kernel.org/r/20230304195812.120063-3-hsiangkao@linux.alibaba.com
diff --git a/include/erofs/internal.h b/include/erofs/internal.h
index 08a3877..d4ae3b8 100644
--- a/include/erofs/internal.h
+++ b/include/erofs/internal.h
@@ -180,7 +180,7 @@
};
} u;
- char i_srcpath[PATH_MAX + 1];
+ char *i_srcpath;
unsigned char datalayout;
unsigned char inode_isize;
diff --git a/lib/inode.c b/lib/inode.c
index 8364451..bcb0986 100644
--- a/lib/inode.c
+++ b/lib/inode.c
@@ -119,6 +119,8 @@
if (inode->eof_tailraw)
free(inode->eof_tailraw);
list_del(&inode->i_hash);
+ if (inode->i_srcpath)
+ free(inode->i_srcpath);
free(inode);
return 0;
}
@@ -905,8 +907,9 @@
return -EINVAL;
}
- strncpy(inode->i_srcpath, path, sizeof(inode->i_srcpath) - 1);
- inode->i_srcpath[sizeof(inode->i_srcpath) - 1] = '\0';
+ inode->i_srcpath = strdup(path);
+ if (!inode->i_srcpath)
+ return -ENOMEM;
inode->dev = st->st_dev;
inode->i_ino[1] = st->st_ino;
@@ -977,10 +980,9 @@
ret = erofs_fill_inode(inode, &st, path);
if (ret) {
- free(inode);
+ erofs_iput(inode);
return ERR_PTR(ret);
}
-
return inode;
}
