codiff: Remove unused filenames variable
I changed the logic at some point stopping the use of that variable, but
then forgot to remove it, do it now.
Addresses this coverity report entry:
Error: COMPILER_WARNING: [#def3]
dwarves-1.13/codiff.c: scope_hint: In function 'main'
dwarves-1.13/codiff.c:776:8: warning: variable 'filenames' set but not used [-Wunused-but-set-variable]
# 776 | char *filenames[2];
# | ^~~~~~~~~
# 774| int remaining, err, rc = EXIT_FAILURE;
# 775| char *old_filename, *new_filename;
# 776|-> char *filenames[2];
# 777| struct stat st;
# 778|
Need to find how to make cmake show these warnings...
Reported-by: William Cohen <wcohen@redhat.com>
Fixes: 991c6a3ebb5d ("dwarves: Rename cus__loadfl with cus__load_files")
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
diff --git a/codiff.c b/codiff.c
index e735686..264b0af 100644
--- a/codiff.c
+++ b/codiff.c
@@ -773,7 +773,6 @@
{
int remaining, err, rc = EXIT_FAILURE;
char *old_filename, *new_filename;
- char *filenames[2];
struct stat st;
if (argp_parse(&codiff__argp, argc, argv, 0, &remaining, NULL) ||
@@ -812,8 +811,6 @@
goto out_cus_delete;
}
- filenames[1] = NULL;
-
/* If old_file is a character device, leave its cus empty */
if (!S_ISCHR(st.st_mode)) {
err = cus__load_file(old_cus, &conf_load, old_filename);
