commit 0a862f61901b3f6866b2f27686a2b63aca4d0a32
author Andre Przywara <andre.przywara@arm.com> Thu Aug 04 09:56:58 2022 +0000
committer Android Build Coastguard Worker <android-build-coastguard-worker@google.com> Thu Aug 18 02:23:05 2022 +0000
tree a601ae0aecc78615e5ffc950b6ae5b05d5cc3173
parent e86d2fc3878a75041a768c53b09e8133e7147daf

[automerge] FROMGIT: libfdt: fdt_offset_ptr(): Fix comparison warnings 2p: 6f0fef2b2a 2p: 736c673f28

Original change: https://googleplex-android-review.googlesource.com/c/platform/external/dtc/+/19527650

Bug: 230794395
Change-Id: If2ae7bf5758338e71c69067b371e6a0bfe83048f
Merged-In: Ice02ecc84d6e9ab30773d039a54664b259979521
(cherry picked from commit 7992e4aeb93afc9d36f7b18fdfa688227d1a9c20)
Merged-In: If2ae7bf5758338e71c69067b371e6a0bfe83048f

libfdt/fdt.c

diff --git a/libfdt/fdt.c b/libfdt/fdt.c
index 3f9cf3e..17ac7d6 100644
--- a/libfdt/fdt.c
+++ b/libfdt/fdt.c
@@ -134,16 +134,20 @@
 
 const void *fdt_offset_ptr(const void *fdt, int offset, unsigned int len)
 {
-	unsigned absoffset = offset + fdt_off_dt_struct(fdt);
+	unsigned int uoffset = offset;
+	unsigned int absoffset = offset + fdt_off_dt_struct(fdt);
+
+	if (offset < 0)
+		return NULL;
 
 	if (!can_assume(VALID_INPUT))
-		if ((absoffset < offset)
+		if ((absoffset < uoffset)
 		    || ((absoffset + len) < absoffset)
 		    || (absoffset + len) > fdt_totalsize(fdt))
 			return NULL;
 
 	if (can_assume(LATEST) || fdt_version(fdt) >= 0x11)
-		if (((offset + len) < offset)
+		if (((uoffset + len) < uoffset)
 		    || ((offset + len) > fdt_size_dt_struct(fdt)))
 			return NULL;