commit 92835ca5d87850ae0c670d66bd73af391b34cdc3
author Kamil Dudka <kdudka@redhat.com> Mon Feb 16 17:00:05 2015 +0100
committer Kamil Dudka <kdudka@redhat.com> Mon Feb 23 13:31:01 2015 +0100
tree 11d0d2c703d034cf47e3bd652e8749dbcd7ecd6e
parent 5d87b1f22ca044e81c75496f913a7eba34992eee

connect: avoid skipping an IPv4 address

... in case the protocol versions are mixed in a DNS response
(IPv6 -> IPv4 -> IPv6).

Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1187531#c3

lib/connect.c

diff --git a/lib/connect.c b/lib/connect.c
index 32888e6..61b1808 100644
--- a/lib/connect.c
+++ b/lib/connect.c
@@ -542,6 +542,7 @@
                           int sockindex,
                           int tempindex)
 {
+  const int other = tempindex ^ 1;
   CURLcode result = CURLE_COULDNT_CONNECT;
 
   /* First clean up after the failed socket.
@@ -572,8 +573,11 @@
     }
 
     while(ai) {
-      while(ai && ai->ai_family != family)
-        ai = ai->ai_next;
+      if(conn->tempaddr[other]) {
+        /* we can safely skip addresses of the other protocol family */
+        while(ai && ai->ai_family != family)
+          ai = ai->ai_next;
+      }
 
       if(ai) {
         result = singleipconnect(conn, ai, &conn->tempsock[tempindex]);