commit 85f9aa08d9ba78843e18b6eda83c81a2f92a729d
author Daniel Stenberg <daniel@haxx.se> Thu Dec 20 16:51:44 2018 +0100
committer Daniel Stenberg <daniel@haxx.se> Sat Dec 22 18:14:56 2018 +0100
tree 6b65f8d371413515b6236f23bb1346246e6f5084
parent fb445a1e18d12f577964c9347bc5bca74b37cd08

conncache_unlock: avoid indirection by changing input argument type

lib/conncache.c

diff --git a/lib/conncache.c b/lib/conncache.c
index 0804418..0ac3849 100644
--- a/lib/conncache.c
+++ b/lib/conncache.c
@@ -178,9 +178,9 @@
   msnprintf(buf, len, "%ld%s", conn->port, hostname);
 }
 
-void Curl_conncache_unlock(struct connectdata *conn)
+void Curl_conncache_unlock(struct Curl_easy *data)
 {
-  CONN_UNLOCK(conn->data);
+  CONN_UNLOCK(data);
 }
 
 /* Returns number of connections currently held in the connection cache.

lib/conncache.h

diff --git a/lib/conncache.h b/lib/conncache.h
index 81566dc..0df6d47 100644
--- a/lib/conncache.h
+++ b/lib/conncache.h
@@ -56,7 +56,7 @@
 /* return the correct bundle, to a host or a proxy */
 struct connectbundle *Curl_conncache_find_bundle(struct connectdata *conn,
                                                  struct conncache *connc);
-void Curl_conncache_unlock(struct connectdata *conn);
+void Curl_conncache_unlock(struct Curl_easy *data);
 /* returns number of connections currently held in the connection cache */
 size_t Curl_conncache_size(struct Curl_easy *data);
 size_t Curl_conncache_bundle_size(struct connectdata *conn);

lib/url.c

diff --git a/lib/url.c b/lib/url.c
index 2ec4587..50719ce 100644
--- a/lib/url.c
+++ b/lib/url.c
@@ -1097,7 +1097,7 @@
         if((bundle->multiuse == BUNDLE_UNKNOWN) && data->set.pipewait) {
           infof(data, "Server doesn't support multi-use yet, wait\n");
           *waitpipe = TRUE;
-          Curl_conncache_unlock(needle);
+          Curl_conncache_unlock(data);
           return FALSE; /* no re-use */
         }
 
@@ -1457,11 +1457,11 @@
   if(chosen) {
     /* mark it as used before releasing the lock */
     chosen->data = data; /* own it! */
-    Curl_conncache_unlock(needle);
+    Curl_conncache_unlock(data);
     *usethis = chosen;
     return TRUE; /* yes, we found one to use! */
   }
-  Curl_conncache_unlock(needle);
+  Curl_conncache_unlock(data);
 
   if(foundPendingCandidate && data->set.pipewait) {
     infof(data,
@@ -3950,7 +3950,7 @@
 
         /* The bundle is full. Extract the oldest connection. */
         conn_candidate = Curl_conncache_extract_bundle(data, bundle);
-        Curl_conncache_unlock(conn);
+        Curl_conncache_unlock(data);
 
         if(conn_candidate)
           (void)Curl_disconnect(data, conn_candidate,
@@ -3962,7 +3962,7 @@
         }
       }
       else
-        Curl_conncache_unlock(conn);
+        Curl_conncache_unlock(data);
 
     }