commit c433c9e79648e6fd752a27f642399b80d889afcb
author Daniel Verkamp <dverkamp@chromium.org> Wed Oct 19 14:15:31 2022 -0700
committer crosvm LUCI <crosvm-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Oct 20 21:15:41 2022 +0000
tree a1b39f566e09d7b6a41c527c7da712d7595bce7a
parent a364040b4b0fff718d9ac1cc3254994f80825ed5

base: remove Windows EventExt::new_with_manual_reset()

Replace the single new_with_manual_reset() call, which passed false to
create an auto-reset event, with a call to the more descriptive
new_auto_reset() function.

This allows the new_with_manual_reset() API to be removed.

BUG=b:231344063
TEST=tools/presubmit --all

Change-Id: I51d1fcbab161d10539c44689b31e2d86ad9e1527
Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/3966482
Reviewed-by: Noah Gold <nkgold@google.com>
Commit-Queue: Daniel Verkamp <dverkamp@chromium.org>

base/src/sys/windows/event.rs

diff --git a/base/src/sys/windows/event.rs b/base/src/sys/windows/event.rs
index 67fb2fe..5166343 100644
--- a/base/src/sys/windows/event.rs
+++ b/base/src/sys/windows/event.rs
@@ -50,19 +50,14 @@
 }
 
 pub trait EventExt {
-    fn new_with_manual_reset(manual_reset: bool) -> Result<Event>;
     fn new_auto_reset() -> Result<Event>;
     fn open(name: &str) -> Result<Event>;
     fn create_event_with_name(name: &str) -> Result<Event>;
 }
 
 impl EventExt for Event {
-    fn new_with_manual_reset(manual_reset: bool) -> Result<Event> {
-        PlatformEvent::new_with_manual_reset(manual_reset).map(Event)
-    }
-
     fn new_auto_reset() -> Result<Event> {
-        Event::new_with_manual_reset(false)
+        PlatformEvent::new_with_manual_reset(false).map(Event)
     }
 
     fn open(name: &str) -> Result<Event> {

win_audio/src/win_audio_impl/mod.rs

diff --git a/win_audio/src/win_audio_impl/mod.rs b/win_audio/src/win_audio_impl/mod.rs
index 3b04bef..7540fc4 100644
--- a/win_audio/src/win_audio_impl/mod.rs
+++ b/win_audio/src/win_audio_impl/mod.rs
@@ -265,7 +265,7 @@
             "Audio Client Initialize() failed."
         )?;
 
-        let ready_to_read_event = Event::new_with_manual_reset(false).unwrap();
+        let ready_to_read_event = Event::new_auto_reset().unwrap();
         // Safe because `ready_to_read_event` will be initialized and also it has the same
         // lifetime as `audio_client` because they are owned by DeviceRenderer on return
         let hr = unsafe { audio_client.SetEventHandle(ready_to_read_event.as_raw_descriptor()) };