commit 64f0eda4e9bb5af5ad785ec56de0f061ea5d140d
author Adam Vartanian <flooey@gmail.com> Wed Jul 05 17:17:03 2017 +0100
committer GitHub <noreply@github.com> Wed Jul 05 17:17:03 2017 +0100
tree 54e562fac4a7a7660225bbe8d548438ed3b99a9c
parent 928173d7b9005312aea5bc6119ea992971e1ed5a

Always use state in ConscryptEngine.is{In,Out}boundClosed() (#242)

common/src/main/java/org/conscrypt/ConscryptEngine.java

diff --git a/common/src/main/java/org/conscrypt/ConscryptEngine.java b/common/src/main/java/org/conscrypt/ConscryptEngine.java
index 58cea30..6e1a929 100644
--- a/common/src/main/java/org/conscrypt/ConscryptEngine.java
+++ b/common/src/main/java/org/conscrypt/ConscryptEngine.java
@@ -582,9 +582,9 @@
 
     @Override
     public boolean isInboundDone() {
-        if (ssl.isClosed()) {
-            synchronized (stateLock) {
-                return state == STATE_CLOSED || state == STATE_CLOSED_INBOUND;
+        synchronized (stateLock) {
+            if (state == STATE_CLOSED || state == STATE_CLOSED_INBOUND) {
+                return true;
             }
         }
         return ssl.wasShutdownReceived();
@@ -592,9 +592,9 @@
 
     @Override
     public boolean isOutboundDone() {
-        if (ssl.isClosed()) {
-            synchronized (stateLock) {
-                return state == STATE_CLOSED || state == STATE_CLOSED_OUTBOUND;
+        synchronized (stateLock) {
+            if (state == STATE_CLOSED || state == STATE_CLOSED_OUTBOUND) {
+                return true;
             }
         }
         return ssl.wasShutdownSent();