commit eb9c55fdfa25d97f61c04f4f06fd499d988045c0
author Fariborz Jahanian <fjahanian@apple.com> Fri Jul 05 23:20:55 2013 +0000
committer Fariborz Jahanian <fjahanian@apple.com> Fri Jul 05 23:20:55 2013 +0000
tree ec9f62829947b4862e7dd4fa6091fb573ba7f5b4
parent 70e7aeccbf5856a84f81366c6c1a0c0c01e70063

[comment parsing]: Removes an unsafe API whose
use can cause crash. No test is available. It is uncovered
by code browsing.  // rdar://14348205


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@185732 91177308-0d34-0410-b5e6-96231b3b80d8

include/clang/AST/Comment.h

diff --git a/include/clang/AST/Comment.h b/include/clang/AST/Comment.h
index d943ad2..ac3eaff 100644
--- a/include/clang/AST/Comment.h
+++ b/include/clang/AST/Comment.h
@@ -1111,10 +1111,6 @@
     return ThisDeclInfo;
   }
   
-  DeclInfo *getThisDeclInfo() const LLVM_READONLY {
-    return ThisDeclInfo;
-  }
-  
   ArrayRef<BlockContentComment *> getBlocks() const { return Blocks; }
   
 };

lib/AST/Comment.cpp

diff --git a/lib/AST/Comment.cpp b/lib/AST/Comment.cpp
index 058485e..a16a023 100644
--- a/lib/AST/Comment.cpp
+++ b/lib/AST/Comment.cpp
@@ -295,12 +295,12 @@
   assert(isParamIndexValid());
   if (isVarArgParam())
     return "...";
-  return FC->getThisDeclInfo()->ParamVars[getParamIndex()]->getName();
+  return FC->getDeclInfo()->ParamVars[getParamIndex()]->getName();
 }
 
 StringRef TParamCommandComment::getParamName(const FullComment *FC) const {
   assert(isPositionValid());
-  const TemplateParameterList *TPL = FC->getThisDeclInfo()->TemplateParameters;
+  const TemplateParameterList *TPL = FC->getDeclInfo()->TemplateParameters;
   for (unsigned i = 0, e = getDepth(); i != e; ++i) {
     if (i == e-1)
       return TPL->getParam(getIndex(i))->getName();