commit 372df4548267ce5d6ecf1da68902f0d793271a4f
author Rafael Espindola <rafael.espindola@gmail.com> Mon Dec 17 22:23:47 2012 +0000
committer Rafael Espindola <rafael.espindola@gmail.com> Mon Dec 17 22:23:47 2012 +0000
tree e5eeb244518abc41b5e8b849549cdedf77640945
parent d566df67bed6381f6e859bbd21fd43ff89277cc0

Fix isThisDeclarationADefinition for extern following tentative.

An extern declaration following a tentative definition should not itself be
considered a tentative definition.
Fixes pr14614.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@170377 91177308-0d34-0410-b5e6-96231b3b80d8

lib/AST/Decl.cpp

diff --git a/lib/AST/Decl.cpp b/lib/AST/Decl.cpp
index 538dcee..4e4bc0e 100644
--- a/lib/AST/Decl.cpp
+++ b/lib/AST/Decl.cpp
@@ -1220,7 +1220,7 @@
        getStorageClassAsWritten() == SC_PrivateExtern) {
     for (const VarDecl *PrevVar = getPreviousDecl();
          PrevVar; PrevVar = PrevVar->getPreviousDecl()) {
-      if (PrevVar->getLinkage() == InternalLinkage && PrevVar->hasInit())
+      if (PrevVar->getLinkage() == InternalLinkage)
         return DeclarationOnly;
     }
   }

test/Sema/extern-redecl.c

diff --git a/test/Sema/extern-redecl.c b/test/Sema/extern-redecl.c
index c176725..ae4386e 100644
--- a/test/Sema/extern-redecl.c
+++ b/test/Sema/extern-redecl.c
@@ -20,3 +20,5 @@
   return PR10013_x; // expected-warning{{incompatible pointer to integer conversion}}
 }
 
+static int test1_a[]; // expected-warning {{tentative array definition assumed to have one element}}
+extern int test1_a[];