commit c4b978d43b046173c3d8051d375dcee04c11d2ec
author robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Tue Oct 08 19:15:58 2013 +0000
committer robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Tue Oct 08 19:15:58 2013 +0000
tree 5b1a210d4c4b66a019bee35d09cbb98b086a533d
parent 69f3d7311b833ccd9cf22e7bbcb0ef5fe1a50969

Fix uninitialized memory access

https://codereview.chromium.org/26529002/



git-svn-id: http://skia.googlecode.com/svn/trunk/src@11658 2bbb7eff-a529-9590-31e7-b0007b416f81

effects/gradients/SkGradientShader.cpp

diff --git a/effects/gradients/SkGradientShader.cpp b/effects/gradients/SkGradientShader.cpp
index 04a2391..dff2d8c 100644
--- a/effects/gradients/SkGradientShader.cpp
+++ b/effects/gradients/SkGradientShader.cpp
@@ -1097,13 +1097,16 @@
                 *this->getColors(2) != *s.getColors(2)) {
                 return false;
             }
+        } else {
+            if (fYCoord != s.getYCoord()) {
+                return false;
+            }
         }
 
         return fTextureAccess.getTexture() == s.fTextureAccess.getTexture()  &&
             fTextureAccess.getParams().getTileModeX() ==
                 s.fTextureAccess.getParams().getTileModeX() &&
             this->useAtlas() == s.useAtlas() &&
-            fYCoord == s.getYCoord() &&
             fCoordTransform.getMatrix().cheapEqualTo(s.fCoordTransform.getMatrix());
     }