commit bb9e22293ee0c0890c981bee55ef7fcdc1614475
author mtklein@google.com <mtklein@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Mon Nov 04 21:22:45 2013 +0000
committer mtklein@google.com <mtklein@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Mon Nov 04 21:22:45 2013 +0000
tree 9e2bf67c41ad3b5833ee4addc27c1bbf0ef0d194
parent c1625930cd1e7fbe644c3ada8afae495d03c18e1

We always read out of bounds here.  Fix that.

Turns out the comment wasn't lying!

BUG=
R=bungeman@google.com

Review URL: https://codereview.chromium.org/58473002

git-svn-id: http://skia.googlecode.com/svn/trunk/src@12123 2bbb7eff-a529-9590-31e7-b0007b416f81

sfnt/SkOTTable_name.cpp

diff --git a/sfnt/SkOTTable_name.cpp b/sfnt/SkOTTable_name.cpp
index b536c0a..b1b8c25 100644
--- a/sfnt/SkOTTable_name.cpp
+++ b/sfnt/SkOTTable_name.cpp
@@ -68,7 +68,8 @@
 static void SkStringFromMacRoman(const uint8_t* macRoman, size_t length, SkString& utf8) {
     utf8.reset();
     for (size_t i = 0; i < length; ++i) {
-        utf8.appendUnichar(macRoman[i] < 0x80 ? macRoman[i] : UnicodeFromMacRoman[macRoman[i]]);
+        utf8.appendUnichar(macRoman[i] < 0x80 ? macRoman[i]
+                                              : UnicodeFromMacRoman[macRoman[i] - 0x80]);
     }
 }