disable autovec on 32 *and* 64 bit builds for horiz. convolve
Works around some garbage bottom rows for certain scaled images. Will land a separate GM that demonstrates.
BUG=skia:
R=mtklein@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/513833003
diff --git a/src/core/SkConvolver.cpp b/src/core/SkConvolver.cpp
index 23a1ee3..49688db 100644
--- a/src/core/SkConvolver.cpp
+++ b/src/core/SkConvolver.cpp
@@ -158,9 +158,12 @@
}
}
- // There's a bug somewhere here with GCC autovectorization (-ftree-vectorize) on 32 bit builds.
+ // There's a bug somewhere here with GCC autovectorization (-ftree-vectorize). We originally
+ // thought this was 32 bit only, but subsequent tests show that some 64 bit gcc compiles
+ // suffer here too.
+ //
// Dropping to -O2 disables -ftree-vectorize. GCC 4.6 needs noinline. http://skbug.com/2575
- #if defined(__i386) && SK_HAS_ATTRIBUTE(optimize) && defined(SK_RELEASE)
+ #if SK_HAS_ATTRIBUTE(optimize) && defined(SK_RELEASE)
#define SK_MAYBE_DISABLE_VECTORIZATION __attribute__((optimize("O2"), noinline))
#else
#define SK_MAYBE_DISABLE_VECTORIZATION
