commit 04d53a5cd5ab609526ecf40159df01975ee2bbfd
author mtklein <mtklein@google.com> Thu Jul 17 11:23:07 2014 -0700
committer Commit bot <commit-bot@chromium.org> Thu Jul 17 11:23:07 2014 -0700
tree 103c985617e71024c8b65dd20c79fd40b2ccf4c5
parent e904c09a3a9c701e8d91f2f6ee161feda7615d90

Revert of nanobench: --veryVerbose for more Win7 debugging (https://codereview.chromium.org/401663002/)

Reason for revert:
Shouldn't be needed anymore.

Original issue's description:
> nanobench: --veryVerbose for more Win7 debugging
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/e57452d

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/404543004

bench/nanobench.cpp

diff --git a/bench/nanobench.cpp b/bench/nanobench.cpp
index 2f670f6..59e85ed 100644
--- a/bench/nanobench.cpp
+++ b/bench/nanobench.cpp
@@ -54,7 +54,6 @@
              "Try up to this many times to guess loops for a bench, or skip the bench.");
 DEFINE_int32(maxLoops, 1000000, "Never run a bench more times than this.");
 
-DEFINE_bool2(veryVerbose, V, false, "Print lots for debugging bots.");
 
 static SkString humanize(double ms) {
     if (ms > 1e+3) return SkStringPrintf("%.3gs",  ms/1e3);
@@ -72,7 +71,6 @@
     WallTimer timer;
     timer.start();
     if (bench) {
-        if (FLAGS_veryVerbose) { SkDebugf("Timing %s for %d loops.\n", bench->getName(), loops); }
         bench->draw(loops, canvas);
     }
     if (canvas) {
@@ -143,7 +141,6 @@
 
     for (int i = 0; i < FLAGS_samples; i++) {
         samples[i] = time(loops, bench, canvas, NULL) / loops;
-        if (FLAGS_veryVerbose) { SkDebugf("  %s\n", HUMANIZE(samples[i])); }
     }
     return loops;
 }
@@ -173,8 +170,6 @@
         // We've overshot at least a little.  Scale back linearly.
         loops = (int)ceil(loops * FLAGS_gpuMs / elapsed);
 
-        if (FLAGS_veryVerbose) { SkDebugf("elapsed %s, loops %d\n", HUMANIZE(elapsed), loops); }
-
         // Might as well make sure we're not still timing our calibration.
         SK_GL(*gl, Finish());
     }
@@ -189,7 +184,6 @@
     // Now, actually do the timing!
     for (int i = 0; i < FLAGS_samples; i++) {
         samples[i] = time(loops, bench, canvas, gl) / loops;
-        if (FLAGS_veryVerbose) { SkDebugf("  %s\n", HUMANIZE(samples[i])); }
     }
     return loops;
 }
@@ -348,6 +342,8 @@
                  cpu_bench(       overhead, bench.get(), canvas, samples.get());
 
             if (loops == 0) {
+                SkDebugf("Unable to time %s\t%s (overhead %s)\n",
+                         bench->getName(), config, HUMANIZE(overhead));
                 continue;
             }