Delete empty inline destructors.
These destructor definitions don't add any value over just depending on
the implicitly-defined destructors.
R=rouslan@chromium.org
BUG=
Review URL: https://codereview.appspot.com/123350044
git-svn-id: http://libaddressinput.googlecode.com/svn/trunk@331 38ededc0-08b8-5190-f2ac-b31f878777ad
diff --git a/cpp/test/address_input_helper_test.cc b/cpp/test/address_input_helper_test.cc
index cfae3f3..4014c91 100644
--- a/cpp/test/address_input_helper_test.cc
+++ b/cpp/test/address_input_helper_test.cc
@@ -49,8 +49,6 @@
address_input_helper_(&supplier_),
loaded_(BuildCallback(this, &AddressInputHelperTest::Loaded)) {}
- ~AddressInputHelperTest() {}
-
// Helper method to test FillAddress that ensures the PreloadSupplier has the
// necessary data preloaded.
void FillAddress(AddressData* address) {
@@ -249,8 +247,6 @@
address_input_helper_(&supplier_),
loaded_(BuildCallback(this, &AddressInputHelperMockDataTest::Loaded)) {}
- ~AddressInputHelperMockDataTest() {}
-
// Helper method to test FillAddress that ensures the PreloadSupplier has the
// necessary data preloaded.
void FillAddress(AddressData* address) {
diff --git a/cpp/test/address_normalizer_test.cc b/cpp/test/address_normalizer_test.cc
index 7a01d38..3a7acf2 100644
--- a/cpp/test/address_normalizer_test.cc
+++ b/cpp/test/address_normalizer_test.cc
@@ -44,8 +44,6 @@
loaded_(BuildCallback(this, &AddressNormalizerTest::OnLoaded)),
normalizer_(&supplier_) {}
- virtual ~AddressNormalizerTest() {}
-
PreloadSupplier supplier_;
const scoped_ptr<const PreloadSupplier::Callback> loaded_;
const AddressNormalizer normalizer_;
diff --git a/cpp/test/address_validator_test.cc b/cpp/test/address_validator_test.cc
index 0b4b025..3177b01 100644
--- a/cpp/test/address_validator_test.cc
+++ b/cpp/test/address_validator_test.cc
@@ -70,8 +70,6 @@
public:
static ValidatorWrapper* Build() { return new OndemandValidatorWrapper; }
- virtual ~OndemandValidatorWrapper() {}
-
virtual void Validate(const AddressData& address,
bool allow_postal,
bool require_name,
@@ -101,8 +99,6 @@
public:
static ValidatorWrapper* Build() { return new PreloadValidatorWrapper; }
- virtual ~PreloadValidatorWrapper() {}
-
virtual void Validate(const AddressData& address,
bool allow_postal,
bool require_name,
@@ -150,8 +146,6 @@
validator_wrapper_((*GetParam())()),
validated_(BuildCallback(this, &AddressValidatorTest::Validated)) {}
- virtual ~AddressValidatorTest() {}
-
void Validate() {
validator_wrapper_->Validate(
address_,
diff --git a/cpp/test/fake_storage_test.cc b/cpp/test/fake_storage_test.cc
index 275c9fc..5905f02 100644
--- a/cpp/test/fake_storage_test.cc
+++ b/cpp/test/fake_storage_test.cc
@@ -41,8 +41,6 @@
data_(),
data_ready_(BuildCallback(this, &FakeStorageTest::OnDataReady)) {}
- virtual ~FakeStorageTest() {}
-
FakeStorage storage_;
bool success_;
std::string key_;
diff --git a/cpp/test/null_storage_test.cc b/cpp/test/null_storage_test.cc
index 8284554..3669ea9 100644
--- a/cpp/test/null_storage_test.cc
+++ b/cpp/test/null_storage_test.cc
@@ -36,8 +36,6 @@
NullStorageTest()
: data_ready_(BuildCallback(this, &NullStorageTest::OnDataReady)) {}
- virtual ~NullStorageTest() {}
-
NullStorage storage_;
bool success_;
std::string key_;
diff --git a/cpp/test/preload_supplier_test.cc b/cpp/test/preload_supplier_test.cc
index bf04a85..8612e98 100644
--- a/cpp/test/preload_supplier_test.cc
+++ b/cpp/test/preload_supplier_test.cc
@@ -46,8 +46,6 @@
: supplier_(new TestdataSource(true), new NullStorage),
loaded_callback_(BuildCallback(this, &PreloadSupplierTest::OnLoaded)) {}
- virtual ~PreloadSupplierTest() {}
-
PreloadSupplier supplier_;
const scoped_ptr<const PreloadSupplier::Callback> loaded_callback_;
diff --git a/cpp/test/region_data_builder_test.cc b/cpp/test/region_data_builder_test.cc
index a60189f..fe2f2e1 100644
--- a/cpp/test/region_data_builder_test.cc
+++ b/cpp/test/region_data_builder_test.cc
@@ -46,8 +46,6 @@
loaded_callback_(BuildCallback(this, &RegionDataBuilderTest::OnLoaded)),
best_language_() {}
- virtual ~RegionDataBuilderTest() {}
-
PreloadSupplier supplier_;
RegionDataBuilder builder_;
const scoped_ptr<const PreloadSupplier::Callback> loaded_callback_;
diff --git a/cpp/test/retriever_test.cc b/cpp/test/retriever_test.cc
index 5b884b0..00c2ea4 100644
--- a/cpp/test/retriever_test.cc
+++ b/cpp/test/retriever_test.cc
@@ -65,8 +65,6 @@
data_(),
data_ready_(BuildCallback(this, &RetrieverTest::OnDataReady)) {}
- virtual ~RetrieverTest() {}
-
Retriever retriever_;
bool success_;
std::string key_;
diff --git a/cpp/test/rule_retriever_test.cc b/cpp/test/rule_retriever_test.cc
index 656b23b..ecf3af7 100644
--- a/cpp/test/rule_retriever_test.cc
+++ b/cpp/test/rule_retriever_test.cc
@@ -48,8 +48,6 @@
rule_(),
rule_ready_(BuildCallback(this, &RuleRetrieverTest::OnRuleReady)) {}
- virtual ~RuleRetrieverTest() {}
-
RuleRetriever rule_retriever_;
bool success_;
std::string key_;
diff --git a/cpp/test/supplier_test.cc b/cpp/test/supplier_test.cc
index bb783db..e55c0c1 100644
--- a/cpp/test/supplier_test.cc
+++ b/cpp/test/supplier_test.cc
@@ -73,8 +73,6 @@
public:
static SupplierWrapper* Build() { return new OndemandSupplierWrapper; }
- virtual ~OndemandSupplierWrapper() {}
-
virtual void Supply(const LookupKey& lookup_key,
const Supplier::Callback& supplied) {
ondemand_supplier_.Supply(lookup_key, supplied);
@@ -92,8 +90,6 @@
public:
static SupplierWrapper* Build() { return new PreloadSupplierWrapper; }
- virtual ~PreloadSupplierWrapper() {}
-
virtual void Supply(const LookupKey& lookup_key,
const Supplier::Callback& supplied) {
const std::string& region_code = lookup_key.GetRegionCode();
@@ -125,8 +121,6 @@
supplier_wrapper_((*GetParam())()),
supplied_(BuildCallback(this, &SupplierTest::Supplied)) {}
- virtual ~SupplierTest() {}
-
void Supply() {
lookup_key_.FromAddress(address_);
supplier_wrapper_->Supply(lookup_key_, *supplied_);
diff --git a/cpp/test/testdata_source_test.cc b/cpp/test/testdata_source_test.cc
index 095b503..58468a9 100644
--- a/cpp/test/testdata_source_test.cc
+++ b/cpp/test/testdata_source_test.cc
@@ -45,8 +45,6 @@
data_(),
data_ready_(BuildCallback(this, &TestdataSourceTest::OnDataReady)) {}
- virtual ~TestdataSourceTest() {}
-
TestdataSource source_;
TestdataSource aggregate_source_;
bool success_;
diff --git a/cpp/test/validating_storage_test.cc b/cpp/test/validating_storage_test.cc
index 36f85d9..3c8aa53 100644
--- a/cpp/test/validating_storage_test.cc
+++ b/cpp/test/validating_storage_test.cc
@@ -56,8 +56,6 @@
data_(),
data_ready_(BuildCallback(this, &ValidatingStorageTest::OnDataReady)) {}
- virtual ~ValidatingStorageTest() {}
-
Storage* const wrapped_storage_; // Owned by |storage_|.
ValidatingStorage storage_;
bool success_;
diff --git a/cpp/test/validation_task_test.cc b/cpp/test/validation_task_test.cc
index e3900bd..a092ff7 100644
--- a/cpp/test/validation_task_test.cc
+++ b/cpp/test/validation_task_test.cc
@@ -83,8 +83,6 @@
filter_.insert(std::make_pair(RECIPIENT, MISSING_REQUIRED_FIELD));
}
- virtual ~ValidationTaskTest() {}
-
void Validate() {
Rule rule[arraysize(json_)];
