| // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| // Use of this source code is governed by a BSD-style license that can be |
| // found in the LICENSE file. |
| |
| #include "base/memory/scoped_ptr.h" |
| #include "chrome/browser/favicon/favicon_handler.h" |
| #include "chrome/browser/favicon/favicon_service_factory.h" |
| #include "chrome/browser/profiles/profile.h" |
| #include "chrome/test/base/chrome_render_view_host_test_harness.h" |
| #include "content/public/browser/favicon_status.h" |
| #include "content/public/browser/invalidate_type.h" |
| #include "content/public/browser/navigation_entry.h" |
| #include "content/public/browser/web_contents.h" |
| #include "third_party/skia/include/core/SkBitmap.h" |
| #include "ui/gfx/codec/png_codec.h" |
| #include "ui/gfx/favicon_size.h" |
| #include "ui/gfx/image/image.h" |
| |
| class TestFaviconHandler; |
| |
| using content::FaviconURL; |
| using content::NavigationEntry; |
| using content::WebContents; |
| |
| namespace { |
| |
| // Fill the given bmp with valid png data. |
| void FillDataToBitmap(int w, int h, SkBitmap* bmp) { |
| bmp->setConfig(SkBitmap::kARGB_8888_Config, w, h); |
| bmp->allocPixels(); |
| |
| unsigned char* src_data = |
| reinterpret_cast<unsigned char*>(bmp->getAddr32(0, 0)); |
| for (int i = 0; i < w * h; i++) { |
| src_data[i * 4 + 0] = static_cast<unsigned char>(i % 255); |
| src_data[i * 4 + 1] = static_cast<unsigned char>(i % 255); |
| src_data[i * 4 + 2] = static_cast<unsigned char>(i % 255); |
| src_data[i * 4 + 3] = static_cast<unsigned char>(i % 255); |
| } |
| } |
| |
| // Fill the given data buffer with valid png data. |
| void FillBitmap(int w, int h, std::vector<unsigned char>* output) { |
| SkBitmap bitmap; |
| FillDataToBitmap(w, h, &bitmap); |
| gfx::PNGCodec::EncodeBGRASkBitmap(bitmap, false, output); |
| } |
| |
| void SetFaviconBitmapResult( |
| const GURL& icon_url, |
| chrome::IconType icon_type, |
| bool expired, |
| std::vector<chrome::FaviconBitmapResult>* favicon_bitmap_results) { |
| scoped_refptr<base::RefCountedBytes> data(new base::RefCountedBytes()); |
| FillBitmap(gfx::kFaviconSize, gfx::kFaviconSize, &data->data()); |
| chrome::FaviconBitmapResult bitmap_result; |
| bitmap_result.expired = expired; |
| bitmap_result.bitmap_data = data; |
| // Use a pixel size other than (0,0) as (0,0) has a special meaning. |
| bitmap_result.pixel_size = gfx::Size(gfx::kFaviconSize, gfx::kFaviconSize); |
| bitmap_result.icon_type = icon_type; |
| bitmap_result.icon_url = icon_url; |
| |
| favicon_bitmap_results->push_back(bitmap_result); |
| } |
| |
| void SetFaviconBitmapResult( |
| const GURL& icon_url, |
| std::vector<chrome::FaviconBitmapResult>* favicon_bitmap_results) { |
| SetFaviconBitmapResult(icon_url, chrome::FAVICON, false /* expired */, |
| favicon_bitmap_results); |
| } |
| |
| // This class is used to save the download request for verifying with test case. |
| // It also will be used to invoke the onDidDownload callback. |
| class DownloadHandler { |
| public: |
| explicit DownloadHandler(TestFaviconHandler* favicon_helper) |
| : favicon_helper_(favicon_helper), |
| failed_(false) { |
| } |
| |
| virtual ~DownloadHandler() { |
| } |
| |
| void Reset() { |
| download_.reset(NULL); |
| failed_ = false; |
| } |
| |
| void AddDownload(int download_id, const GURL& image_url, int image_size) { |
| download_.reset(new Download(download_id, image_url, image_size, false)); |
| } |
| |
| void InvokeCallback(); |
| |
| void set_failed(bool failed) { failed_ = failed; } |
| |
| bool HasDownload() const { return download_.get() != NULL; } |
| const GURL& GetImageUrl() const { return download_->image_url; } |
| int GetImageSize() const { return download_->image_size; } |
| void SetImageSize(int size) { download_->image_size = size; } |
| |
| private: |
| struct Download { |
| Download(int id, GURL url, int size, bool failed) |
| : download_id(id), |
| image_url(url), |
| image_size(size) {} |
| ~Download() {} |
| int download_id; |
| GURL image_url; |
| int image_size; |
| }; |
| |
| TestFaviconHandler* favicon_helper_; |
| scoped_ptr<Download> download_; |
| bool failed_; |
| |
| DISALLOW_COPY_AND_ASSIGN(DownloadHandler); |
| }; |
| |
| // This class is used to save the history request for verifying with test case. |
| // It also will be used to simulate the history response. |
| class HistoryRequestHandler { |
| public: |
| HistoryRequestHandler(const GURL& page_url, |
| const GURL& icon_url, |
| int icon_type, |
| const FaviconService::FaviconResultsCallback& callback) |
| : page_url_(page_url), |
| icon_url_(icon_url), |
| icon_type_(icon_type), |
| callback_(callback) { |
| } |
| |
| HistoryRequestHandler(const GURL& page_url, |
| const GURL& icon_url, |
| int icon_type, |
| const std::vector<unsigned char>& bitmap_data) |
| : page_url_(page_url), |
| icon_url_(icon_url), |
| icon_type_(icon_type), |
| bitmap_data_(bitmap_data) { |
| } |
| |
| virtual ~HistoryRequestHandler() {} |
| void InvokeCallback(); |
| |
| const GURL page_url_; |
| const GURL icon_url_; |
| const int icon_type_; |
| const std::vector<unsigned char> bitmap_data_; |
| std::vector<chrome::FaviconBitmapResult> history_results_; |
| FaviconService::FaviconResultsCallback callback_; |
| |
| private: |
| DISALLOW_COPY_AND_ASSIGN(HistoryRequestHandler); |
| }; |
| |
| } // namespace |
| |
| |
| // This class is used as a temporary hack to provide working implementations of |
| // the various delegate methods. Most of these methods are actually never |
| // called. |
| // TODO(rohitrao): Refactor the tests to override these delegate methods instead |
| // of subclassing. |
| class TestFaviconHandlerDelegate : public FaviconHandlerDelegate { |
| public: |
| explicit TestFaviconHandlerDelegate(WebContents* web_contents) |
| : web_contents_(web_contents) { |
| } |
| |
| virtual NavigationEntry* GetActiveEntry() OVERRIDE { |
| ADD_FAILURE() << "TestFaviconHandlerDelegate::GetActiveEntry() " |
| << "should never be called in tests."; |
| return NULL; |
| } |
| |
| virtual int StartDownload(const GURL& url, |
| int preferred_image_size, |
| int max_image_size) OVERRIDE { |
| ADD_FAILURE() << "TestFaviconHandlerDelegate::StartDownload() " |
| << "should never be called in tests."; |
| return -1; |
| } |
| |
| virtual void NotifyFaviconUpdated(bool icon_url_changed) OVERRIDE { |
| web_contents_->NotifyNavigationStateChanged(content::INVALIDATE_TYPE_TAB); |
| } |
| |
| private: |
| WebContents* web_contents_; // weak |
| }; |
| |
| // This class is used to catch the FaviconHandler's download and history |
| // request, and also provide the methods to access the FaviconHandler |
| // internals. |
| class TestFaviconHandler : public FaviconHandler { |
| public: |
| TestFaviconHandler(const GURL& page_url, |
| Profile* profile, |
| FaviconHandlerDelegate* delegate, |
| Type type) |
| : FaviconHandler(profile, delegate, type), |
| entry_(NavigationEntry::Create()), |
| download_id_(0) { |
| entry_->SetURL(page_url); |
| download_handler_.reset(new DownloadHandler(this)); |
| } |
| |
| virtual ~TestFaviconHandler() { |
| } |
| |
| HistoryRequestHandler* history_handler() { |
| return history_handler_.get(); |
| } |
| |
| // This method will take the ownership of the given handler. |
| void set_history_handler(HistoryRequestHandler* handler) { |
| history_handler_.reset(handler); |
| } |
| |
| DownloadHandler* download_handler() { |
| return download_handler_.get(); |
| } |
| |
| virtual NavigationEntry* GetEntry() OVERRIDE { |
| return entry_.get(); |
| } |
| |
| const std::deque<FaviconURL>& urls() { |
| return image_urls_; |
| } |
| |
| void FetchFavicon(const GURL& url) { |
| FaviconHandler::FetchFavicon(url); |
| } |
| |
| // The methods to access favicon internal. |
| FaviconURL* current_candidate() { |
| return FaviconHandler::current_candidate(); |
| } |
| |
| protected: |
| virtual void UpdateFaviconMappingAndFetch( |
| const GURL& page_url, |
| const GURL& icon_url, |
| chrome::IconType icon_type, |
| const FaviconService::FaviconResultsCallback& callback, |
| CancelableTaskTracker* tracker) OVERRIDE { |
| history_handler_.reset(new HistoryRequestHandler(page_url, icon_url, |
| icon_type, callback)); |
| } |
| |
| virtual void GetFavicon( |
| const GURL& icon_url, |
| chrome::IconType icon_type, |
| const FaviconService::FaviconResultsCallback& callback, |
| CancelableTaskTracker* tracker) OVERRIDE { |
| history_handler_.reset(new HistoryRequestHandler(GURL(), icon_url, |
| icon_type, callback)); |
| } |
| |
| virtual void GetFaviconForURL( |
| const GURL& page_url, |
| int icon_types, |
| const FaviconService::FaviconResultsCallback& callback, |
| CancelableTaskTracker* tracker) OVERRIDE { |
| history_handler_.reset(new HistoryRequestHandler(page_url, GURL(), |
| icon_types, callback)); |
| } |
| |
| virtual int DownloadFavicon(const GURL& image_url, |
| int image_size, |
| chrome::IconType icon_type) OVERRIDE { |
| download_id_++; |
| download_handler_->AddDownload(download_id_, image_url, image_size); |
| return download_id_; |
| } |
| |
| virtual void SetHistoryFavicons(const GURL& page_url, |
| const GURL& icon_url, |
| chrome::IconType icon_type, |
| const gfx::Image& image) OVERRIDE { |
| scoped_refptr<base::RefCountedMemory> bytes = image.As1xPNGBytes(); |
| std::vector<unsigned char> bitmap_data(bytes->front(), |
| bytes->front() + bytes->size()); |
| history_handler_.reset(new HistoryRequestHandler( |
| page_url, icon_url, icon_type, bitmap_data)); |
| } |
| |
| virtual FaviconService* GetFaviconService() OVERRIDE { |
| // Just give none NULL value, so overridden methods can be hit. |
| return (FaviconService*)(1); |
| } |
| |
| virtual bool ShouldSaveFavicon(const GURL& url) OVERRIDE { |
| return true; |
| } |
| |
| GURL page_url_; |
| |
| private: |
| scoped_ptr<NavigationEntry> entry_; |
| |
| // The unique id of a download request. It will be returned to a |
| // FaviconHandler. |
| int download_id_; |
| |
| scoped_ptr<DownloadHandler> download_handler_; |
| scoped_ptr<HistoryRequestHandler> history_handler_; |
| |
| DISALLOW_COPY_AND_ASSIGN(TestFaviconHandler); |
| }; |
| |
| namespace { |
| |
| void HistoryRequestHandler::InvokeCallback() { |
| if (!callback_.is_null()) { |
| callback_.Run(history_results_); |
| } |
| } |
| |
| void DownloadHandler::InvokeCallback() { |
| SkBitmap bitmap; |
| const int kRequestedSize = gfx::kFaviconSize; |
| int downloaded_size = (download_->image_size > 0) ? |
| download_->image_size : gfx::kFaviconSize; |
| FillDataToBitmap(downloaded_size, downloaded_size, &bitmap); |
| std::vector<SkBitmap> bitmaps; |
| if (!failed_) |
| bitmaps.push_back(bitmap); |
| favicon_helper_->OnDidDownloadFavicon( |
| download_->download_id, download_->image_url, kRequestedSize, bitmaps); |
| } |
| |
| class FaviconHandlerTest : public ChromeRenderViewHostTestHarness { |
| public: |
| FaviconHandlerTest() { |
| } |
| |
| virtual ~FaviconHandlerTest() { |
| } |
| |
| virtual void SetUp() { |
| // The score computed by SelectFaviconFrames() is dependent on the supported |
| // scale factors of the platform. It is used for determining the goodness of |
| // a downloaded bitmap in FaviconHandler::OnDidDownloadFavicon(). |
| // Force the values of the scale factors so that the tests produce the same |
| // results on all platforms. |
| std::vector<ui::ScaleFactor> scale_factors; |
| scale_factors.push_back(ui::SCALE_FACTOR_100P); |
| ui::test::SetSupportedScaleFactors(scale_factors); |
| |
| ChromeRenderViewHostTestHarness::SetUp(); |
| } |
| |
| virtual void TearDown() OVERRIDE { |
| Profile* profile = Profile::FromBrowserContext( |
| web_contents()->GetBrowserContext()); |
| FaviconServiceFactory::GetInstance()->SetTestingFactory( |
| profile, NULL); |
| ChromeRenderViewHostTestHarness::TearDown(); |
| } |
| |
| private: |
| DISALLOW_COPY_AND_ASSIGN(FaviconHandlerTest); |
| }; |
| |
| TEST_F(FaviconHandlerTest, GetFaviconFromHistory) { |
| const GURL page_url("http://www.google.com"); |
| const GURL icon_url("http://www.google.com/favicon"); |
| |
| TestFaviconHandlerDelegate delegate(web_contents()); |
| Profile* profile = Profile::FromBrowserContext( |
| web_contents()->GetBrowserContext()); |
| TestFaviconHandler helper(page_url, profile, |
| &delegate, FaviconHandler::FAVICON); |
| |
| helper.FetchFavicon(page_url); |
| HistoryRequestHandler* history_handler = helper.history_handler(); |
| // Ensure the data given to history is correct. |
| ASSERT_TRUE(history_handler); |
| EXPECT_EQ(page_url, history_handler->page_url_); |
| EXPECT_EQ(GURL(), history_handler->icon_url_); |
| EXPECT_EQ(chrome::FAVICON, history_handler->icon_type_); |
| |
| SetFaviconBitmapResult(icon_url, &history_handler->history_results_); |
| |
| // Send history response. |
| history_handler->InvokeCallback(); |
| // Verify FaviconHandler status |
| EXPECT_TRUE(helper.GetEntry()->GetFavicon().valid); |
| EXPECT_EQ(icon_url, helper.GetEntry()->GetFavicon().url); |
| |
| // Simulates update favicon url. |
| std::vector<FaviconURL> urls; |
| urls.push_back(FaviconURL(icon_url, FaviconURL::FAVICON)); |
| helper.OnUpdateFaviconURL(0, urls); |
| |
| // Verify FaviconHandler status |
| EXPECT_EQ(1U, helper.urls().size()); |
| ASSERT_TRUE(helper.current_candidate()); |
| ASSERT_EQ(icon_url, helper.current_candidate()->icon_url); |
| ASSERT_EQ(FaviconURL::FAVICON, helper.current_candidate()->icon_type); |
| |
| // Favicon shouldn't request to download icon. |
| EXPECT_FALSE(helper.download_handler()->HasDownload()); |
| } |
| |
| TEST_F(FaviconHandlerTest, DownloadFavicon) { |
| const GURL page_url("http://www.google.com"); |
| const GURL icon_url("http://www.google.com/favicon"); |
| |
| TestFaviconHandlerDelegate delegate(web_contents()); |
| Profile* profile = Profile::FromBrowserContext( |
| web_contents()->GetBrowserContext()); |
| TestFaviconHandler helper(page_url, profile, |
| &delegate, FaviconHandler::FAVICON); |
| |
| helper.FetchFavicon(page_url); |
| HistoryRequestHandler* history_handler = helper.history_handler(); |
| // Ensure the data given to history is correct. |
| ASSERT_TRUE(history_handler); |
| EXPECT_EQ(page_url, history_handler->page_url_); |
| EXPECT_EQ(GURL(), history_handler->icon_url_); |
| EXPECT_EQ(chrome::FAVICON, history_handler->icon_type_); |
| |
| // Set icon data expired |
| SetFaviconBitmapResult(icon_url, chrome::FAVICON, true /* expired */, |
| &history_handler->history_results_); |
| // Send history response. |
| history_handler->InvokeCallback(); |
| // Verify FaviconHandler status |
| EXPECT_TRUE(helper.GetEntry()->GetFavicon().valid); |
| EXPECT_EQ(icon_url, helper.GetEntry()->GetFavicon().url); |
| |
| // Simulates update favicon url. |
| std::vector<FaviconURL> urls; |
| urls.push_back(FaviconURL(icon_url, FaviconURL::FAVICON)); |
| helper.OnUpdateFaviconURL(0, urls); |
| |
| // Verify FaviconHandler status |
| EXPECT_EQ(1U, helper.urls().size()); |
| ASSERT_TRUE(helper.current_candidate()); |
| ASSERT_EQ(icon_url, helper.current_candidate()->icon_url); |
| ASSERT_EQ(FaviconURL::FAVICON, helper.current_candidate()->icon_type); |
| |
| // Favicon should request to download icon now. |
| DownloadHandler* download_handler = helper.download_handler(); |
| EXPECT_TRUE(helper.download_handler()->HasDownload()); |
| |
| // Verify the download request. |
| EXPECT_EQ(icon_url, download_handler->GetImageUrl()); |
| EXPECT_EQ(gfx::kFaviconSize, download_handler->GetImageSize()); |
| |
| // Reset the history_handler to verify whether favicon is set. |
| helper.set_history_handler(NULL); |
| |
| // Smulates download done. |
| download_handler->InvokeCallback(); |
| |
| // New icon should be saved to history backend and navigation entry. |
| history_handler = helper.history_handler(); |
| ASSERT_TRUE(history_handler); |
| EXPECT_EQ(icon_url, history_handler->icon_url_); |
| EXPECT_EQ(FaviconURL::FAVICON, history_handler->icon_type_); |
| EXPECT_LT(0U, history_handler->bitmap_data_.size()); |
| EXPECT_EQ(page_url, history_handler->page_url_); |
| |
| // Verify NavigationEntry. |
| EXPECT_EQ(icon_url, helper.GetEntry()->GetFavicon().url); |
| EXPECT_TRUE(helper.GetEntry()->GetFavicon().valid); |
| EXPECT_FALSE(helper.GetEntry()->GetFavicon().image.IsEmpty()); |
| } |
| |
| TEST_F(FaviconHandlerTest, UpdateAndDownloadFavicon) { |
| const GURL page_url("http://www.google.com"); |
| const GURL icon_url("http://www.google.com/favicon"); |
| const GURL new_icon_url("http://www.google.com/new_favicon"); |
| |
| TestFaviconHandlerDelegate delegate(web_contents()); |
| Profile* profile = Profile::FromBrowserContext( |
| web_contents()->GetBrowserContext()); |
| TestFaviconHandler helper(page_url, profile, |
| &delegate, FaviconHandler::FAVICON); |
| |
| helper.FetchFavicon(page_url); |
| HistoryRequestHandler* history_handler = helper.history_handler(); |
| // Ensure the data given to history is correct. |
| ASSERT_TRUE(history_handler); |
| EXPECT_EQ(page_url, history_handler->page_url_); |
| EXPECT_EQ(GURL(), history_handler->icon_url_); |
| EXPECT_EQ(chrome::FAVICON, history_handler->icon_type_); |
| |
| // Set valid icon data. |
| SetFaviconBitmapResult(icon_url, &history_handler->history_results_); |
| |
| // Send history response. |
| history_handler->InvokeCallback(); |
| // Verify FaviconHandler status. |
| EXPECT_TRUE(helper.GetEntry()->GetFavicon().valid); |
| EXPECT_EQ(icon_url, helper.GetEntry()->GetFavicon().url); |
| |
| // Reset the history_handler to verify whether new icon is requested from |
| // history. |
| helper.set_history_handler(NULL); |
| |
| // Simulates update with the different favicon url. |
| std::vector<FaviconURL> urls; |
| urls.push_back(FaviconURL(new_icon_url, FaviconURL::FAVICON)); |
| helper.OnUpdateFaviconURL(0, urls); |
| |
| // Verify FaviconHandler status. |
| EXPECT_EQ(1U, helper.urls().size()); |
| ASSERT_TRUE(helper.current_candidate()); |
| ASSERT_EQ(new_icon_url, helper.current_candidate()->icon_url); |
| ASSERT_EQ(FaviconURL::FAVICON, helper.current_candidate()->icon_type); |
| |
| // Favicon should be requested from history. |
| history_handler = helper.history_handler(); |
| ASSERT_TRUE(history_handler); |
| EXPECT_EQ(new_icon_url, history_handler->icon_url_); |
| EXPECT_EQ(FaviconURL::FAVICON, history_handler->icon_type_); |
| EXPECT_EQ(page_url, history_handler->page_url_); |
| |
| // Simulate not find icon. |
| history_handler->history_results_.clear(); |
| history_handler->InvokeCallback(); |
| |
| // Favicon should request to download icon now. |
| DownloadHandler* download_handler = helper.download_handler(); |
| EXPECT_TRUE(helper.download_handler()->HasDownload()); |
| |
| // Verify the download request. |
| EXPECT_EQ(new_icon_url, download_handler->GetImageUrl()); |
| EXPECT_EQ(gfx::kFaviconSize, download_handler->GetImageSize()); |
| |
| // Reset the history_handler to verify whether favicon is set. |
| helper.set_history_handler(NULL); |
| |
| // Smulates download done. |
| download_handler->InvokeCallback(); |
| |
| // New icon should be saved to history backend and navigation entry. |
| history_handler = helper.history_handler(); |
| ASSERT_TRUE(history_handler); |
| EXPECT_EQ(new_icon_url, history_handler->icon_url_); |
| EXPECT_EQ(FaviconURL::FAVICON, history_handler->icon_type_); |
| EXPECT_LT(0U, history_handler->bitmap_data_.size()); |
| EXPECT_EQ(page_url, history_handler->page_url_); |
| |
| // Verify NavigationEntry. |
| EXPECT_EQ(new_icon_url, helper.GetEntry()->GetFavicon().url); |
| EXPECT_TRUE(helper.GetEntry()->GetFavicon().valid); |
| EXPECT_FALSE(helper.GetEntry()->GetFavicon().image.IsEmpty()); |
| } |
| |
| TEST_F(FaviconHandlerTest, FaviconInHistoryInvalid) { |
| const GURL page_url("http://www.google.com"); |
| const GURL icon_url("http://www.google.com/favicon"); |
| |
| TestFaviconHandlerDelegate delegate(web_contents()); |
| Profile* profile = Profile::FromBrowserContext( |
| web_contents()->GetBrowserContext()); |
| TestFaviconHandler helper(page_url, profile, |
| &delegate, FaviconHandler::FAVICON); |
| |
| helper.FetchFavicon(page_url); |
| HistoryRequestHandler* history_handler = helper.history_handler(); |
| // Ensure the data given to history is correct. |
| ASSERT_TRUE(history_handler); |
| EXPECT_EQ(page_url, history_handler->page_url_); |
| EXPECT_EQ(GURL(), history_handler->icon_url_); |
| EXPECT_EQ(chrome::FAVICON, history_handler->icon_type_); |
| |
| // Set non empty but invalid data. |
| chrome::FaviconBitmapResult bitmap_result; |
| bitmap_result.expired = false; |
| // Empty bitmap data is invalid. |
| bitmap_result.bitmap_data = new base::RefCountedBytes(); |
| bitmap_result.pixel_size = gfx::Size(gfx::kFaviconSize, gfx::kFaviconSize); |
| bitmap_result.icon_type = chrome::FAVICON; |
| bitmap_result.icon_url = icon_url; |
| history_handler->history_results_.clear(); |
| history_handler->history_results_.push_back(bitmap_result); |
| |
| // Send history response. |
| history_handler->InvokeCallback(); |
| // The NavigationEntry should not be set yet as the history data is invalid. |
| EXPECT_FALSE(helper.GetEntry()->GetFavicon().valid); |
| EXPECT_EQ(GURL(), helper.GetEntry()->GetFavicon().url); |
| |
| // Reset the history_handler to verify whether new icon is requested from |
| // history. |
| helper.set_history_handler(NULL); |
| |
| // Simulates update with matching favicon URL. |
| std::vector<FaviconURL> urls; |
| urls.push_back(FaviconURL(icon_url, FaviconURL::FAVICON)); |
| helper.OnUpdateFaviconURL(0, urls); |
| |
| // A download for the favicon should be requested, and we should not do |
| // another history request. |
| DownloadHandler* download_handler = helper.download_handler(); |
| EXPECT_TRUE(helper.download_handler()->HasDownload()); |
| EXPECT_EQ(NULL, helper.history_handler()); |
| |
| // Verify the download request. |
| EXPECT_EQ(icon_url, download_handler->GetImageUrl()); |
| EXPECT_EQ(gfx::kFaviconSize, download_handler->GetImageSize()); |
| |
| // Simulates download done. |
| download_handler->InvokeCallback(); |
| |
| // New icon should be saved to history backend and navigation entry. |
| history_handler = helper.history_handler(); |
| ASSERT_TRUE(history_handler); |
| EXPECT_EQ(icon_url, history_handler->icon_url_); |
| EXPECT_EQ(FaviconURL::FAVICON, history_handler->icon_type_); |
| EXPECT_LT(0U, history_handler->bitmap_data_.size()); |
| EXPECT_EQ(page_url, history_handler->page_url_); |
| |
| // Verify NavigationEntry. |
| EXPECT_EQ(icon_url, helper.GetEntry()->GetFavicon().url); |
| EXPECT_TRUE(helper.GetEntry()->GetFavicon().valid); |
| EXPECT_FALSE(helper.GetEntry()->GetFavicon().image.IsEmpty()); |
| } |
| |
| TEST_F(FaviconHandlerTest, UpdateFavicon) { |
| const GURL page_url("http://www.google.com"); |
| const GURL icon_url("http://www.google.com/favicon"); |
| const GURL new_icon_url("http://www.google.com/new_favicon"); |
| |
| TestFaviconHandlerDelegate delegate(web_contents()); |
| Profile* profile = Profile::FromBrowserContext( |
| web_contents()->GetBrowserContext()); |
| TestFaviconHandler helper(page_url, profile, |
| &delegate, FaviconHandler::FAVICON); |
| |
| helper.FetchFavicon(page_url); |
| HistoryRequestHandler* history_handler = helper.history_handler(); |
| // Ensure the data given to history is correct. |
| ASSERT_TRUE(history_handler); |
| EXPECT_EQ(page_url, history_handler->page_url_); |
| EXPECT_EQ(GURL(), history_handler->icon_url_); |
| EXPECT_EQ(chrome::FAVICON, history_handler->icon_type_); |
| |
| SetFaviconBitmapResult(icon_url, &history_handler->history_results_); |
| |
| // Send history response. |
| history_handler->InvokeCallback(); |
| // Verify FaviconHandler status. |
| EXPECT_TRUE(helper.GetEntry()->GetFavicon().valid); |
| EXPECT_EQ(icon_url, helper.GetEntry()->GetFavicon().url); |
| |
| // Reset the history_handler to verify whether new icon is requested from |
| // history. |
| helper.set_history_handler(NULL); |
| |
| // Simulates update with the different favicon url. |
| std::vector<FaviconURL> urls; |
| urls.push_back(FaviconURL(new_icon_url, FaviconURL::FAVICON)); |
| helper.OnUpdateFaviconURL(0, urls); |
| |
| // Verify FaviconHandler status. |
| EXPECT_EQ(1U, helper.urls().size()); |
| ASSERT_TRUE(helper.current_candidate()); |
| ASSERT_EQ(new_icon_url, helper.current_candidate()->icon_url); |
| ASSERT_EQ(FaviconURL::FAVICON, helper.current_candidate()->icon_type); |
| |
| // Favicon should be requested from history. |
| history_handler = helper.history_handler(); |
| ASSERT_TRUE(history_handler); |
| EXPECT_EQ(new_icon_url, history_handler->icon_url_); |
| EXPECT_EQ(FaviconURL::FAVICON, history_handler->icon_type_); |
| EXPECT_EQ(page_url, history_handler->page_url_); |
| |
| // Simulate find icon. |
| SetFaviconBitmapResult(new_icon_url, &history_handler->history_results_); |
| history_handler->InvokeCallback(); |
| |
| // Shouldn't request download favicon |
| EXPECT_FALSE(helper.download_handler()->HasDownload()); |
| |
| // Verify the favicon status. |
| EXPECT_EQ(new_icon_url, helper.GetEntry()->GetFavicon().url); |
| EXPECT_TRUE(helper.GetEntry()->GetFavicon().valid); |
| EXPECT_FALSE(helper.GetEntry()->GetFavicon().image.IsEmpty()); |
| } |
| |
| TEST_F(FaviconHandlerTest, Download2ndFaviconURLCandidate) { |
| const GURL page_url("http://www.google.com"); |
| const GURL icon_url("http://www.google.com/favicon"); |
| const GURL new_icon_url("http://www.google.com/new_favicon"); |
| |
| TestFaviconHandlerDelegate delegate(web_contents()); |
| Profile* profile = Profile::FromBrowserContext( |
| web_contents()->GetBrowserContext()); |
| TestFaviconHandler helper(page_url, profile, |
| &delegate, FaviconHandler::TOUCH); |
| |
| helper.FetchFavicon(page_url); |
| HistoryRequestHandler* history_handler = helper.history_handler(); |
| // Ensure the data given to history is correct. |
| ASSERT_TRUE(history_handler); |
| EXPECT_EQ(page_url, history_handler->page_url_); |
| EXPECT_EQ(GURL(), history_handler->icon_url_); |
| EXPECT_EQ(chrome::TOUCH_PRECOMPOSED_ICON | chrome::TOUCH_ICON, |
| history_handler->icon_type_); |
| |
| // Icon not found. |
| history_handler->history_results_.clear(); |
| // Send history response. |
| history_handler->InvokeCallback(); |
| // Verify FaviconHandler status. |
| EXPECT_FALSE(helper.GetEntry()->GetFavicon().valid); |
| EXPECT_EQ(GURL(), helper.GetEntry()->GetFavicon().url); |
| |
| // Reset the history_handler to verify whether new icon is requested from |
| // history. |
| helper.set_history_handler(NULL); |
| |
| // Simulates update with the different favicon url. |
| std::vector<FaviconURL> urls; |
| urls.push_back(FaviconURL(icon_url, FaviconURL::TOUCH_PRECOMPOSED_ICON)); |
| urls.push_back(FaviconURL(new_icon_url, FaviconURL::TOUCH_ICON)); |
| urls.push_back(FaviconURL(new_icon_url, FaviconURL::FAVICON)); |
| helper.OnUpdateFaviconURL(0, urls); |
| |
| // Verify FaviconHandler status. |
| EXPECT_EQ(2U, helper.urls().size()); |
| ASSERT_TRUE(helper.current_candidate()); |
| ASSERT_EQ(icon_url, helper.current_candidate()->icon_url); |
| ASSERT_EQ(FaviconURL::TOUCH_PRECOMPOSED_ICON, |
| helper.current_candidate()->icon_type); |
| |
| // Favicon should be requested from history. |
| history_handler = helper.history_handler(); |
| ASSERT_TRUE(history_handler); |
| EXPECT_EQ(icon_url, history_handler->icon_url_); |
| EXPECT_EQ(FaviconURL::TOUCH_PRECOMPOSED_ICON, history_handler->icon_type_); |
| EXPECT_EQ(page_url, history_handler->page_url_); |
| |
| // Simulate not find icon. |
| history_handler->history_results_.clear(); |
| history_handler->InvokeCallback(); |
| |
| // Should request download favicon. |
| DownloadHandler* download_handler = helper.download_handler(); |
| EXPECT_TRUE(helper.download_handler()->HasDownload()); |
| |
| // Verify the download request. |
| EXPECT_EQ(icon_url, download_handler->GetImageUrl()); |
| EXPECT_EQ(0, download_handler->GetImageSize()); |
| |
| // Reset the history_handler to verify whether favicon is request from |
| // history. |
| helper.set_history_handler(NULL); |
| // Smulates download failed. |
| download_handler->set_failed(true); |
| download_handler->InvokeCallback(); |
| |
| // Left 1 url. |
| EXPECT_EQ(1U, helper.urls().size()); |
| ASSERT_TRUE(helper.current_candidate()); |
| EXPECT_EQ(new_icon_url, helper.current_candidate()->icon_url); |
| EXPECT_EQ(FaviconURL::TOUCH_ICON, helper.current_candidate()->icon_type); |
| |
| // Favicon should be requested from history. |
| history_handler = helper.history_handler(); |
| ASSERT_TRUE(history_handler); |
| EXPECT_EQ(new_icon_url, history_handler->icon_url_); |
| EXPECT_EQ(FaviconURL::TOUCH_ICON, history_handler->icon_type_); |
| EXPECT_EQ(page_url, history_handler->page_url_); |
| |
| // Reset download handler |
| download_handler->Reset(); |
| |
| // Simulates getting a expired icon from history. |
| SetFaviconBitmapResult(new_icon_url, chrome::TOUCH_ICON, |
| true /* expired */, &history_handler->history_results_); |
| history_handler->InvokeCallback(); |
| |
| // Verify the download request. |
| EXPECT_TRUE(helper.download_handler()->HasDownload()); |
| EXPECT_EQ(new_icon_url, download_handler->GetImageUrl()); |
| EXPECT_EQ(0, download_handler->GetImageSize()); |
| |
| helper.set_history_handler(NULL); |
| |
| // Simulates icon being downloaded. |
| download_handler->InvokeCallback(); |
| |
| // New icon should be saved to history backend. |
| history_handler = helper.history_handler(); |
| ASSERT_TRUE(history_handler); |
| EXPECT_EQ(new_icon_url, history_handler->icon_url_); |
| EXPECT_EQ(FaviconURL::TOUCH_ICON, history_handler->icon_type_); |
| EXPECT_LT(0U, history_handler->bitmap_data_.size()); |
| EXPECT_EQ(page_url, history_handler->page_url_); |
| } |
| |
| TEST_F(FaviconHandlerTest, UpdateDuringDownloading) { |
| const GURL page_url("http://www.google.com"); |
| const GURL icon_url("http://www.google.com/favicon"); |
| const GURL new_icon_url("http://www.google.com/new_favicon"); |
| |
| TestFaviconHandlerDelegate delegate(web_contents()); |
| Profile* profile = Profile::FromBrowserContext( |
| web_contents()->GetBrowserContext()); |
| TestFaviconHandler helper(page_url, profile, |
| &delegate, FaviconHandler::TOUCH); |
| |
| helper.FetchFavicon(page_url); |
| HistoryRequestHandler* history_handler = helper.history_handler(); |
| // Ensure the data given to history is correct. |
| ASSERT_TRUE(history_handler); |
| EXPECT_EQ(page_url, history_handler->page_url_); |
| EXPECT_EQ(GURL(), history_handler->icon_url_); |
| EXPECT_EQ(chrome::TOUCH_PRECOMPOSED_ICON | chrome::TOUCH_ICON, |
| history_handler->icon_type_); |
| |
| // Icon not found. |
| history_handler->history_results_.clear(); |
| // Send history response. |
| history_handler->InvokeCallback(); |
| // Verify FaviconHandler status. |
| EXPECT_FALSE(helper.GetEntry()->GetFavicon().valid); |
| EXPECT_EQ(GURL(), helper.GetEntry()->GetFavicon().url); |
| |
| // Reset the history_handler to verify whether new icon is requested from |
| // history. |
| helper.set_history_handler(NULL); |
| |
| // Simulates update with the different favicon url. |
| std::vector<FaviconURL> urls; |
| urls.push_back(FaviconURL(icon_url, FaviconURL::TOUCH_PRECOMPOSED_ICON)); |
| urls.push_back(FaviconURL(new_icon_url, FaviconURL::TOUCH_ICON)); |
| urls.push_back(FaviconURL(new_icon_url, FaviconURL::FAVICON)); |
| helper.OnUpdateFaviconURL(0, urls); |
| |
| // Verify FaviconHandler status. |
| EXPECT_EQ(2U, helper.urls().size()); |
| ASSERT_TRUE(helper.current_candidate()); |
| ASSERT_EQ(icon_url, helper.current_candidate()->icon_url); |
| ASSERT_EQ(FaviconURL::TOUCH_PRECOMPOSED_ICON, |
| helper.current_candidate()->icon_type); |
| |
| // Favicon should be requested from history. |
| history_handler = helper.history_handler(); |
| ASSERT_TRUE(history_handler); |
| EXPECT_EQ(icon_url, history_handler->icon_url_); |
| EXPECT_EQ(FaviconURL::TOUCH_PRECOMPOSED_ICON, history_handler->icon_type_); |
| EXPECT_EQ(page_url, history_handler->page_url_); |
| |
| // Simulate not find icon. |
| history_handler->history_results_.clear(); |
| history_handler->InvokeCallback(); |
| |
| // Should request download favicon. |
| DownloadHandler* download_handler = helper.download_handler(); |
| EXPECT_TRUE(helper.download_handler()->HasDownload()); |
| |
| // Verify the download request. |
| EXPECT_EQ(icon_url, download_handler->GetImageUrl()); |
| EXPECT_EQ(0, download_handler->GetImageSize()); |
| |
| // Reset the history_handler to verify whether favicon is request from |
| // history. |
| helper.set_history_handler(NULL); |
| const GURL latest_icon_url("http://www.google.com/latest_favicon"); |
| std::vector<FaviconURL> latest_urls; |
| latest_urls.push_back(FaviconURL(latest_icon_url, FaviconURL::TOUCH_ICON)); |
| helper.OnUpdateFaviconURL(0, latest_urls); |
| |
| EXPECT_EQ(1U, helper.urls().size()); |
| EXPECT_EQ(latest_icon_url, helper.current_candidate()->icon_url); |
| EXPECT_EQ(FaviconURL::TOUCH_ICON, helper.current_candidate()->icon_type); |
| |
| // Whether new icon is requested from history |
| history_handler = helper.history_handler(); |
| ASSERT_TRUE(history_handler); |
| EXPECT_EQ(latest_icon_url, history_handler->icon_url_); |
| EXPECT_EQ(FaviconURL::TOUCH_ICON, history_handler->icon_type_); |
| EXPECT_EQ(page_url, history_handler->page_url_); |
| |
| // Reset the history_handler to verify whether favicon is request from |
| // history. |
| // Save the callback for late use. |
| FaviconService::FaviconResultsCallback callback = history_handler->callback_; |
| helper.set_history_handler(NULL); |
| |
| // Simulates download succeed. |
| download_handler->InvokeCallback(); |
| // The downloaded icon should be thrown away as there is favicon update. |
| EXPECT_FALSE(helper.history_handler()); |
| |
| download_handler->Reset(); |
| |
| // Simulates getting the icon from history. |
| scoped_ptr<HistoryRequestHandler> handler; |
| handler.reset(new HistoryRequestHandler(page_url, latest_icon_url, |
| chrome::TOUCH_ICON, callback)); |
| SetFaviconBitmapResult(latest_icon_url, chrome::TOUCH_ICON, |
| false /* expired */, &handler->history_results_); |
| handler->InvokeCallback(); |
| |
| // No download request. |
| EXPECT_FALSE(download_handler->HasDownload()); |
| } |
| |
| TEST_F(FaviconHandlerTest, MultipleFavicon) { |
| const GURL page_url("http://www.google.com"); |
| const GURL icon_url("http://www.google.com/favicon"); |
| const GURL icon_url_small("http://www.google.com/favicon_small"); |
| const GURL icon_url_large("http://www.google.com/favicon_large"); |
| const GURL icon_url_preferred1("http://www.google.com/favicon_preferred1"); |
| const GURL icon_url_preferred2("http://www.google.com/favicon_preferred2"); |
| |
| TestFaviconHandlerDelegate delegate(web_contents()); |
| Profile* profile = Profile::FromBrowserContext( |
| web_contents()->GetBrowserContext()); |
| TestFaviconHandler handler(page_url, profile, |
| &delegate, FaviconHandler::FAVICON); |
| |
| handler.FetchFavicon(page_url); |
| HistoryRequestHandler* history_handler = handler.history_handler(); |
| |
| SetFaviconBitmapResult(icon_url, &history_handler->history_results_); |
| |
| // Send history response. |
| history_handler->InvokeCallback(); |
| |
| // Simulates update with the different favicon url. |
| std::vector<FaviconURL> urls; |
| // Note: the code will stop making requests when an icon matching the |
| // preferred size is found, so icon_url_preferred must be last. |
| urls.push_back(FaviconURL(icon_url_small, FaviconURL::FAVICON)); |
| urls.push_back(FaviconURL(icon_url_large, FaviconURL::FAVICON)); |
| urls.push_back(FaviconURL(icon_url_preferred1, FaviconURL::FAVICON)); |
| urls.push_back(FaviconURL(icon_url_preferred2, FaviconURL::FAVICON)); |
| handler.OnUpdateFaviconURL(0, urls); |
| EXPECT_EQ(4U, handler.image_urls().size()); |
| |
| DownloadHandler* download_handler = handler.download_handler(); |
| |
| // Download the first icon (set not in history). |
| handler.history_handler()->history_results_.clear(); |
| handler.history_handler()->InvokeCallback(); |
| ASSERT_TRUE(download_handler->HasDownload()); |
| EXPECT_EQ(icon_url_small, download_handler->GetImageUrl()); |
| download_handler->SetImageSize(gfx::kFaviconSize / 2); |
| download_handler->InvokeCallback(); |
| EXPECT_EQ(3U, handler.image_urls().size()); |
| |
| // Download the second icon (set not in history). |
| handler.history_handler()->history_results_.clear(); |
| handler.history_handler()->InvokeCallback(); |
| ASSERT_TRUE(download_handler->HasDownload()); |
| EXPECT_EQ(icon_url_large, download_handler->GetImageUrl()); |
| download_handler->SetImageSize(gfx::kFaviconSize * 2); |
| download_handler->InvokeCallback(); |
| EXPECT_EQ(2U, handler.image_urls().size()); |
| |
| // Download the third icon (set not in history). |
| handler.history_handler()->history_results_.clear(); |
| handler.history_handler()->InvokeCallback(); |
| ASSERT_TRUE(download_handler->HasDownload()); |
| EXPECT_EQ(icon_url_preferred1, download_handler->GetImageUrl()); |
| download_handler->SetImageSize(gfx::kFaviconSize); |
| download_handler->InvokeCallback(); |
| // Verify that this was detected as an exact match and image_urls_ is cleared. |
| EXPECT_EQ(0U, handler.image_urls().size()); |
| |
| // Verify correct icon size chosen. |
| EXPECT_EQ(icon_url_preferred1, handler.GetEntry()->GetFavicon().url); |
| EXPECT_TRUE(handler.GetEntry()->GetFavicon().valid); |
| EXPECT_FALSE(handler.GetEntry()->GetFavicon().image.IsEmpty()); |
| EXPECT_EQ(gfx::kFaviconSize, |
| handler.GetEntry()->GetFavicon().image.ToSkBitmap()->width()); |
| } |
| |
| TEST_F(FaviconHandlerTest, FirstFavicon) { |
| const GURL page_url("http://www.google.com"); |
| const GURL icon_url("http://www.google.com/favicon"); |
| const GURL icon_url_preferred1("http://www.google.com/favicon_preferred1"); |
| const GURL icon_url_large("http://www.google.com/favicon_large"); |
| |
| TestFaviconHandlerDelegate delegate(web_contents()); |
| Profile* profile = Profile::FromBrowserContext( |
| web_contents()->GetBrowserContext()); |
| TestFaviconHandler handler(page_url, profile, |
| &delegate, FaviconHandler::FAVICON); |
| |
| handler.FetchFavicon(page_url); |
| HistoryRequestHandler* history_handler = handler.history_handler(); |
| |
| // Set valid icon data. |
| SetFaviconBitmapResult(icon_url, &history_handler->history_results_); |
| |
| // Send history response. |
| history_handler->InvokeCallback(); |
| |
| // Simulates update with the different favicon url. |
| std::vector<FaviconURL> urls; |
| // Note: the code will stop making requests when an icon matching the |
| // preferred size is found, so icon_url_preferred must be last. |
| urls.push_back(FaviconURL(icon_url_preferred1, FaviconURL::FAVICON)); |
| urls.push_back(FaviconURL(icon_url_large, FaviconURL::FAVICON)); |
| handler.OnUpdateFaviconURL(0, urls); |
| EXPECT_EQ(2U, handler.image_urls().size()); |
| |
| DownloadHandler* download_handler = handler.download_handler(); |
| |
| // Download the first icon (set not in history). |
| handler.history_handler()->history_results_.clear(); |
| handler.history_handler()->InvokeCallback(); |
| ASSERT_TRUE(download_handler->HasDownload()); |
| EXPECT_EQ(icon_url_preferred1, download_handler->GetImageUrl()); |
| download_handler->SetImageSize(gfx::kFaviconSize); |
| download_handler->InvokeCallback(); |
| // Verify that this was detected as an exact match and image_urls_ is cleared. |
| EXPECT_EQ(0U, handler.image_urls().size()); |
| |
| // Verify correct icon size chosen. |
| EXPECT_EQ(icon_url_preferred1, handler.GetEntry()->GetFavicon().url); |
| EXPECT_TRUE(handler.GetEntry()->GetFavicon().valid); |
| EXPECT_FALSE(handler.GetEntry()->GetFavicon().image.IsEmpty()); |
| EXPECT_EQ(gfx::kFaviconSize, |
| handler.GetEntry()->GetFavicon().image.ToSkBitmap()->width()); |
| } |
| |
| static BrowserContextKeyedService* BuildFaviconService( |
| content::BrowserContext* profile) { |
| return new FaviconService(NULL); |
| } |
| |
| // Test that Favicon is not requested repeatedly during the same session if |
| // server returns HTTP 404 status. |
| TEST_F(FaviconHandlerTest, UnableToDownloadFavicon) { |
| const GURL missing_icon_url("http://www.google.com/favicon.ico"); |
| const GURL another_icon_url("http://www.youtube.com/favicon.ico"); |
| |
| Profile* profile = Profile::FromBrowserContext( |
| web_contents()->GetBrowserContext()); |
| |
| FaviconServiceFactory::GetInstance()->SetTestingFactory( |
| profile, BuildFaviconService); |
| FaviconService* favicon_service = FaviconServiceFactory::GetForProfile( |
| profile, Profile::IMPLICIT_ACCESS); |
| |
| FaviconTabHelper::CreateForWebContents(web_contents()); |
| FaviconTabHelper* favicon_tab_helper = |
| FaviconTabHelper::FromWebContents(web_contents()); |
| |
| std::vector<SkBitmap> empty_icons; |
| int download_id = 0; |
| |
| // Try to download missing icon. |
| download_id = favicon_tab_helper->StartDownload(missing_icon_url, 0, 0); |
| EXPECT_NE(0, download_id); |
| EXPECT_FALSE(favicon_service->WasUnableToDownloadFavicon(missing_icon_url)); |
| |
| // Report download failure with HTTP 503 status. |
| favicon_tab_helper->DidDownloadFavicon(download_id, 503, missing_icon_url, |
| 0, empty_icons); |
| // Icon is not marked as UnableToDownload as HTTP status is not 404. |
| EXPECT_FALSE(favicon_service->WasUnableToDownloadFavicon(missing_icon_url)); |
| |
| // Try to download again. |
| download_id = favicon_tab_helper->StartDownload(missing_icon_url, 0, 0); |
| EXPECT_NE(0, download_id); |
| EXPECT_FALSE(favicon_service->WasUnableToDownloadFavicon(missing_icon_url)); |
| |
| // Report download failure with HTTP 404 status. |
| favicon_tab_helper->DidDownloadFavicon(download_id, 404, missing_icon_url, |
| 0, empty_icons); |
| // Icon is marked as UnableToDownload. |
| EXPECT_TRUE(favicon_service->WasUnableToDownloadFavicon(missing_icon_url)); |
| |
| // Try to download again. |
| download_id = favicon_tab_helper->StartDownload(missing_icon_url, 0, 0); |
| // Download is not started and Icon is still marked as UnableToDownload. |
| EXPECT_EQ(0, download_id); |
| EXPECT_TRUE(favicon_service->WasUnableToDownloadFavicon(missing_icon_url)); |
| |
| // Try to download another icon. |
| download_id = favicon_tab_helper->StartDownload(another_icon_url, 0, 0); |
| // Download is started as another icon URL is not same as missing_icon_url. |
| EXPECT_NE(0, download_id); |
| EXPECT_FALSE(favicon_service->WasUnableToDownloadFavicon(another_icon_url)); |
| |
| // Clear the list of missing icons. |
| favicon_service->ClearUnableToDownloadFavicons(); |
| EXPECT_FALSE(favicon_service->WasUnableToDownloadFavicon(missing_icon_url)); |
| EXPECT_FALSE(favicon_service->WasUnableToDownloadFavicon(another_icon_url)); |
| |
| // Try to download again. |
| download_id = favicon_tab_helper->StartDownload(missing_icon_url, 0, 0); |
| EXPECT_NE(0, download_id); |
| // Report download success with HTTP 200 status. |
| favicon_tab_helper->DidDownloadFavicon(download_id, 200, missing_icon_url, |
| 0, empty_icons); |
| // Icon is not marked as UnableToDownload as HTTP status is not 404. |
| EXPECT_FALSE(favicon_service->WasUnableToDownloadFavicon(missing_icon_url)); |
| } |
| |
| } // namespace. |