| //////////////////////////////////////////////////////////////////////////////// |
| // checkstyle: Checks Java source code for adherence to a set of rules. |
| // Copyright (C) 2001-2017 the original author or authors. |
| // |
| // This library is free software; you can redistribute it and/or |
| // modify it under the terms of the GNU Lesser General Public |
| // License as published by the Free Software Foundation; either |
| // version 2.1 of the License, or (at your option) any later version. |
| // |
| // This library is distributed in the hope that it will be useful, |
| // but WITHOUT ANY WARRANTY; without even the implied warranty of |
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU |
| // Lesser General Public License for more details. |
| // |
| // You should have received a copy of the GNU Lesser General Public |
| // License along with this library; if not, write to the Free Software |
| // Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA |
| //////////////////////////////////////////////////////////////////////////////// |
| |
| package com.puppycrawl.tools.checkstyle.checks.coding; |
| |
| import static com.puppycrawl.tools.checkstyle.checks.coding.ModifiedControlVariableCheck.MSG_KEY; |
| import static org.junit.Assert.assertTrue; |
| |
| import java.io.File; |
| import java.util.Collection; |
| import java.util.Optional; |
| import java.util.Set; |
| |
| import org.junit.Assert; |
| import org.junit.Test; |
| |
| import com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport; |
| import com.puppycrawl.tools.checkstyle.DefaultConfiguration; |
| import com.puppycrawl.tools.checkstyle.api.DetailAST; |
| import com.puppycrawl.tools.checkstyle.api.TokenTypes; |
| import com.puppycrawl.tools.checkstyle.internal.utils.TestUtil; |
| import com.puppycrawl.tools.checkstyle.utils.CommonUtils; |
| |
| public class ModifiedControlVariableCheckTest |
| extends AbstractModuleTestSupport { |
| @Override |
| protected String getPackageLocation() { |
| return "com/puppycrawl/tools/checkstyle/checks/coding/modifiedcontrolvariable"; |
| } |
| |
| @Test |
| public void testModifiedControlVariable() throws Exception { |
| final DefaultConfiguration checkConfig = |
| createModuleConfig(ModifiedControlVariableCheck.class); |
| final String[] expected = { |
| "14:14: " + getCheckMessage(MSG_KEY, "i"), |
| "17:15: " + getCheckMessage(MSG_KEY, "i"), |
| "20:37: " + getCheckMessage(MSG_KEY, "i"), |
| "21:17: " + getCheckMessage(MSG_KEY, "i"), |
| "49:15: " + getCheckMessage(MSG_KEY, "s"), |
| "56:14: " + getCheckMessage(MSG_KEY, "m"), |
| "67:15: " + getCheckMessage(MSG_KEY, "i"), |
| "68:15: " + getCheckMessage(MSG_KEY, "k"), |
| }; |
| verify(checkConfig, getPath("InputModifiedControlVariableBothForLoops.java"), expected); |
| } |
| |
| @Test |
| public void testEnhancedForLoopVariableTrue() throws Exception { |
| final DefaultConfiguration checkConfig = |
| createModuleConfig(ModifiedControlVariableCheck.class); |
| checkConfig.addAttribute("skipEnhancedForLoopVariable", "true"); |
| |
| final String[] expected = CommonUtils.EMPTY_STRING_ARRAY; |
| verify(checkConfig, getPath("InputModifiedControlVariableEnhancedForLoopVariable.java"), |
| expected); |
| } |
| |
| @Test |
| public void testEnhancedForLoopVariableFalse() throws Exception { |
| final DefaultConfiguration checkConfig = |
| createModuleConfig(ModifiedControlVariableCheck.class); |
| |
| final String[] expected = { |
| "9:18: " + getCheckMessage(MSG_KEY, "line"), |
| }; |
| verify(checkConfig, getPath("InputModifiedControlVariableEnhancedForLoopVariable.java"), |
| expected); |
| } |
| |
| @Test |
| public void testEnhancedForLoopVariable2() throws Exception { |
| final DefaultConfiguration checkConfig = |
| createModuleConfig(ModifiedControlVariableCheck.class); |
| checkConfig.addAttribute("skipEnhancedForLoopVariable", "true"); |
| |
| final String[] expected = { |
| "14:18: " + getCheckMessage(MSG_KEY, "i"), |
| }; |
| verify(checkConfig, getPath("InputModifiedControlVariableEnhancedForLoopVariable2.java"), |
| expected); |
| } |
| |
| @Test |
| public void testTokensNotNull() { |
| final ModifiedControlVariableCheck check = new ModifiedControlVariableCheck(); |
| Assert.assertNotNull("Acceptable tokens should not be null", check.getAcceptableTokens()); |
| Assert.assertNotNull("Default tokens should not be null", check.getDefaultTokens()); |
| Assert.assertNotNull("Required tokens should not be null", check.getRequiredTokens()); |
| } |
| |
| @Test |
| public void testImproperToken() { |
| final ModifiedControlVariableCheck check = new ModifiedControlVariableCheck(); |
| |
| final DetailAST classDefAst = new DetailAST(); |
| classDefAst.setType(TokenTypes.CLASS_DEF); |
| |
| try { |
| check.visitToken(classDefAst); |
| Assert.fail("IllegalStateException is expected"); |
| } |
| catch (IllegalStateException ex) { |
| // it is OK |
| } |
| |
| try { |
| check.leaveToken(classDefAst); |
| Assert.fail("IllegalStateException is expected"); |
| } |
| catch (IllegalStateException ex) { |
| // it is OK |
| } |
| } |
| |
| /** |
| * We cannot reproduce situation when visitToken is called and leaveToken is not. |
| * So, we have to use reflection to be sure that even in such situation |
| * state of the field will be cleared. |
| * |
| * @throws Exception when code tested throws exception |
| */ |
| @Test |
| @SuppressWarnings("unchecked") |
| public void testClearState() throws Exception { |
| final ModifiedControlVariableCheck check = new ModifiedControlVariableCheck(); |
| final Optional<DetailAST> methodDef = TestUtil.findTokenInAstByPredicate( |
| TestUtil.parseFile(new File( |
| getPath("InputModifiedControlVariableEnhancedForLoopVariable.java"))), |
| ast -> ast.getType() == TokenTypes.OBJBLOCK); |
| |
| assertTrue("Ast should contain METHOD_DEF", methodDef.isPresent()); |
| assertTrue("State is not cleared on beginTree", |
| TestUtil.isStatefulFieldClearedDuringBeginTree(check, methodDef.get(), |
| "variableStack", |
| variableStack -> ((Collection<Set<String>>) variableStack).isEmpty())); |
| } |
| } |