commit 23e859dfd2e095bd71be0290b7c99f0016c6bf4e
author Treehugger Robot <treehugger-gerrit@google.com> Wed Mar 28 13:02:01 2018 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Wed Mar 28 13:02:01 2018 +0000
tree 9b034c816c1c418f0645920d94bb3d6c1af5662f
parent 70d9b6a2d82bddbc02326c5998d37be82b1bc779
parent 943238191685c85367fb0c51fb0a5f124b361876

Merge "Throw ShortBufferException in RSA CipherSpi."

bcprov/src/main/java/org/bouncycastle/jcajce/provider/asymmetric/rsa/CipherSpi.java

diff --git a/bcprov/src/main/java/org/bouncycastle/jcajce/provider/asymmetric/rsa/CipherSpi.java b/bcprov/src/main/java/org/bouncycastle/jcajce/provider/asymmetric/rsa/CipherSpi.java
index b7966ef..5154a20 100644
--- a/bcprov/src/main/java/org/bouncycastle/jcajce/provider/asymmetric/rsa/CipherSpi.java
+++ b/bcprov/src/main/java/org/bouncycastle/jcajce/provider/asymmetric/rsa/CipherSpi.java
@@ -18,6 +18,7 @@
 import javax.crypto.Cipher;
 import javax.crypto.IllegalBlockSizeException;
 import javax.crypto.NoSuchPaddingException;
+import javax.crypto.ShortBufferException;
 import javax.crypto.spec.OAEPParameterSpec;
 import javax.crypto.spec.PSource;
 
@@ -499,8 +500,14 @@
         int     inputLen,
         byte[]  output,
         int     outputOffset) 
-        throws IllegalBlockSizeException, BadPaddingException
+        throws IllegalBlockSizeException, BadPaddingException, ShortBufferException
     {
+        // BEGIN Android-added: Throw ShortBufferException when given a short buffer.
+        if (engineGetOutputSize(inputLen) > output.length - outputOffset)
+        {
+            throw new ShortBufferException("output buffer too short for input.");
+        }
+        // END Android-added: Throw ShortBufferException when given a short buffer.
         if (input != null)
         {
             bOut.write(input, inputOffset, inputLen);