commit d494bf0220b56b302497738b294d836da2415df1
author Adam Langley <agl@chromium.org> Fri Mar 30 14:28:51 2018 -0700
committer Adam Vartanian <flooey@google.com> Wed Apr 04 10:19:38 2018 +0100
tree f5372d2dfe0d2083f58884a42bd1c8f469ce4d52
parent 3ef76b39e2b1b3ce091b518cb4f4b9f7a9d3abeb

Cherry-pick Fiat P-256 fix.

This change cherry-picks BoringSSL's 5fca61391822252baf3dc37529ba02f6d7611acf:

    Fix typo in point_add.

    Rather than writing the answer into the output, it wrote it into some
    awkwardly-named temporaries. Thanks to Daniel Hirche for reporting this
    issue!

    Bug: chromium:825273
    Reviewed-on: https://boringssl-review.googlesource.com/26785
    Reviewed-by: Adam Langley <agl@google.com>

Test: deployed internally without issues and in Chromium trunk.

(cherry picked from commit 4613b5a4482c911e9b4ab5fe1ef8ea5321070b67)

Bug: 77520979
Change-Id: I0adb747694d745dc8583e402a270f8113fbe1d9c
Merged-In: Ib055444e3e06fbcce8b07c2b9e8355f98bde0786

src/third_party/fiat/p256.c

diff --git a/src/third_party/fiat/p256.c b/src/third_party/fiat/p256.c
index f1d5316..2fe2f86 100644
--- a/src/third_party/fiat/p256.c
+++ b/src/third_party/fiat/p256.c
@@ -1120,7 +1120,7 @@
   limb_t yneq = fe_nz(r);
 
   if (!xneq && !yneq && z1nz && z2nz) {
-    point_double(x_out, y_out, z_out, x1, y1, z1);
+    point_double(x3, y3, z3, x1, y1, z1);
     return;
   }