Fix redundant null check on calling free()
diff --git a/compat/hidd.c b/compat/hidd.c
index 88944cf..2dae3a7 100644
--- a/compat/hidd.c
+++ b/compat/hidd.c
@@ -341,8 +341,7 @@
err = ioctl(ctl, HIDPCONNADD, &req);
error:
- if (req.rd_data)
- free(req.rd_data);
+ free(req.rd_data);
return err;
}
diff --git a/tools/bccmd.c b/tools/bccmd.c
index 5cb9255..ca9302c 100644
--- a/tools/bccmd.c
+++ b/tools/bccmd.c
@@ -1226,8 +1226,7 @@
if (transport_open(transport, device, bcsp_rate) < 0)
exit(1);
- if (device)
- free(device);
+ free(device);
for (i = 0; commands[i].str; i++) {
if (strcasecmp(commands[i].str, argv[0]))
diff --git a/tools/hciattach_ath3k.c b/tools/hciattach_ath3k.c
index 728e660..803cf46 100644
--- a/tools/hciattach_ath3k.c
+++ b/tools/hciattach_ath3k.c
@@ -148,8 +148,8 @@
return err;
err = read_ps_event(event, HCI_PS_CMD_OCF);
- if (event)
- free(event);
+
+ free(event);
return err;
}
@@ -493,8 +493,7 @@
err = read_ps_event(event, HCI_PS_CMD_OCF);
- if (event)
- free(event);
+ free(event);
return err;
}
@@ -623,8 +622,7 @@
if (read_ps_event(event, HCI_PS_CMD_OCF) >= 0)
err = -EILSEQ;
- if (!event)
- free(event);
+ free(event);
return err;
}
@@ -667,8 +665,7 @@
*code = reg;
cleanup:
- if (event)
- free(event);
+ free(event);
return err;
}
@@ -709,8 +706,7 @@
*build_version = status;
cleanup:
- if (event)
- free(event);
+ free(event);
return err;
}
@@ -768,8 +764,7 @@
err = read_ps_event(event, HCI_PS_CMD_OCF);
- if (event)
- free(event);
+ free(event);
return err;
}
