commit c869a17c7dd15cba61dbd33edab0e5048d30bc93
author UebelAndre <github@uebelandre.com> Mon Apr 24 13:29:45 2023 -0700
committer GitHub <noreply@github.com> Mon Apr 24 20:29:45 2023 +0000
tree 12aa065c82bd5734878af7c2e5fa04fab0301ccc
parent 24b9dea4fe063f4d6381c49a900aa2a34e6809f8

Fix regression in building zlib (#1935)

crate_universe/3rdparty/BUILD.zlib.bazel

diff --git a/crate_universe/3rdparty/BUILD.zlib.bazel b/crate_universe/3rdparty/BUILD.zlib.bazel
index 1505481..687375d 100644
--- a/crate_universe/3rdparty/BUILD.zlib.bazel
+++ b/crate_universe/3rdparty/BUILD.zlib.bazel
@@ -31,6 +31,12 @@
     for hdr in _ZLIB_HEADERS
 ]
 
+_COMMON_COPTS = [
+    "-Wno-deprecated-non-prototype",
+    "-Wno-unused-variable",
+    "-Wno-implicit-function-declaration",
+]
+
 cc_library(
     name = "zlib",
     srcs = [
@@ -55,12 +61,15 @@
     ] + _ZLIB_HEADERS,
     hdrs = _ZLIB_PREFIXED_HEADERS,
     copts = select({
+        "@platforms//os:linux": [
+            # Required for opt builds to avoid
+            # `libzlib.a(crc32.o): requires unsupported dynamic reloc 11; recompile with -fPIC`
+            "-fPIC",
+            # Silence all warnings
+            "-w",
+        ] + _COMMON_COPTS,
         "@platforms//os:windows": [],
-        "//conditions:default": [
-            "-Wno-deprecated-non-prototype",
-            "-Wno-unused-variable",
-            "-Wno-implicit-function-declaration",
-        ],
+        "//conditions:default": _COMMON_COPTS,
     }),
     includes = ["zlib/include/"],
     visibility = ["//visibility:public"],