autotest: increase "download" timeout to 1200 sec
Timeouts started showing up once this CL landed:
https://chromium-review.googlesource.com/c/502369/
CL502369 adds O_DSYNC to update_engine and this is required
to fix OOM issues with "small mem" (ie gale; 512MB RAM) devices.
OOM reports doubled while any new release was pushed.
CL502369 has two side effects because writes are no longer asynchronous:
1) slightly slower write throughput
2) timeout now covers ALL data reaching media.
(1) is primarily due to not "pipelining" preparing (uncompressing) data
to be written and having to wait for the current write() to complete.
(2) isn't as certain but I expect "download completed" event to be
issued when the last write() completes. Thus if write() is asynchronous,
the storage device is "slow" (perhaps even busy with other activity),
quite a bit of data could still be in the linux kernel buffer cache
when the "download finished" event is sent back to autotest.
However, we _want_ slower throughput on consumer devices in order
to avoid competing with other activities (like video playback or
hangouts) during an update. While this is "suboptimal" for lab
provisioning. We will have to follow up with additional changes
improve update performance again in the Chrome OS Test lab.
BUG=chromium:731214
TEST=none (will try to run cbuildbot - no promises)
Change-Id: Ia0f7446d6639f06423de00b0650f6b2ce30383b7
Reviewed-on: https://chromium-review.googlesource.com/530054
Commit-Ready: Grant Grundler <grundler@chromium.org>
Tested-by: Grant Grundler <grundler@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Grant Grundler <grundler@chromium.org>
diff --git a/server/site_tests/autoupdate_EndToEndTest/autoupdate_EndToEndTest.py b/server/site_tests/autoupdate_EndToEndTest/autoupdate_EndToEndTest.py
index fa1a8e3..faf4540 100755
--- a/server/site_tests/autoupdate_EndToEndTest/autoupdate_EndToEndTest.py
+++ b/server/site_tests/autoupdate_EndToEndTest/autoupdate_EndToEndTest.py
@@ -1444,7 +1444,8 @@
# TODO(sosa): Investigate why this needs to be so long (this used to be
# 120 and regressed).
_WAIT_FOR_DOWNLOAD_STARTED_SECONDS = 4 * 60
- _WAIT_FOR_DOWNLOAD_COMPLETED_SECONDS = 10 * 60
+ # See https://crbug.com/731214 before changing WAIT_FOR_DOWNLOAD
+ _WAIT_FOR_DOWNLOAD_COMPLETED_SECONDS = 20 * 60
_WAIT_FOR_UPDATE_COMPLETED_SECONDS = 4 * 60
_WAIT_FOR_UPDATE_CHECK_AFTER_REBOOT_SECONDS = 15 * 60
_DEVSERVER_HOSTLOG_REQUEST_TIMEOUT_SECONDS = 30
