commit 55536f09e1ab6ac78c8583052de0a309e1c3d42d
author Jeremy Bettis <jbettis@google.com> Wed Mar 03 15:10:32 2021 -0700
committer Commit Bot <commit-bot@chromium.org> Thu Mar 04 03:02:54 2021 +0000
tree 3f6ce5e78a728c2b9b826f4b0fbfe6070353de2d
parent c81f9be58021082a35a8b60b5ac4cd8b28daa133

firmware_ECWatchdog: Increase spin-wait delay.

For some boards, this test fails intermittently, and I believe it is
because there isn't enough time in the spin-wait delay for 2 watchdog
events to happen.

BUG=b:181704896
TEST=Ran test on phaser, which fails sometimes.

Change-Id: I204525a423ab4c6f7fc4629d7bdc34fe6f20fa58
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/2733433
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Philip Chen <philipchen@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>

server/site_tests/firmware_ECWatchdog/firmware_ECWatchdog.py

diff --git a/server/site_tests/firmware_ECWatchdog/firmware_ECWatchdog.py b/server/site_tests/firmware_ECWatchdog/firmware_ECWatchdog.py
index 0817b5c..91b5de4 100644
--- a/server/site_tests/firmware_ECWatchdog/firmware_ECWatchdog.py
+++ b/server/site_tests/firmware_ECWatchdog/firmware_ECWatchdog.py
@@ -15,8 +15,10 @@
     version = 1
 
 
-    # Delay of spin-wait in ms. Should be long enough to trigger watchdog reset.
-    WATCHDOG_DELAY = 3000
+    # Delay of spin-wait in ms. Must be at least 2x CONFIG_WATCHDOG_PERIOD_MS
+    # of the slowest board that this test will run against. Currently it
+    # appears that all ChromeOS ECs set CONFIG_WATCHDOG_PERIOD_MS to 1600.
+    WATCHDOG_DELAY = 1600 * 2 + 500
 
     # Delay of EC power on.
     EC_BOOT_DELAY = 1000