autotest: make slave delay check more robust
This script has been failing unlogged for a year, being called without
any list of replicas. Make this not cause errors, and log a warning.
BUG=chromium:682489
TEST=ran script with empty list
Change-Id: I74359326188d1c4603a6999cf99e73f963858949
Reviewed-on: https://chromium-review.googlesource.com/1022954
Commit-Ready: Jacob Kopczynski <jkop@chromium.org>
Tested-by: Jacob Kopczynski <jkop@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>
diff --git a/site_utils/check_slave_db_delay.py b/site_utils/check_slave_db_delay.py
index 0e29523..face8aa 100755
--- a/site_utils/check_slave_db_delay.py
+++ b/site_utils/check_slave_db_delay.py
@@ -70,6 +70,7 @@
"""
parser = argparse.ArgumentParser()
parser.add_argument('-r', '--replicas', nargs='+',
+ default=[],
help='IP addresses of readonly replicas of TKO.')
parser.add_argument('-l', '--logfile', type=str,
default=None,
@@ -95,8 +96,11 @@
logging.info('Start checking Seconds_Behind_Master of slave databases')
- for replica in options.replicas:
- check_delay(replica, global_db_user, global_db_password)
+ if not options.replicas:
+ logging.warning('No replicas checked.')
+ else:
+ for replica in options.replicas:
+ check_delay(replica, global_db_user, global_db_password)
slaves = server_manager_utils.get_servers(
role='database_slave', status='primary')
