commit fe38f8892a2e99cfb6b941c48a57e1415d7ab223
author Stefan Bodewig <stefan.bodewig@innoq.com> Thu May 17 21:04:34 2018 +0200
committer Stefan Bodewig <stefan.bodewig@innoq.com> Wed May 30 10:06:07 2018 +0200
tree daeeef4169d1af681f93480dd0d808cf88d60e1c
parent 0aeeb46737c5e4a5d8c21c26e6793956b0296cda

remove IPv4 checks that are unnnecessary due to matching regex

src/main/java/org/apache/commons/io/FilenameUtils.java

diff --git a/src/main/java/org/apache/commons/io/FilenameUtils.java b/src/main/java/org/apache/commons/io/FilenameUtils.java
index be52ea0..1493e43 100644
--- a/src/main/java/org/apache/commons/io/FilenameUtils.java
+++ b/src/main/java/org/apache/commons/io/FilenameUtils.java
@@ -1530,20 +1530,9 @@
         }
 
         // verify that address subgroups are legal
-        for (int i = 1; i < 5; i++) {
+        for (int i = 1; i <= 4; i++) {
             String ipSegment = m.group(i);
-            if (ipSegment == null || ipSegment.length() == 0) {
-                return false;
-            }
-
-            int iIpSegment = 0;
-
-            try {
-                iIpSegment = Integer.parseInt(ipSegment);
-            } catch(NumberFormatException e) {
-                return false;
-            }
-
+            int iIpSegment = Integer.parseInt(ipSegment);
             if (iIpSegment > IPV4_MAX_OCTET_VALUE) {
                 return false;
             }