commit f99426400493a4623d55d59a9c51cfee87b30bbf
author Shahbaz Youssefi <syoussefi@chromium.org> Tue Aug 03 11:45:31 2021 -0400
committer Angle LUCI CQ <angle-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Aug 03 19:11:24 2021 +0000
tree 540dfc4eeb4907202d8a7acaaee418f97e4942c7
parent a8f9b79a14b923e925d4aecb5eb5d973f92ae4e1

Translator: Fix fuzzer crashing on assertion

An assertion was triggered by the fuzzer when generating an invalid
shader that redeclared a built-in.  The assertion itself was unnecessary
and the parser would appropriately generate an error if that assertion
would have fired.

Bug: angleproject:4889
Bug: chromium:1235229
Change-Id: I294b2e329491c75d4e87622b602570252555869f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3063910
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

src/compiler/translator/ParseContext.cpp

diff --git a/src/compiler/translator/ParseContext.cpp b/src/compiler/translator/ParseContext.cpp
index 0d6f45c..ae7e81c 100644
--- a/src/compiler/translator/ParseContext.cpp
+++ b/src/compiler/translator/ParseContext.cpp
@@ -1257,7 +1257,7 @@
             symbolType = SymbolType::BuiltIn;
             break;
         default:
-            ASSERT(!IsRedeclarableBuiltIn(identifier));
+            break;
     }
 
     (*variable) = new TVariable(&symbolTable, identifier, type, symbolType);