commit e5276ca37ccb036363b1c02ac8b76a49c6cb2b1f
author Gert Wollny <gert.wollny@collabora.com> Sat Jun 12 17:25:12 2021 +0200
committer Gert Wollny <gert.wollny@collabora.com> Thu Jun 24 08:20:09 2021 +0000
tree c99db3b0576ae6aa3900971fc341257bc24b2f46
parent c8677c730c2975f4a5cb212ba79f252ba8ae07d8

Capture: Add capturing of framebuffer and renderbuffer IDs

Also enable the FramebufferObjectTest/* tests

Bug: angleproject:6058
Change-Id: Ia82c935e614ccc4ad2c69ccc08544ce2d302fbca
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2957954
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

src/libANGLE/capture/capture_gles_ext_params.cpp

diff --git a/src/libANGLE/capture/capture_gles_ext_params.cpp b/src/libANGLE/capture/capture_gles_ext_params.cpp
index 81c63f0..b3ad202 100644
--- a/src/libANGLE/capture/capture_gles_ext_params.cpp
+++ b/src/libANGLE/capture/capture_gles_ext_params.cpp
@@ -3082,7 +3082,7 @@
                                                      const FramebufferID *framebuffers,
                                                      ParamCapture *paramCapture)
 {
-    UNIMPLEMENTED();
+    CaptureMemory(framebuffers, n * sizeof(GLuint), paramCapture);
 }
 
 void CaptureDeleteRenderbuffersOES_renderbuffersPacked(const State &glState,
@@ -3091,7 +3091,7 @@
                                                        const RenderbufferID *renderbuffers,
                                                        ParamCapture *paramCapture)
 {
-    UNIMPLEMENTED();
+    CaptureMemory(renderbuffers, n * sizeof(GLuint), paramCapture);
 }
 
 void CaptureGenFramebuffersOES_framebuffersPacked(const State &glState,
@@ -3100,7 +3100,7 @@
                                                   FramebufferID *framebuffers,
                                                   ParamCapture *paramCapture)
 {
-    UNIMPLEMENTED();
+    CaptureGenHandles(n, framebuffers, paramCapture);
 }
 
 void CaptureGenRenderbuffersOES_renderbuffersPacked(const State &glState,
@@ -3109,7 +3109,7 @@
                                                     RenderbufferID *renderbuffers,
                                                     ParamCapture *paramCapture)
 {
-    UNIMPLEMENTED();
+    CaptureGenHandles(n, renderbuffers, paramCapture);
 }
 
 void CaptureGetFramebufferAttachmentParameterivOES_params(const State &glState,
@@ -3120,7 +3120,7 @@
                                                           GLint *params,
                                                           ParamCapture *paramCapture)
 {
-    UNIMPLEMENTED();
+    CaptureMemory(params, sizeof(GLint), paramCapture);
 }
 
 void CaptureGetRenderbufferParameterivOES_params(const State &glState,
@@ -3130,7 +3130,7 @@
                                                  GLint *params,
                                                  ParamCapture *paramCapture)
 {
-    UNIMPLEMENTED();
+    CaptureMemory(params, sizeof(GLint), paramCapture);
 }
 
 void CaptureGetProgramBinaryOES_length(const State &glState,

src/tests/capture_replay_tests/capture_replay_expectations.txt

diff --git a/src/tests/capture_replay_tests/capture_replay_expectations.txt b/src/tests/capture_replay_tests/capture_replay_expectations.txt
index 08882ca..ea6e5f6 100644
--- a/src/tests/capture_replay_tests/capture_replay_expectations.txt
+++ b/src/tests/capture_replay_tests/capture_replay_expectations.txt
@@ -92,11 +92,6 @@
 # Compile failed tests
 RobustResourceInitTest.SurfaceInitializedAfterSwap/*
 
-# ES1 crashed tests
-FramebufferObjectTest.FramebufferObject/*
-FramebufferObjectTest.RenderbufferObject/*
-FramebufferObjectTest.TextureObjectDifferentFormats/*
-
 # ES1 comparison failed tests
 BootAnimationTest.DefaultBootAnimation/*