commit d7460c7e3769793f62749c137fe7c82e7eda5cc9
author Jamie Madill <jmadill@chromium.org> Tue Jan 21 16:38:14 2014 -0500
committer Jamie Madill <jmadill@chromium.org> Thu Jan 23 21:22:50 2014 +0000
tree 5f2069fc2627d34cef41f5d07b908f5263e95aa9
parent 1fc7e2c5961207aa2bd1a99978d661b4cbcbf144

Fix gl::ValidTextureTarget to work on all enum values.

Change-Id: I347583ae1adcaaae9feeb1276f6150ceb8739885
Reviewed-on: https://chromium-review.googlesource.com/181557
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

src/libGLESv2/validationES.cpp

diff --git a/src/libGLESv2/validationES.cpp b/src/libGLESv2/validationES.cpp
index c688fcd..9f62b95 100644
--- a/src/libGLESv2/validationES.cpp
+++ b/src/libGLESv2/validationES.cpp
@@ -23,15 +23,19 @@
 
 bool ValidTextureTarget(const Context *context, GLenum target)
 {
-    if (context->getClientVersion() < 3)
+    switch (target)
     {
-        if (target == GL_TEXTURE_3D || target == GL_TEXTURE_2D_ARRAY)
-        {
-            return false;
-        }
-    }
+      case GL_TEXTURE_2D:
+      case GL_TEXTURE_CUBE_MAP:
+        return true;
 
-    return true;
+      case GL_TEXTURE_3D:
+      case GL_TEXTURE_2D_ARRAY:
+        return (context->getClientVersion() >= 3);
+
+      default:
+        return false;
+    }
 }
 
 bool ValidFramebufferTarget(GLenum target)