commit b5576b67bcf5ca9ed26590eb5c66b38526785583
author Michael Spang <spang@chromium.org> Fri Feb 21 20:44:42 2020 -0500
committer Commit Bot <commit-bot@chromium.org> Sat Feb 22 20:36:26 2020 +0000
tree 2213de29b845ea914f155725e286ea73c745cbb9
parent a741abb983624cfbf62b54f28a19f8ef5175658d

Vulkan: Fix pipeline stage when waiting on a semaphore

Using VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT in pWaitDstStageMask doesn't
create a dependency, since no memory is accessed during that stage.
Switch to VK_PIPELINE_STAGE_ALL_COMMANDS_BIT to synchronize all accesses.

This fixes flickering observed in WebGL on ARM GPUs when composited using
Vulkan in Chromium.

Bug: angleproject:4422
Change-Id: I37da461c03dbf52f8658408b159c2b173cccd0b3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068906
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>

src/libANGLE/renderer/vulkan/ContextVk.cpp

diff --git a/src/libANGLE/renderer/vulkan/ContextVk.cpp b/src/libANGLE/renderer/vulkan/ContextVk.cpp
index 56bb252..df95ad8 100644
--- a/src/libANGLE/renderer/vulkan/ContextVk.cpp
+++ b/src/libANGLE/renderer/vulkan/ContextVk.cpp
@@ -126,8 +126,7 @@
 
     if (waitSemaphoreStageMasks->size() < waitSemaphores.size())
     {
-        waitSemaphoreStageMasks->resize(waitSemaphores.size(),
-                                        VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT);
+        waitSemaphoreStageMasks->resize(waitSemaphores.size(), VK_PIPELINE_STAGE_ALL_COMMANDS_BIT);
     }
 
     submitInfo->waitSemaphoreCount = static_cast<uint32_t>(waitSemaphores.size());