commit 9edc4686a2a4592f08c0894f666f75408aa2a85a
author Charlie Lao <cclao@google.com> Thu Jan 26 09:26:41 2023 -0800
committer Angle LUCI CQ <angle-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jan 26 18:55:59 2023 +0000
tree 78488216d5f7c64dc208cd6aa3fc871481304f0b
parent 0133b6f186fae5b188eafe7ad35c4a664e599853

Vulkan: Fix SharedFence::mRefCountedFence leak

This was introduced in crrev.com/c/4159871. mRefCountedFence itself is
not been properly deleted.

Bug: b/261106868
Change-Id: I91b620d96064cc0a8a155327336881d26a5bc33b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4198475
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Auto-Submit: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

src/libANGLE/renderer/vulkan/CommandProcessor.cpp

diff --git a/src/libANGLE/renderer/vulkan/CommandProcessor.cpp b/src/libANGLE/renderer/vulkan/CommandProcessor.cpp
index 5714810..5b51be8 100644
--- a/src/libANGLE/renderer/vulkan/CommandProcessor.cpp
+++ b/src/libANGLE/renderer/vulkan/CommandProcessor.cpp
@@ -207,8 +207,12 @@
         if (!mRefCountedFence->isReferenced())
         {
             mRefCountedFence->get().destroy(device);
+            SafeDelete(mRefCountedFence);
         }
-        mRefCountedFence = nullptr;
+        else
+        {
+            mRefCountedFence = nullptr;
+        }
     }
 }
 
@@ -220,8 +224,13 @@
         if (!mRefCountedFence->isReferenced())
         {
             mRecycler->recycle(std::move(mRefCountedFence->get()));
+            ASSERT(!mRefCountedFence->get().valid());
+            SafeDelete(mRefCountedFence);
         }
-        mRefCountedFence = nullptr;
+        else
+        {
+            mRefCountedFence = nullptr;
+        }
     }
 }