commit 73cc578b49d0c67843b6b5f44fe264c1325c9fe3
author Amirali Abdolrashidi <abdolrashidi@google.com> Mon Jan 30 12:22:20 2023 -0800
committer Angle LUCI CQ <angle-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jan 30 21:30:06 2023 +0000
tree 48e1ec79cd39b53901b94782721fc969910c4056
parent b8bfe6f6c04a6cf4fac81f0363ad23a0b92b22f2

Disable mutable texture upload due to render issue

* In some applications, enabling this feature can lead to incorrect
rendering of some textures. This CL will disable this feature for now.

Bug: b/264143971
Change-Id: I69933bbc3caaf71d03645b4c0b0424b9173ee585
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4205049
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>

src/libANGLE/renderer/vulkan/RendererVk.cpp

diff --git a/src/libANGLE/renderer/vulkan/RendererVk.cpp b/src/libANGLE/renderer/vulkan/RendererVk.cpp
index 075228d..6c6b194 100644
--- a/src/libANGLE/renderer/vulkan/RendererVk.cpp
+++ b/src/libANGLE/renderer/vulkan/RendererVk.cpp
@@ -4052,7 +4052,10 @@
     // http://anglebug.com/7308
     // Flushing mutable textures causes flakes in perf tests using Windows/Intel GPU. Failures are
     // due to lost context/device.
-    ANGLE_FEATURE_CONDITION(&mFeatures, mutableMipmapTextureUpload, !(IsWindows() && isIntel));
+    // http://b/264143971
+    // The mutable texture uploading feature can sometimes result in incorrect rendering of some
+    // textures.
+    ANGLE_FEATURE_CONDITION(&mFeatures, mutableMipmapTextureUpload, false);
 
     // Retain debug info in SPIR-V blob.
     ANGLE_FEATURE_CONDITION(&mFeatures, retainSPIRVDebugInfo, getEnableValidationLayers());