commit 67333608123cb663eb43c3abba4ad6d1ab4c7b43
author Mohan Maiya <m.maiya@samsung.com> Thu Feb 25 14:15:33 2021 -0800
committer Commit Bot <commit-bot@chromium.org> Fri Feb 26 22:25:58 2021 +0000
tree 280e981f3d8929749a6c06b2d07dd11dbf7f4cad
parent b5af8bde13f6dd28bac94fcba7ed835eced40c64

Vulkan: Check texture type before calling into feedbackloop check

In ContextVk::updateActiveTextures we end up calling this method
shouldSwitchToReadOnlyDepthFeedbackLoopMode(...) for every active
texture. Since color textures are more numerous than depth, check
the texture type beforehand to decrease function stack depth.

This removes 0.5% CPU overhead from a Manhattan30 offscreen run

Bug: angleproject:5689
Change-Id: I14758b031e58b269392b4f450a5bb1ba8edabb44
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2723493
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

src/libANGLE/renderer/vulkan/ContextVk.cpp

diff --git a/src/libANGLE/renderer/vulkan/ContextVk.cpp b/src/libANGLE/renderer/vulkan/ContextVk.cpp
index 685ae3d..bda16f4 100644
--- a/src/libANGLE/renderer/vulkan/ContextVk.cpp
+++ b/src/libANGLE/renderer/vulkan/ContextVk.cpp
@@ -4514,7 +4514,8 @@
             continue;
         }
 
-        if (!isIncompleteTexture && shouldSwitchToReadOnlyDepthFeedbackLoopMode(context, texture))
+        if (!isIncompleteTexture && texture->isDepthOrStencil() &&
+            shouldSwitchToReadOnlyDepthFeedbackLoopMode(context, texture))
         {
             // The "readOnlyDepthMode" feature enables read-only depth-stencil feedback loops. We
             // only switch to "read-only" mode when there's loop. We track the depth-stencil access
@@ -5474,6 +5475,8 @@
 bool ContextVk::shouldSwitchToReadOnlyDepthFeedbackLoopMode(const gl::Context *context,
                                                             gl::Texture *texture) const
 {
+    ASSERT(texture->isDepthOrStencil());
+
     const gl::ProgramExecutable *programExecutable = mState.getProgramExecutable();
 
     // When running compute we don't have a draw FBO.
@@ -5482,8 +5485,7 @@
         return false;
     }
 
-    return texture->isDepthOrStencil() &&
-           texture->isBoundToFramebuffer(mDrawFramebuffer->getState().getFramebufferSerial()) &&
+    return texture->isBoundToFramebuffer(mDrawFramebuffer->getState().getFramebufferSerial()) &&
            !mDrawFramebuffer->isReadOnlyDepthFeedbackLoopMode();
 }