commit bea3f7f9819bfc2007dbc2e60e5d2588b333d615
author Maciej Żenczykowski <maze@google.com> Mon Jan 30 22:29:59 2023 +0000
committer Maciej Żenczykowski <maze@google.com> Mon Jan 30 22:31:29 2023 +0000
tree fbfe1d371bae3ff8cb8dfdad1a1271b7ba4ce44e
parent 9e9da0f3a5899430ec5cb0886aa4fdb3437c6ac6

clatd: introduce MAXDUMPLEN

PACKETLEN is a bad name, let's try to move away from it

Test: TreeHugger
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I56e890d479bc64ed6c31a29772a370f0e83a2ff9

clatd.h

diff --git a/clatd.h b/clatd.h
index e810a3b..4be071c 100644
--- a/clatd.h
+++ b/clatd.h
@@ -43,6 +43,10 @@
 // ie. if we ever read >= MAXMTU bytes we should discard.
 #define MAXMTU (0xFFFF + 28 + 1)
 #define PACKETLEN (sizeof(struct tun_pi) + MAXMTU)
+
+// logcat_hexdump() maximum binary data length
+#define MAXDUMPLEN PACKETLEN
+
 #define CLATD_VERSION "1.5"
 
 #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))

dump.c

diff --git a/dump.c b/dump.c
index 289f161..dff3d5e 100644
--- a/dump.c
+++ b/dump.c
@@ -226,11 +226,11 @@
 
 /* generic hex dump */
 void logcat_hexdump(const char *info, const uint8_t *data, size_t len) {
-  char output[PACKETLEN * 3 + 2];
+  char output[MAXDUMPLEN * 3 + 2];
   size_t i;
 
   output[0] = '\0';
-  for (i = 0; i < len && i < PACKETLEN; i++) {
+  for (i = 0; i < len && i < MAXDUMPLEN; i++) {
     snprintf(output + i * 3, 4, " %02x", data[i]);
   }
   output[len * 3 + 3] = '\0';