commit 17f60ed9e12c5a5839f1af8a71ba3972aed432bd
author Sergii Rudchenko <rudchenkos@gmail.com> Mon Apr 27 08:13:14 2020 +0200
committer GitHub <noreply@github.com> Mon Apr 27 08:13:14 2020 +0200
tree 8aa060cd091e9e7c6f1b165b160fef5cb8a30cb5
parent 9f8e5f80a9f228929bfc6a5f83f1f47abb489cf7

Correct HEIC orientation for the ping operation (#1233) (#1940)

coders/heic.c

diff --git a/coders/heic.c b/coders/heic.c
index 6aee9b3..0b83372 100644
--- a/coders/heic.c
+++ b/coders/heic.c
@@ -258,16 +258,14 @@
   Image *image,struct heif_context *heif_context,heif_item_id image_id,
   ExceptionInfo *exception)
 {
-  const char
-    *option;
-
   int
     stride_y,
     stride_cb,
     stride_cr;
 
   MagickBooleanType
-    status;
+    status,
+    preserve_orientation;
 
   ssize_t
     y;
@@ -308,6 +306,12 @@
   image->depth=8;
   image->columns=(size_t) heif_image_handle_get_width(image_handle);
   image->rows=(size_t) heif_image_handle_get_height(image_handle);
+  preserve_orientation=IsStringTrue(GetImageOption(image_info,
+    "heic:preserve-orientation"));
+
+  if (preserve_orientation == MagickFalse)
+    (void) SetImageProperty(image,"exif:Orientation","1",exception);
+
   if (image_info->ping != MagickFalse)
     {
       image->colorspace=YCbCrColorspace;
@@ -330,14 +334,11 @@
   */
   (void) SetImageColorspace(image,YCbCrColorspace,exception);
   decode_options=(struct heif_decoding_options *) NULL;
-  option=GetImageOption(image_info,"heic:preserve-orientation");
-  if (IsStringTrue(option) == MagickTrue)
+  if (preserve_orientation == MagickTrue)
     {
       decode_options=heif_decoding_options_alloc();
       decode_options->ignore_transformations=1;
     }
-  else
-    (void) SetImageProperty(image,"exif:Orientation","1",exception);
   error=heif_decode_image(image_handle,&heif_image,heif_colorspace_YCbCr,
     heif_chroma_420,decode_options);
   if (decode_options != (struct heif_decoding_options *) NULL)