commit 11131596dee3cf7feabd21a33d1758165fcf3794
author Andy McFadden Wed Apr 08 00:27:58 2009 -0700
committer The Android Open Source Project <initial-contribution@android.com> Wed Apr 08 00:27:58 2009 -0700
tree b75b2b79769c9d5019d9fa64706953d171687456
parent 324f24681c11f80f9f17cdde52047fdd6921440d

AI 144906: Default to failure, not success.

Automated import of CL 144906

libdex/CmdUtils.c

diff --git a/libdex/CmdUtils.c b/libdex/CmdUtils.c
index ca1054c..073d5f9 100644
--- a/libdex/CmdUtils.c
+++ b/libdex/CmdUtils.c
@@ -97,12 +97,12 @@
  *
  * If "quiet" is set, don't report common errors.
  *
- * Returns 0 on success.
+ * Returns 0 (kUTFRSuccess) on success.
  */
 UnzipToFileResult dexOpenAndMap(const char* fileName, const char* tempFileName,
     MemMapping* pMap, bool quiet)
 {
-    UnzipToFileResult result = kUTFRSuccess;
+    UnzipToFileResult result = kUTFRGenericFailure;
     int len = strlen(fileName);
     char tempName[32];
     bool removeTemp = false;

libdex/CmdUtils.h

diff --git a/libdex/CmdUtils.h b/libdex/CmdUtils.h
index fa354a9..e0b0105 100644
--- a/libdex/CmdUtils.h
+++ b/libdex/CmdUtils.h
@@ -34,6 +34,7 @@
 /* encode the result of unzipping to a file */
 typedef enum UnzipToFileResult {
     kUTFRSuccess = 0,
+    kUTFRGenericFailure,
     kUTFRBadArgs,
     kUTFRNotZip,
     kUTFRNoClassesDex,