commit d9e8ad775936ebe92935bf33234af81ac7974add
author Brian Muramatsu <btmura@google.com> Fri May 04 17:53:52 2012 -0700
committer Android (Google) Code Review <android-gerrit@google.com> Fri May 04 17:53:52 2012 -0700
tree df8385b62fabbf64ecb2740ea91bd0b06deb3156
parent a5d922ef39d8b7118b78577c43f0810dda617c64
parent e2fbd914d023191bad71365d385fa21cb5d7fa12

Merge "Fix Flakey View Tests" into jb-dev

tests/tests/view/src/android/view/cts/ViewTest.java

diff --git a/tests/tests/view/src/android/view/cts/ViewTest.java b/tests/tests/view/src/android/view/cts/ViewTest.java
index 2bcb4e7..94aed3f 100644
--- a/tests/tests/view/src/android/view/cts/ViewTest.java
+++ b/tests/tests/view/src/android/view/cts/ViewTest.java
@@ -16,14 +16,9 @@
 
 package android.view.cts;
 
-import com.google.android.collect.Lists;
-
 import com.android.cts.stub.R;
 import com.android.internal.view.menu.ContextMenuBuilder;
-
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.List;
+import com.google.android.collect.Lists;
 
 import android.app.Activity;
 import android.content.Context;
@@ -80,6 +75,10 @@
 import android.widget.ListView;
 import android.widget.cts.StubActivity;
 
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+
 /**
  * Test {@link View}.
  */
@@ -212,7 +211,12 @@
         });
         getInstrumentation().waitForIdleSync();
 
-        assertTrue(view.hasCalledOnAnimationStart());
+        new PollingCheck() {
+            @Override
+            protected boolean check() {
+                return view.hasCalledOnAnimationStart();
+            }
+        }.run();
 
         // check whether it has ended after duration, and alpha changed during this time.
         new PollingCheck(duration + TIMEOUT_DELTA) {
@@ -2268,7 +2272,12 @@
             }
         });
         getInstrumentation().waitForIdleSync();
-        assertTrue(view.hasCalledOnDraw());
+        new PollingCheck() {
+            @Override
+            protected boolean check() {
+                return view.hasCalledOnDraw();
+            }
+        }.run();
 
         view.reset();
         runTestOnUiThread(new Runnable() {
@@ -2300,7 +2309,12 @@
             }
         });
         getInstrumentation().waitForIdleSync();
-        assertTrue(view.hasCalledOnDraw());
+        new PollingCheck() {
+            @Override
+            protected boolean check() {
+                return view.hasCalledOnDraw();
+            }
+        }.run();
 
         view.reset();
         runTestOnUiThread(new Runnable() {
@@ -2326,7 +2340,12 @@
             }
         });
         getInstrumentation().waitForIdleSync();
-        assertTrue(view.hasCalledOnDraw());
+        new PollingCheck() {
+            @Override
+            protected boolean check() {
+                return view.hasCalledOnDraw();
+            }
+        }.run();
 
         view.reset();
         runTestOnUiThread(new Runnable() {
@@ -2352,7 +2371,12 @@
             }
         });
         getInstrumentation().waitForIdleSync();
-        assertTrue(view.hasCalledOnDraw());
+        new PollingCheck() {
+            @Override
+            protected boolean check() {
+                return view.hasCalledOnDraw();
+            }
+        }.run();
 
         view.reset();
         runTestOnUiThread(new Runnable() {
@@ -3059,7 +3083,14 @@
         }.run();
 
         imm.showSoftInput(editText, 0);
-        assertTrue(editText.hasCalledOnCreateInputConnection());
+
+        new PollingCheck() {
+            @Override
+            protected boolean check() {
+                return editText.hasCalledOnCreateInputConnection();
+            }
+        }.run();
+
         assertTrue(editText.hasCalledOnCheckIsTextEditor());
         assertTrue(imm.isActive(editText));
 

tests/tests/view/src/android/view/cts/ViewTreeObserverTest.java

diff --git a/tests/tests/view/src/android/view/cts/ViewTreeObserverTest.java b/tests/tests/view/src/android/view/cts/ViewTreeObserverTest.java
index 1dee2b3..5837290 100644
--- a/tests/tests/view/src/android/view/cts/ViewTreeObserverTest.java
+++ b/tests/tests/view/src/android/view/cts/ViewTreeObserverTest.java
@@ -21,6 +21,7 @@
 import android.app.Activity;
 import android.app.Instrumentation;
 import android.app.cts.MockActivity;
+import android.cts.util.PollingCheck;
 import android.test.ActivityInstrumentationTestCase2;
 import android.test.TouchUtils;
 import android.view.View;
@@ -118,7 +119,7 @@
 
         mViewTreeObserver = b.getViewTreeObserver();
 
-        MockOnTouchModeChangeListener listener = new MockOnTouchModeChangeListener();
+        final MockOnTouchModeChangeListener listener = new MockOnTouchModeChangeListener();
         assertFalse(listener.hasCalledOnTouchModeChanged());
         mViewTreeObserver.addOnTouchModeChangeListener(listener);
 
@@ -130,7 +131,12 @@
         });
         mInstrumentation.waitForIdleSync();
 
-        assertTrue(listener.hasCalledOnTouchModeChanged());
+        new PollingCheck() {
+            @Override
+            protected boolean check() {
+                return listener.hasCalledOnTouchModeChanged();
+            }
+        }.run();
     }
 
     public void testAddOnComputeInternalInsetsListener() {
@@ -282,7 +288,7 @@
 
         mViewTreeObserver = scrollView.getViewTreeObserver();
 
-        MockOnScrollChangedListener listener = new MockOnScrollChangedListener();
+        final MockOnScrollChangedListener listener = new MockOnScrollChangedListener();
         assertFalse(listener.hasCalledOnScrollChanged());
         mViewTreeObserver.addOnScrollChangedListener(listener);
 
@@ -293,7 +299,12 @@
             }
         });
         mInstrumentation.waitForIdleSync();
-        assertTrue(listener.hasCalledOnScrollChanged());
+        new PollingCheck() {
+            @Override
+            protected boolean check() {
+                return listener.hasCalledOnScrollChanged();
+            }
+        }.run();
 
         listener.reset();
         assertFalse(listener.hasCalledOnScrollChanged());