commit c190aa32bc286d3dcfc91201a1ddc137b1507513
author John Reck <jreck@google.com> Mon Jul 15 14:46:17 2019 -0700
committer John Reck <jreck@google.com> Tue Jul 16 23:06:59 2019 +0000
tree ae2baffb6b9dbfdb4eb67db4f65cd9da3d04119f
parent 93f664457027f8a8aed03370fece9507ca787455

Fix usage flags for testWrapHardwareBufferHoldsReference

Fixes an issue where the test was doing CPU access to a gralloc
buffer that did not have CPU_USAGE_WRITE_RARELY set. On some gralloc
implementations it's valid for locking such a buffer to fail, so 
fix the test to conform to gralloc's contract and set the CPU_USAGE_WRITE_RARELY bit.

Bug: 135944408
Test: this
Change-Id: I83eee58ded35c9714ae67b6e729423f7fc3408ab
(cherry picked from commit 35a9dbe51a905ce7faefa22d859466410126c7a1)

tests/tests/graphics/src/android/graphics/cts/BitmapTest.java

diff --git a/tests/tests/graphics/src/android/graphics/cts/BitmapTest.java b/tests/tests/graphics/src/android/graphics/cts/BitmapTest.java
index bbba7a1..a2025bd 100644
--- a/tests/tests/graphics/src/android/graphics/cts/BitmapTest.java
+++ b/tests/tests/graphics/src/android/graphics/cts/BitmapTest.java
@@ -2111,7 +2111,7 @@
     public void testWrapHardwareBufferHoldsReference() {
         Bitmap bitmap;
         // Create hardware-buffer and wrap it in a Bitmap
-        try (HardwareBuffer hwBuffer = createTestBuffer(128, 128, false)) {
+        try (HardwareBuffer hwBuffer = createTestBuffer(128, 128, true)) {
             // Fill buffer with colors (x, y, 42, 255)
             nFillRgbaHwBuffer(hwBuffer);
             bitmap = Bitmap.wrapHardwareBuffer(hwBuffer, ColorSpace.get(Named.SRGB));