Camera: fix wait for preview done timeout issue. DO NOT MERGE.
There are a couple of tests that wait for preview done but never hook up preview
callback, which cause timeout. It doesn't fail the test, but it is wrong and
causes unnecessary 5s timeout wait.
Bug: 11553138
Change-Id: I3a71003964cb750028c0f2b665cd16084f195ef2
diff --git a/tests/tests/hardware/src/android/hardware/cts/CameraTest.java b/tests/tests/hardware/src/android/hardware/cts/CameraTest.java
index f877d8b..802fa5c 100644
--- a/tests/tests/hardware/src/android/hardware/cts/CameraTest.java
+++ b/tests/tests/hardware/src/android/hardware/cts/CameraTest.java
@@ -345,6 +345,17 @@
mCamera.setPreviewCallback(null);
}
+ /**
+ * Start preview and wait for the first preview callback, which indicates the
+ * preview becomes active.
+ */
+ private void blockingStartPreview() {
+ mCamera.setPreviewCallback(new SimplePreviewStreamCb(/*Id*/0));
+ mCamera.startPreview();
+ waitForPreviewDone();
+ mCamera.setPreviewCallback(null);
+ }
+
/*
* Test case 1: Take a picture and verify all the callback
* functions are called properly.
@@ -1152,8 +1163,7 @@
for (int i = 0; i < ratios.size() - 1; i++) {
assertTrue(ratios.get(i) < ratios.get(i + 1));
}
- mCamera.startPreview();
- waitForPreviewDone();
+ blockingStartPreview();
// Test each zoom step.
for (int i = 0; i <= maxZoom; i++) {
@@ -1316,8 +1326,8 @@
private void testFocusDistancesByCamera(int cameraId) throws Exception {
initializeMessageLooper(cameraId);
- mCamera.startPreview();
- waitForPreviewDone();
+ blockingStartPreview();
+
Parameters parameters = mCamera.getParameters();
// Test every supported focus mode.
@@ -1901,8 +1911,7 @@
// Make sure scene mode settings are consistent before preview and
// after preview.
- mCamera.startPreview();
- waitForPreviewDone();
+ blockingStartPreview();
for (int i = 0; i < supportedSceneModes.size(); i++) {
String sceneMode = supportedSceneModes.get(i);
parameters.setSceneMode(sceneMode);
