Fix Activity Lifecycle CTS Tests
Don't check that onSaveInstanceState is called. onSaveInstanceState is
called after onPause now, but onSaveInstanceState may not even be
called anymore.
Change-Id: I4e3e64f730388c01be83221ea364620ab30eee6d
diff --git a/tests/src/android/app/cts/LaunchpadActivity.java b/tests/src/android/app/cts/LaunchpadActivity.java
index fa18ec5..7191e03 100644
--- a/tests/src/android/app/cts/LaunchpadActivity.java
+++ b/tests/src/android/app/cts/LaunchpadActivity.java
@@ -184,20 +184,20 @@
});
} else if (LIFECYCLE_SCREEN.equals(action)) {
addPossibleLifecycle(LIFECYCLE_SCREEN + "_RESTART", new String[] {
- ON_START, ON_RESUME, DO_LOCAL_SCREEN, ON_FREEZE, ON_PAUSE,
+ ON_START, ON_RESUME, DO_LOCAL_SCREEN, ON_PAUSE,
ON_RESTART, ON_START, ON_RESUME, DO_FINISH, ON_PAUSE
});
addPossibleLifecycle(LIFECYCLE_SCREEN + "_RESUME", new String[] {
- ON_START, ON_RESUME, DO_LOCAL_SCREEN, ON_FREEZE, ON_PAUSE,
+ ON_START, ON_RESUME, DO_LOCAL_SCREEN, ON_PAUSE,
ON_RESUME, DO_FINISH, ON_PAUSE
});
} else if (LIFECYCLE_DIALOG.equals(action)) {
addPossibleLifecycle(LIFECYCLE_DIALOG + "_RESTART", new String[] {
- ON_START, ON_RESUME, DO_LOCAL_DIALOG, ON_FREEZE, ON_PAUSE,
+ ON_START, ON_RESUME, DO_LOCAL_DIALOG, ON_PAUSE,
ON_RESTART, ON_START, ON_RESUME, DO_FINISH, ON_PAUSE
});
addPossibleLifecycle(LIFECYCLE_DIALOG + "_RESUME", new String[] {
- ON_START, ON_RESUME, DO_LOCAL_DIALOG, ON_FREEZE, ON_PAUSE,
+ ON_START, ON_RESUME, DO_LOCAL_DIALOG, ON_PAUSE,
ON_RESUME, DO_FINISH, ON_PAUSE
});
}
@@ -399,7 +399,6 @@
@Override
protected void onSaveInstanceState(Bundle icicle) {
super.onSaveInstanceState(icicle);
- checkLifecycle(ON_FREEZE);
if (mBadParcelable) {
icicle.putParcelable("baddy", new MyBadParcelable());
}
@@ -451,13 +450,15 @@
do {
if (mExpectedLifecycle[mNextLifecycle].equals(where)) {
+ Log.w(TAG, "Matched: " + where);
break;
+ } else {
+ Log.w(TAG, "Expected " + mExpectedLifecycle[mNextLifecycle] + " but got " + where);
}
} while (switchToNextPossibleLifecycle());
if (mExpectedLifecycle == null) {
finishBad("Activity lifecycle for " + action + " incorrect: received " + where
- + " but expected " + mExpectedLifecycle[mNextLifecycle]
+ " at " + mNextLifecycle);
return;
}